Re: [FFmpeg-devel] [PATCH v3 1/2] decklink: move queue_size to an argument for ff_decklink_packet_queue_init

[Marton Balint <cus@passwd.hu>]

On Fri, 30 Jun 2023, Devin Heitmueller wrote:

> The existing queue initialization function would always sets it's
> maximum queue size to ctx->queue_size.  But because we are introducing
> more queues we may want the sizes to differ between them.
>
> Move the specification of the queue size into an argument, which can
> be passed from the caller.
>
> This patch makes no functional change to the behavior.  It is being
> made to accommodate Marton Balin's request to split out the queue
> size for the new VANC queue being introduced in a later patch.
>
> Signed-off-by: Devin Heitmueller <dheitmueller@ltnglobal.com>
> ---
> libavdevice/decklink_common.cpp | 4 ++--
> libavdevice/decklink_common.h   | 2 +-
> libavdevice/decklink_dec.cpp    | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/libavdevice/decklink_common.cpp b/libavdevice/decklink_common.cpp
> index b6cc8d7..5e8d612 100644
> --- a/libavdevice/decklink_common.cpp
> +++ b/libavdevice/decklink_common.cpp
> @@ -390,14 +390,14 @@ int ff_decklink_set_format(AVFormatContext *avctx, decklink_direction_t directio
>     return ff_decklink_set_format(avctx, 0, 0, 0, 0, AV_FIELD_UNKNOWN, direction);
> }
>
> -void ff_decklink_packet_queue_init(AVFormatContext *avctx, DecklinkPacketQueue *q)
> +void ff_decklink_packet_queue_init(AVFormatContext *avctx, DecklinkPacketQueue *q, int64_t queue_size)
> {
>     struct decklink_cctx *ctx = (struct decklink_cctx *)avctx->priv_data;

This is now unused.

>     memset(q, 0, sizeof(DecklinkPacketQueue));
>     pthread_mutex_init(&q->mutex, NULL);
>     pthread_cond_init(&q->cond, NULL);
>     q->avctx = avctx;
> -    q->max_q_size = ctx->queue_size;
> +    q->max_q_size = queue_size;
> }

Will apply with the change above.

Thanks,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".