From: Zane van Iperen <zane@zanevaniperen.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/7] avutil/uuid: add utility library for manipulating UUIDs as specified in RFC 4122
Date: Wed, 23 Feb 2022 16:48:42 +1000
Message-ID: <5b70ec35-9294-2494-8c78-21871b564052@zanevaniperen.com> (raw)
In-Reply-To: <Mw_9n23--3-2@lynne.ee>
On 23/2/22 16:01, Lynne wrote:
> Code style
>
Mostly fixed, do these changes look right?
https://github.com/vs49688/FFmpeg/commit/867fffe04ffedf0609260557d1db0ebbc519c4d2
>
> Why the double header in the header file? It doesn't contain
> any libuuid code.
It does, this was copy/pasted from libuuid, then had things stripped from it.
Some examples:
- https://github.com/util-linux/util-linux/blob/d65eb48039a03cdacd5450e644af917a0f08bc88/libuuid/src/unparse.c#L43
- https://github.com/util-linux/util-linux/blob/d65eb48039a03cdacd5450e644af917a0f08bc88/libuuid/src/parse.c#L52
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-23 6:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 13:01 [FFmpeg-devel] [PATCH 0/7] Add UUID functionality to libavutil Zane van Iperen
2022-02-22 13:01 ` [FFmpeg-devel] [PATCH 1/7] avutil/uuid: add utility library for manipulating UUIDs as specified in RFC 4122 Zane van Iperen
2022-02-22 14:21 ` James Almer
2022-02-23 6:53 ` Zane van Iperen
2022-02-28 3:22 ` Pierre-Anthony Lemieux
2022-02-22 15:01 ` Zane van Iperen
2022-02-23 6:01 ` Lynne
2022-02-23 6:48 ` Zane van Iperen [this message]
2022-02-23 7:01 ` Zane van Iperen
2022-02-23 9:54 ` Lynne
2022-02-23 10:40 ` Zane van Iperen
2022-02-22 13:01 ` [FFmpeg-devel] [PATCH 2/7] avutil/tests/uuid: add uuid tests Zane van Iperen
2022-02-22 13:01 ` [FFmpeg-devel] [PATCH 3/7] avformat/mov: refactor to use avutil/uuid Zane van Iperen
2022-02-22 13:01 ` [FFmpeg-devel] [PATCH 4/7] avformat/smoothstreamingenc: " Zane van Iperen
2022-02-22 13:01 ` [FFmpeg-devel] [PATCH 5/7] avcodec/cbs_sei: " Zane van Iperen
2022-02-22 13:01 ` [FFmpeg-devel] [PATCH 6/7] avformat/imf: " Zane van Iperen
2022-02-22 13:01 ` [FFmpeg-devel] [PATCH 7/7] avfilter/showinfo: " Zane van Iperen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b70ec35-9294-2494-8c78-21871b564052@zanevaniperen.com \
--to=zane@zanevaniperen.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git