From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration
Date: Tue, 27 Dec 2022 19:05:44 +0100 (CET)
Message-ID: <5b588572-8983-729f-2456-f6f756a76f26@passwd.hu> (raw)
In-Reply-To: <20221226215412.GP3806951@pb2>
On Mon, 26 Dec 2022, Michael Niedermayer wrote:
> On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas Härdin wrote:
>> lör 2022-12-24 klockan 23:50 +0100 skrev Michael Niedermayer:
>>>
>>> index_table->nb_ptses += s->index_duration;
>>> + // If index_duration is substantially larger than
>>> nb_index_entries then this algorithm which
>>> + // allocates index_duration elements is a bad idea. All
>>> files i tried have it equal
>>> + if (s->index_duration > 10LL * s->nb_index_entries)
>>> + return AVERROR_PATCHWELCOME;
>>
>> I was going to say this can overflow but the 10LL ensures it can't. So
>> looks OK.
>
> will apply
Please don't, as far as I see this disallows the usage of partial index
tables, so practically rejecting valid files, which is not OK.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-12-27 18:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-24 22:50 Michael Niedermayer
2022-12-26 10:32 ` Tomas Härdin
2022-12-26 21:54 ` Michael Niedermayer
2022-12-27 18:05 ` Marton Balint [this message]
2022-12-27 21:49 ` Michael Niedermayer
2022-12-27 22:32 ` Marton Balint
2022-12-28 2:26 ` Marton Balint
2022-12-28 3:19 ` [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: check index entry array size Marton Balint
2022-12-28 3:19 ` [FFmpeg-devel] [PATCH 2/3] avformat/mxfdec: support Avid files with an extra index entry Marton Balint
2022-12-28 3:19 ` [FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: check number of index table entires more strictly Marton Balint
2023-01-22 0:05 ` [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration Marton Balint
2023-01-29 11:15 ` Marton Balint
2022-12-27 22:35 ` Tomas Härdin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b588572-8983-729f-2456-f6f756a76f26@passwd.hu \
--to=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git