From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 352BA44A18 for ; Tue, 6 Dec 2022 08:57:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 123A168BD40; Tue, 6 Dec 2022 10:57:15 +0200 (EET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1062D68BBAF for ; Tue, 6 Dec 2022 10:57:06 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670317032; x=1701853032; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=atXRA4a3BSPjY0kH+ewUpKIBByOSTpbxXPuWj7QehUY=; b=kKsuZsk0FJww+OPo08/SEIF899//Owp+/lVHnkDcLTeWIad7BrDVT/px lhEE+Y7lruU1SXvV1oCFNUz5hU9H09f+s2Pp7LrzmCqlQax16t/yOhe4w 6pDZb6iAUlIFcE/9JuqyVYMqj4WPP2HZGG4s7GQTABFzv63a3AYe4OIwq jSnupdVcvw49Kh0MrpMYeeGjcKe6n2fHt2B350Yh4Bo4TPWpRwwfxAfyF oCMDsrq6SXeSfxzyroUb6oBi7A+kdfA3EFx5OC2VIJbJmiJ3dnIyMIWAv kwV1tlY1ksjGONcpT4fG2oMe9yXEkiUC8GQ9lQV3lC1mIoIaXAMszgWuQ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10552"; a="296266114" X-IronPort-AV: E=Sophos;i="5.96,220,1665471600"; d="scan'208";a="296266114" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 00:57:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10552"; a="646142579" X-IronPort-AV: E=Sophos;i="5.96,220,1665471600"; d="scan'208";a="646142579" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 06 Dec 2022 00:57:03 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 6 Dec 2022 00:57:03 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 6 Dec 2022 00:57:03 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 6 Dec 2022 00:57:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BqHGTbTtFYRhrXY6bqlmg3kJYdkiYdOLBmH9lJkwZWxzxens5upiT8NjS7tPsMt3l3Pp2uFrxyS1JgouC3ZoFAbfBv9N3Pq6ksH7PZ4DdQNF8xX7puF6+idc2o4chUuqxzhNu1SfHOC6gqhbdXattGLJNgooYfip0ppMf9G7qHXxBgCofdLGb7MTC0Wh2zdnYlGmcPkhVUpypJaxd3J8Jw5AoRnqKoWw3Uzg6Z4/UsTQKDqEaq2A8mqCfyeMLw5m+9KbSHeDGWpsb1lJfyVaB0F3sUkpGnduh0jgtgaYdSNJyy3CZmcXZ411O0u8U9QmXbKvP/mjsaY+rB717ae6iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=atXRA4a3BSPjY0kH+ewUpKIBByOSTpbxXPuWj7QehUY=; b=i51myHma2aCbR6van8LzE2RsTW05imP/8Ib0VUBsO03kc+5EvIEjkREagtD/xWhq/D9zGjdJRPofZFGz5oxpCFjZuxXtZ1bzI7Pu7rqCo/TlySJlJ+n2uKNz+QQqEgNaDH1NbVUp/95gnKmYWZ3IyL8aErdw7tdT/VB+TnlFsk87zMQQjT+zMch9dmoyQBWjEA7P8wnca52tN/fjCOu8ibw2JWMilbBUSBP8w83RPQT/7rUQ8YcqHnQ9+/rYXQf2QZ1v3m8Jm9Xq3QnKU9iCtFCydBrKiN+mV0dEG58K4+CDqFQWGJJ5dn/uzO5oaknR5D9GKBYZsq6qJ0SndCdhdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by PH0PR11MB7710.namprd11.prod.outlook.com (2603:10b6:510:298::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Tue, 6 Dec 2022 08:57:01 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::27dc:d5e0:94b2:6e9b]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::27dc:d5e0:94b2:6e9b%3]) with mapi id 15.20.5880.011; Tue, 6 Dec 2022 08:57:01 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v5 2/2] lavc/vaapi_decode: add support for HWACCEL_CAP_RESET_WITHOUT_UNINIT Thread-Index: AQHY98a14IDzRXG/ME6ql34m+u/75q5UaPEAgAP3ZwCACFF3gA== Date: Tue, 6 Dec 2022 08:57:01 +0000 Message-ID: <5b42d67470ed5605e05a76b64cf5569f197317f1.camel@intel.com> References: <20221114011605.1157707-1-fei.w.wang@intel.com> <20221114011605.1157707-2-fei.w.wang@intel.com> <4dfc60cca206ca496fd8ed2ba07a4f0faa91175a.camel@intel.com> In-Reply-To: <4dfc60cca206ca496fd8ed2ba07a4f0faa91175a.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5030:EE_|PH0PR11MB7710:EE_ x-ms-office365-filtering-correlation-id: 02a1f767-2f79-4ed3-6dfc-08dad767d705 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gbWbnN/Xfa1h/vXTjUGtHRrjST1z0yFWgpL6CIXWMAeO4wIIgyv2FkPFDLB7hIVcil6ALMhAYm/kHsb9aXbfnbRQSxo498UMRfOKeSwIOzOFCjvSMYWAvvko/TOm8pUQBX1OvgCoCPtRizFMzu0aCqxh+V2YU6JGWeSyGppY5DLWdA6hb8VnF42y3I4omufPwyeMTcFm5KEE6Co6//CeUZofPWd3PMv8srlzKV52osWjoZ2snyvcY2sqmrtEQr5882SojRxDZHe30kxOWNHqUMD5KH44bybRPZ48hMCXw7Dt0c/sM1NopA3JA12Wxx+m19VKjg82QeePv0hQjEVaiCF5FqQUB/JIzlFw/FYpgAcieSu5GuEiwWGLoBC/BSBuB5qOdfLaX+pK3WJxBZxWAvuAgUYL2BvEhJWR7GY3QBa8lD6uNoIdWIDU5pFawwvhwa9FOo8TmLjjw8LJ7sO6gARy8wd/zx5Ia6zlANmDG7nh+NHk6ppMQ5RhZqdjU2qARzbSvdpG+mvnMLIA9MAaz/QOfzhw23WOm+J9D291YqsKJAjrzgHa2brl68GgIqjpf82vj15Rr10aWH+MI8R4lldKIVhgSMFU6bsiWcD/OoflViAPp8GN1eCGDsLdOkuNDaPG9R4iGhajToq2s/NqLYXbxlB9nJUxw16CL0kTX215P2+2BlLiK+w23sGFMUsJ87614NwR63p9ADXhLxi8hsEI4/mG2t7Vwg7psW2XttYtgLm3Q+95N10FlPHUqdziGXVrzLDwbuFafFX3QbwbnHOgPTbynmyyGcqTErH4/AU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(136003)(396003)(39860400002)(346002)(376002)(451199015)(91956017)(186003)(2616005)(82960400001)(5660300002)(41300700001)(66556008)(36756003)(86362001)(64756008)(83380400001)(66446008)(66476007)(71200400001)(478600001)(966005)(6486002)(38070700005)(6512007)(6506007)(76116006)(53546011)(6916009)(26005)(316002)(66946007)(2906002)(8676002)(66899015)(122000001)(38100700002)(4001150100001)(8936002)(376344004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dXAyM3BlVExTTm5CaVZLN0JyVUNPQzNjREdRU2ZWTGhQUVJaNThsNWNqNERY?= =?utf-8?B?SVZneXNsTGh1aGVVSVZTOUR1ZElITWNnVlZEQllveWdyUFlPZUVER2Ezdnc3?= =?utf-8?B?UVJMc3hSTWI1TzYrRkhZS0VUTFFHTFE2eHdkTkFOOHFXVkUyRE5xT0sxY09k?= =?utf-8?B?bDUwLzFoMkhCZklWVmEyZCtoZzlMcG5hSUJVbFE0QUVUOS9QaDJuaVhIbzlS?= =?utf-8?B?NERUeDd6QzJKN01hcldCbHdhS01qaUFTanVaUW9waFNNcUtMS3pvOVNVWi8y?= =?utf-8?B?VlhHKzRVUEFPcktnZURFd3YzbHpKeFRSU3kzdmdkcVpnajZRVXlRalZSNnlr?= =?utf-8?B?N2Nrb0c2Qm5ZbVFtTVd4a21kbnJHUy9tK1RUYnFqaHZOQUZoenhVMG9leDhn?= =?utf-8?B?TnpyYmZ1THZjZ3FySjQ4aXRQTlNTR2tzVjBhMytDMGhlRXBlTGM4cmZZb0Y5?= =?utf-8?B?aExKbjhQUllkUWxydTF3ODhORS96bHoraEs0VTRnaE1UMlJ1S2tsQ3k3RThl?= =?utf-8?B?aDdqRGRSbE9FZ2kwaVZIMktyTmdOSkErcUVSV0xPbWM4S0gyeU1XQks4cVBG?= =?utf-8?B?NmJrQURyaklXTXFyS1VQcDhVc294RHhKRnpIQXJBY2pMLzZocVpTb2lqR1Fx?= =?utf-8?B?Ny9JWUJ0UDJ3V3RCMERPTjJIV082NVlyUVNWU0lteEN6MU02RU9SOXpqTHpE?= =?utf-8?B?RmlTZ0Fva1VEVlR5ci9CWFlGWUR3SmNqM25YVndDejcxaVVyY3h4RDh4b1ZE?= =?utf-8?B?b1RRWmZIdFNLcGVXOVBhM2o2dUFER2N2aENXczZuc0FOLzY5dE5RdjJ6UU1v?= =?utf-8?B?dEZob2pTaUhlZmQxUkpqbzdVMWFqeHRiYVZiNzVRSDBqNmROV1hvQU9va2xo?= =?utf-8?B?RDBraEJqaXErb0RWOXBacGlOMFRSTGx6bnBES2w4MTViYytHVFkxYUExZlF0?= =?utf-8?B?UENLZ2dOOWF0VWNrR1JJdXhYNUs5ZVVhZ3RWSVVILzNtZWVabVpvL3JqK2xu?= =?utf-8?B?dEtUMnJRU0Nqc0pVZnpRTjJuRkNYcGpKazBraXFmM243bjlmbC8vaTRrYVFv?= =?utf-8?B?aDJSZjRRYTN3SkR0MTZ0YVZSRTNndTlEOG40cmlqUGVjS2JaKytseEJVWVQr?= =?utf-8?B?V2RUZlErQXFRR1J2Q2JLT01NSVZMVytUUXRCNlk0NktpbURVcnRGSHlpcFJ0?= =?utf-8?B?OHQ5UlMzelVFbmM5KzVSdUc1RTk5TnVSQ1NvT2h2eC9WOXZkOGQwYzBOMmdT?= =?utf-8?B?V3kzVU5TY3F6ZkppeHhValBoWlhGQ1hCQWVPTWpOcW9xY1hNWEVyZi8rRHJo?= =?utf-8?B?RDYxU2piZzZhSDlwRTZCamxDL3YyMG85Z2pPZG1jcmtJUVdsMStFMGpTVVJC?= =?utf-8?B?VVBucTdWRTBDSWZDYUdjVHJUZEZRVmFIaWQvd081SGJGV2FnRWxEWVM2Yysv?= =?utf-8?B?N25PV2JTaDNWcm1GRi9SY1pVNUxETDlBYXZob25qQWtCSVJlQnFuZHJkNTNh?= =?utf-8?B?NmFFaWtoa29Fd1VSa3kvc0lUYmt4YitjbVEvaHJhZVRzbmhZWU93MnRXK00x?= =?utf-8?B?RUl0bEpPKzFiemg2bVNDRVkydkFjSm9MNG40MitjclJzQVpXRldpOXNJRmp2?= =?utf-8?B?UUsrZmJyZVFURlUvUFBJMzNScmpJTjRYT3IxYUR2T0hqWU95dzlGWDh5RXhV?= =?utf-8?B?SE9wRXZjYmhsUXdJNTlJcEd1ZEFpcy9XTVZhRkprRzlVVmljOEtManNzWVdX?= =?utf-8?B?TDk1dE52UFJCLzAyTnNBcjB3Nnkzd1JkMmtkb3Rib3ZjMkY0anAzK1pKdUs3?= =?utf-8?B?N2VwVXB0V3hwVzNqMGhwRU9ybUhwekVKdnJhMEVuSHFxak5IUDZveHZ3SFBq?= =?utf-8?B?UDAyQVpraE80RzBINXJuOG5YR3ZjZnN6aUxOQWdWd1hRMG53Q2lUcXdxNjNG?= =?utf-8?B?VDBibk5xWFRENlBvYzVZVHY1VlNOQU45ZlplV092Sncwd1pVOS8zeVUzNytS?= =?utf-8?B?RXFiNWdOaFdnUXVKOUdFa2Z0VTNaTzZvWDBiOGdTb3ZXNFdUWVFrdTN6L2Rh?= =?utf-8?B?TmpnazFvVXQraG04QjF6dUFjbUhucEhBckplQ1o4Smlyb2Zwb2JJNTVMNng4?= =?utf-8?B?MHUzWWNsaWRYRXQzdmk0VGhYY1VpZnRITHY1UnFzNG9kcWkwRjdEaWEybDRs?= =?utf-8?B?eHc9PQ==?= Content-ID: <321779C7B3F4CF4B9662C492321611B7@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02a1f767-2f79-4ed3-6dfc-08dad767d705 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2022 08:57:01.5094 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w1cv76JtLvwf46uNmZ9yhNml36NZs795Fc8aBZkKjSzJSBZEUlX3FOlcvFV1AOBnmOjgYwW4UFf58ZfbgwmypA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7710 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v5 2/2] lavc/vaapi_decode: add support for HWACCEL_CAP_RESET_WITHOUT_UNINIT X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2022-12-01 at 09:55 +0800, Fei Wang wrote: > On Mon, 2022-11-28 at 13:20 +0000, Mark Thompson wrote: > > On 14/11/2022 01:16, Fei Wang wrote: > > > This can fix vp9 decode image corruption when the frame size is > > > change, > > > but the pervious frames still be referenced. > > > > > > Surfaces don't need to be bound to vaContext only after VAAPI > > > 1.0.0: > > > https://github.com/intel/libva/commit/492b692005ccd0d8da190209d5b3ae7b7825f4b8 > > > > > > Signed-off-by: Fei Wang > > > --- > > > libavcodec/vaapi_decode.c | 11 ++++++++--- > > > libavcodec/vaapi_decode.h | 1 + > > > libavcodec/vaapi_vp9.c | 4 ++++ > > > 3 files changed, 13 insertions(+), 3 deletions(-) > > > > This always segfaults immediately on anything unsupported. E.g. > > with > > fate/hevc/paramchange_yuv420p_yuv420p10.hevc: > > > > [hevc @ 0x555557c0e7c0] Format vaapi chosen by get_format(). > > [hevc @ 0x555557c0e7c0] Format vaapi requires hwaccel > > initialisation. > > [hevc @ 0x555557c0e7c0] Hardware does not support image size > > 1056x8440 (constraints: width 0-4096 height 0-4096). > > > > Thread 20 "av:hevc:df0" received signal SIGSEGV, Segmentation > > fault. > > [Switching to Thread 0x7fffb4ff9700 (LWP 509456)] > > ff_vaapi_decode_uninit (avctx=0x555557c0e7c0) at > > src/libavcodec/vaapi_decode.c:714 > > 714 vas = vaDestroyContext(ctx->hwctx->display, ctx- > > > va_context); > > (gdb) bt > > #0 ff_vaapi_decode_uninit (avctx=0x555557c0e7c0) at > > src/libavcodec/vaapi_decode.c:714 > > #1 0x00005555563073d7 in ff_vaapi_decode_init > > (avctx=0x555557c0e7c0) > > at src/libavcodec/vaapi_decode.c:704 > > #2 0x0000555555e62fee in hwaccel_init (avctx=0x555557c0e7c0, > > hw_config=0x55555728f770 <__compound_literal.0>) at > > src/libavcodec/decode.c:1121 > > #3 0x0000555555e634ec in ff_get_format (avctx=0x555557c0e7c0, > > fmt=0x7fffb4ff8ccc) at src/libavcodec/decode.c:1261 > > #4 0x00005555561ca829 in ff_thread_get_format > > (avctx=0x555557c0e7c0, > > fmt=0x7fffb4ff8ccc) at src/libavcodec/pthread_frame.c:1048 > > #5 0x0000555555f68f37 in get_format (s=0x555557c3e6c0, > > sps=0x555557c21f80) at src/libavcodec/hevcdec.c:505 > > #6 0x0000555555f69621 in hls_slice_header (s=0x555557c3e6c0) at > > src/libavcodec/hevcdec.c:618 > > #7 0x0000555555f7472d in decode_nal_unit (s=0x555557c3e6c0, > > nal=0x7fff8802e920) at src/libavcodec/hevcdec.c:3173 > > #8 0x0000555555f7508a in decode_nal_units (s=0x555557c3e6c0, > > buf=0x7ffff637c010 "", length=159280) at > > src/libavcodec/hevcdec.c:3355 > > #9 0x0000555555f756d6 in hevc_decode_frame (avctx=0x555557c0e7c0, > > rframe=0x555557c0ecc0, got_output=0x555557c0d690, > > avpkt=0x555557c0ef40) at src/libavcodec/hevcdec.c:3497 > > #10 0x00005555561c839c in frame_worker_thread (arg=0x555557c0d580) > > at > > src/libavcodec/pthread_frame.c:241 > > #11 0x00007ffff68ccea7 in start_thread (arg=) at > > pthread_create.c:477 > > #12 0x00007ffff67ecaef in clone () at > > ../sysdeps/unix/sysv/linux/x86_64/clone.S:95 > > (gdb) > > Thanks, will fix this in next version. > > > > > Also, I don't see how this is testing whether the driver supports > > changing the resolution at runtime? The note in libva that you > > cite > > allows new switching render targets in the context, but I don't see > > why different resolution would be allowed given that it's a > > parameter > > passed to vaCreateContext()? > > > > Looking at the Mesa driver it appears that the internally-allocated > > references are not going to allow size changes (where does the > > template width get updated?). I don't have any hardware to test > > that, though - are you able to try this on recent AMD hardware with > > VP9 support? > > I checked on AMD RX6700XT, it can get correct output when decoding > multi-resolution vp9 clips only after apply this patchset. For > example, > by using clip from: > https://storage.googleapis.com/downloads.webmproject.org/vp9/decoder-test-streams/Profile_0_8bit.zip > > VP9 native decode result: > ffmpeg -i > Profile_0_8bit/frm_resize/crowd_run_1080X512_fr30_bd8_frm_resize_l3.w > eb > m -pix_fmt yuv420p -autoscale 0 -f md5 -y - > [...] > MD5=51b3393fa98ad9ab99c0b45ef705ebc4 > [...] > > Without this patchset: > ffmpeg -v verbose -hwaccel vaapi -i > Profile_0_8bit/frm_resize/crowd_run_1080X512_fr30_bd8_frm_resize_l3.w > eb > m -pix_fmt yuv420p -autoscale 0 -f md5 -y - > [...] > [AVHWDeviceContext @ 0x56526336a000] VAAPI driver: Mesa Gallium > driver > 22.3.0-rc4 for AMD Radeon RX 6700 XT (navi22, LLVM 11.0.0, DRM 3.44, > 5.13.0-40-generic). > [...] > MD5=2e799f0f916195f86a356907f7e4eae1 (change from time to time, but > never same with native decode result) > [...] > > With this patchset: > ffmpeg -v verbose -hwaccel vaapi -i > Profile_0_8bit/frm_resize/crowd_run_1080X512_fr30_bd8_frm_resize_l3.w > eb > m -pix_fmt yuv420p -autoscale 0 -f md5 -y - > [...] > [AVHWDeviceContext @ 0x561c08e7a000] VAAPI driver: Mesa Gallium > driver > 22.3.0-rc4 for AMD Radeon RX 6700 XT (navi22, LLVM 11.0.0, DRM 3.44, > 5.13.0-40-generic). > [...] > MD5=51b3393fa98ad9ab99c0b45ef705ebc4 > [...] > > That means both Intel and AMD driver implementation doesn't limit > surface's resolution must be same with vacontext. So I think we can > add > some description to libva to declare that. Hi Mark, New interface added to libva to query driver's attributes. Could you give your comments on this PR if you have? https://github.com/intel/libva/pull/636 Thanks Fei > > > What have you done to verify the METHOD_HW_FRAMES_CTX > > behaviour? This has changed so that vaapi_decode_make_config() is > > no > > longer called, which feels possibly-bad though I'm unsure of the > > exact consequences. > > > > As I said last time, I do think you should only do this in exactly > > the places where it is required, and not change any other > > behaviour. > > vaapi_decode_make_config() is called by ff_decode_get_hw_frames_ctx() > in ff_vaapi_decode_init. So the change to vaapi_decode_make_config > doesn't impact the final result. > To avoid confusion, I will not change its behaviour in next version. > > Thanks > Fei > > > Thanks, > > > > - Mark > > > > > diff --git a/libavcodec/vaapi_decode.c > > > b/libavcodec/vaapi_decode.c > > > index 134f10eca5..d950471b6d 100644 > > > --- a/libavcodec/vaapi_decode.c > > > +++ b/libavcodec/vaapi_decode.c > > > @@ -658,9 +658,6 @@ int ff_vaapi_decode_init(AVCodecContext > > > *avctx) > > > VAStatus vas; > > > int err; > > > > > > - ctx->va_config = VA_INVALID_ID; > > > - ctx->va_context = VA_INVALID_ID; > > > - > > > err = ff_decode_get_hw_frames_ctx(avctx, > > > AV_HWDEVICE_TYPE_VAAPI); > > > if (err < 0) > > > goto fail; > > > @@ -670,6 +667,12 @@ int ff_vaapi_decode_init(AVCodecContext > > > *avctx) > > > ctx->device = ctx->frames->device_ctx; > > > ctx->hwctx = ctx->device->hwctx; > > > > > > + if (ctx->inited) > > > + return 0; > > > + > > > + ctx->va_config = VA_INVALID_ID; > > > + ctx->va_context = VA_INVALID_ID; > > > + > > > err = vaapi_decode_make_config(avctx, ctx->frames- > > > > device_ref, > > > &ctx->va_config, NULL); > > > if (err) > > > @@ -691,6 +694,8 @@ int ff_vaapi_decode_init(AVCodecContext > > > *avctx) > > > av_log(avctx, AV_LOG_DEBUG, "Decode context initialised: " > > > "%#x/%#x.\n", ctx->va_config, ctx->va_context); > > > > > > + ctx->inited = 1; > > > + > > > return 0; > > > > > > fail: > > > diff --git a/libavcodec/vaapi_decode.h > > > b/libavcodec/vaapi_decode.h > > > index 6beda14e52..62a4f37ed9 100644 > > > --- a/libavcodec/vaapi_decode.h > > > +++ b/libavcodec/vaapi_decode.h > > > @@ -61,6 +61,7 @@ typedef struct VAAPIDecodeContext { > > > int surface_count; > > > > > > VASurfaceAttrib pixel_format_attribute; > > > + int inited; > > > } VAAPIDecodeContext; > > > > > > > > > diff --git a/libavcodec/vaapi_vp9.c b/libavcodec/vaapi_vp9.c > > > index 776382f683..245b7a1b3a 100644 > > > --- a/libavcodec/vaapi_vp9.c > > > +++ b/libavcodec/vaapi_vp9.c > > > @@ -181,5 +181,9 @@ const AVHWAccel ff_vp9_vaapi_hwaccel = { > > > .uninit = ff_vaapi_decode_uninit, > > > .frame_params = ff_vaapi_common_frame_params, > > > .priv_data_size = sizeof(VAAPIDecodeContext), > > > +#if VA_CHECK_VERSION(1, 0, 0) > > > + .caps_internal = HWACCEL_CAP_ASYNC_SAFE | > > > HWACCEL_CAP_RESET_WITHOUT_UNINIT, > > > +#else > > > .caps_internal = HWACCEL_CAP_ASYNC_SAFE, > > > +#endif > > > }; > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".