From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AAB8C4526A for ; Thu, 16 Feb 2023 00:31:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CEDB768BD87; Thu, 16 Feb 2023 02:31:34 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2880F68019F for ; Thu, 16 Feb 2023 02:31:29 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 1D12BE8724 for ; Thu, 16 Feb 2023 01:31:28 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id an0Ar28RbOnv for ; Thu, 16 Feb 2023 01:31:25 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id E52B6E6808 for ; Thu, 16 Feb 2023 01:31:24 +0100 (CET) Date: Thu, 16 Feb 2023 01:31:24 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <167644570789.1179.9031025057936092636@lain.khirnov.net> Message-ID: <5b166f7a-5616-2735-3cb3-3181dd23553e@passwd.hu> References: <20230213213754.15081-1-cus@passwd.hu> <167638095592.1179.14158207168895102232@lain.khirnov.net> <104f45b8-f7b-477b-853-e3565271d850@passwd.hu> <167644570789.1179.9031025057936092636@lain.khirnov.net> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat: deprecate AVFormatContext io_close callback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 15 Feb 2023, Anton Khirnov wrote: > Quoting Marton Balint (2023-02-14 21:30:09) >> >> >> On Tue, 14 Feb 2023, Anton Khirnov wrote: >> >>> Quoting Marton Balint (2023-02-13 22:37:54) >>>> diff --git a/libavformat/version.h b/libavformat/version.h >>>> index 904e7f06aa..7ff1483912 100644 >>>> --- a/libavformat/version.h >>>> +++ b/libavformat/version.h >>>> @@ -31,7 +31,7 @@ >>>> >>>> #include "version_major.h" >>>> >>>> -#define LIBAVFORMAT_VERSION_MINOR 2 >>>> +#define LIBAVFORMAT_VERSION_MINOR 3 >>> >>> I don't think this needs a version bump, because nothing about the API >>> or ABI changes with this commit, it's just an expression of intent to >>> change it in the future. >> >> My concern with not increasing the version number is that the entry in >> doc/APIChanges will not point to the version where the change happened... > > I don't see that as a problem, because the relevant question from the > user perspective is "in what version was the replacement for added" > rather than "in what version was deprecated", since one should > always use the newer API when it is present. Ok, applied without the bump. Thanks, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".