Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat: deprecate AVFormatContext io_close callback
Date: Thu, 16 Feb 2023 01:31:24 +0100 (CET)
Message-ID: <5b166f7a-5616-2735-3cb3-3181dd23553e@passwd.hu> (raw)
In-Reply-To: <167644570789.1179.9031025057936092636@lain.khirnov.net>



On Wed, 15 Feb 2023, Anton Khirnov wrote:

> Quoting Marton Balint (2023-02-14 21:30:09)
>>
>>
>> On Tue, 14 Feb 2023, Anton Khirnov wrote:
>>
>>> Quoting Marton Balint (2023-02-13 22:37:54)
>>>> diff --git a/libavformat/version.h b/libavformat/version.h
>>>> index 904e7f06aa..7ff1483912 100644
>>>> --- a/libavformat/version.h
>>>> +++ b/libavformat/version.h
>>>> @@ -31,7 +31,7 @@
>>>>
>>>>  #include "version_major.h"
>>>>
>>>> -#define LIBAVFORMAT_VERSION_MINOR   2
>>>> +#define LIBAVFORMAT_VERSION_MINOR   3
>>>
>>> I don't think this needs a version bump, because nothing about the API
>>> or ABI changes with this commit, it's just an expression of intent to
>>> change it in the future.
>>
>> My concern with not increasing the version number is that the entry in
>> doc/APIChanges will not point to the version where the change happened...
>
> I don't see that as a problem, because the relevant question from the
> user perspective is "in what version was the replacement for <x> added"
> rather than "in what version was <x> deprecated", since one should
> always use the newer API when it is present.

Ok, applied without the bump.

Thanks,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2023-02-16  0:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 21:37 Marton Balint
2023-02-14 13:22 ` Anton Khirnov
2023-02-14 20:30   ` Marton Balint
2023-02-15  7:21     ` Anton Khirnov
2023-02-16  0:31       ` Marton Balint [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b166f7a-5616-2735-3cb3-3181dd23553e@passwd.hu \
    --to=cus@passwd.hu \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git