From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] A-pac demuxer and decoder
Date: Fri, 23 Sep 2022 15:31:15 -0300
Message-ID: <5af5416b-1acf-9d80-6de2-d13db9e17c0e@gmail.com> (raw)
In-Reply-To: <CAPYw7P6arVSmzk61pJ9U0NNQjCvbz_O64ZCfs_W82BHvDRdDUA@mail.gmail.com>
On 9/21/2022 4:23 AM, Paul B Mahol wrote:
> Patches attached.
[...]
> +static av_cold int apac_close(AVCodecContext *avctx)
> +{
> + APACContext *s = avctx->priv_data;
> +
> + av_freep(&s->bitstream);
> + s->bitstream_size = 0;
> +
> + for (int ch = 0; ch < avctx->ch_layout.nb_channels; ch++) {
for (int ch = 0; ch < FF_ARRAY_ELEMS(s->ch); ch++)
As Andreas mentioned on IRC, this will crash if you try to initialize
the decoder by setting more than 2 channels otherwise.
> + ChContext *c = &s->ch[ch];
> +
> + av_audio_fifo_free(c->samples);
> + }
> +
> + return 0;
> +}
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-09-23 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 7:23 Paul B Mahol
2022-09-23 17:48 ` Paul B Mahol
2022-09-23 18:31 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5af5416b-1acf-9d80-6de2-d13db9e17c0e@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git