From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 62D4B4050C for ; Tue, 25 Jan 2022 03:22:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8A85368B0A4; Tue, 25 Jan 2022 05:22:50 +0200 (EET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6476F68AFBD for ; Tue, 25 Jan 2022 05:22:44 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643080969; x=1674616969; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=C5HhDXimnhDoLkkoNsiFnCXatM+TdiccOzDF2h41L5A=; b=gODZXRwZHLEOMWmEqrEO51hNtb33YygLldscg4l0WosddJZ9NKc7J+Rj 0aI0HiSUXY8cyAG91ArolULTYKkE1iJZTr0RNzFZisY+QFQclJLiYvEQN VDi5QdwqMMWuJa+m+L9h1JD0+64Lc4BSh/1yrl8pgZlV+jguUcB9hMDyF DxYo9bSiyaU4fJkU9jY2EsDq6jDFUR32v6sp0f/z1VQNAVd0jriUvFlCO grUV9S57p9J0WMG1aDYldojpTZCZzMeboN3Ld66161Mbo6uZzqPqJSgjD 1WLrPapTy6S7R5TI35jlCyNfDb/qDNyTdTDCVbykop2+vEPwlKaapRPMT g==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="243805898" X-IronPort-AV: E=Sophos;i="5.88,314,1635231600"; d="scan'208";a="243805898" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2022 19:22:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,314,1635231600"; d="scan'208";a="673850041" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 24 Jan 2022 19:22:42 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 24 Jan 2022 19:22:42 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 24 Jan 2022 19:22:41 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 24 Jan 2022 19:22:41 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 24 Jan 2022 19:22:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jWZqP1EvExYEDRwK89dj/luxsQWiY8HCITVAiA2RSYCheKMei9yeMt5F0EEgE1iZQ1hywyUeKrlIYcDqKV3Ma9gGiDOUrO1yuw+SZELMEN7GaoungqBXi3WEFBgAmIVSMZU8bmzy9CLHW+P07bXrRlFPvHp5ZKzhVeC4bUg5nCGcbJBSds0pJvJScw6ox6F6L9uIWZDgufTa082oUnkmLRPqv4WXiFOCmZyHjTH50omM+jDhLcyXw2FnVlY2uKMtREribvdInUzfEx4zTxDt2aC3gp8tQKsnOA6nZ5VcE546J6oI1oU7/okSeNqkB9+/YjiUzdX88z4fKL3E9p/r2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C5HhDXimnhDoLkkoNsiFnCXatM+TdiccOzDF2h41L5A=; b=Zc4V1eFKKBgz5vGCjUWJRblq9VxgUQa8sg+6i4pO26Gv8P5NwEfQH7hGLhAZ81YMzLYPkHZknm4+04KyS1qZI8gqrX4++6ULOWl2g6ohDzy0p7Gdg6FUpa9PI5jFvT7OYlwvMR1Xj9RpM+ftgrrVu+dH0jAjVkmToZiPrFv+QWu+6C83884TRKYmNKMwHDx3gMQJtETCi3tpGXOR5OGhfkZ2Cr0t2ZZRNvMLCj9Opao0CsghVC0E4sVrr4wfKPVylkDwcFJNtedrbQvDc02f/purt5LicWttqs0p9cWt1JpzuHPDVoTfv9vkuV276e7FyGyHh3qywlkoCqjPOs5Qiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN6PR11MB1908.namprd11.prod.outlook.com (2603:10b6:404:103::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.10; Tue, 25 Jan 2022 03:22:40 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%5]) with mapi id 15.20.4888.020; Tue, 25 Jan 2022 03:22:40 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH 2/3] libavcodec/qsvenc: Add b_strategy option to hevc_qsv Thread-Index: AQHYEM7WaHF2Qk+x50usLntr1sXTEKxzE/CA Date: Tue, 25 Jan 2022 03:22:40 +0000 Message-ID: <5ad5b34a1e346beeedf091c7c3c51d7330fa17c6.camel@intel.com> References: <20220124025955.204168-1-wenbin.chen@intel.com> <20220124025955.204168-2-wenbin.chen@intel.com> In-Reply-To: <20220124025955.204168-2-wenbin.chen@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fec26095-269f-4d5d-bd60-08d9dfb1f178 x-ms-traffictypediagnostic: BN6PR11MB1908:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HvV6WWHDHKtW3+fGCfl9KctU3SkbruCwuyidlUvioziqT+CIIqGq596s8Tg0YyM0E5KmkJqaIpWTQaYq4UemTh/EtOim86M5eNRmjnlHcwuJCGdoIHpdCN095maBuRvjdMXB6x7kx0LDXByTjwzY+oQfmUFN44zJhtxL3jg/eUHA1E92j+qy53koy3xPJnUvvl5Fxwgp6B9fVNh0sdZYIolae30tBDY4SV0y2eyVRPo555PlrjYUsfCps4ucvlDbHHQ5RFrl3uEOemLvIWGJerh28jUAQQJKHThAcTmaffSr7/A474S08u9eOIksCsuyLHTWfqyVoL0V+qfDpaiGNIwfh6mxB0A5KUsaZiS9TmQH9//x+UOWHEthsybSPsb9KZ7+5BOK4ZkZl/GA9SZX16utdqWrGtYSvs6YKWqNCIPObPpr2qzHoJGHadaVq5QB1cDEkBMn+OCpKbNKPb5nAEuReYVlU6K3ZBqKqZIUgILkrAFShD+lcZs8DiT/DgDs5SFGVNJoIFM+KqYzwSUrbPmUmIhc7ksk8BHx0yVMam0WlLvZO79i+95MNHpp1Fq29FYqebKjCOu+RUb96JseGX4yrfwKnb2O4oK8mOv1jInVKPTzpFo5DfPTLshwTKX+8kCoinqev5mqw3EZ+Apvoh9XRS7/3XBi8GZErI5mI+qiZP02ghKeHgkSpoNNNuPrS9LGz4x661c8m6gg+nNYBPM+J5DV8iRx3SSgcZ+425Y= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38100700002)(71200400001)(36756003)(8936002)(86362001)(64756008)(38070700005)(26005)(66446008)(66556008)(91956017)(76116006)(66946007)(66476007)(186003)(6916009)(6506007)(2906002)(83380400001)(8676002)(6486002)(82960400001)(5660300002)(508600001)(316002)(2616005)(122000001)(6512007)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cEpJaVE0djZMUkl1VmhYUVRWbEVMOTk5dTNSRkpJMnIvR0diYS9JOW55S0tQ?= =?utf-8?B?NkhWZVJEUUp4bXAxYk01dzQrQ0ZPZk5ZTTU1T3JzVENoL0dyeVlvU1kwUjB0?= =?utf-8?B?OFNvZFVUaUFuOWYvM1d0S1JXalpENDFlOHlEbHU2TGdWTGUxdXI2QmFka3FV?= =?utf-8?B?Mm1zT21BQ3BqZnk0bXdJV0lvVm1mNWd5ZFFiWDZEUWwyb2VRVVY3WkN5cWM5?= =?utf-8?B?WkpyZmNhYlgxN29tR0lWRVk0WTI1cjFpNC8zdFVpSnVwR3JyMzY5Qksvbi9m?= =?utf-8?B?UjIxUVFrZ1FYS3hKemc2YVZ6OFFoVDNVVXlSdSt5Qk1jM2ZnOWJhMVlYMDRK?= =?utf-8?B?a1NlSzJia3ZIUGUxckFZNGpCM1NHNTBPUUpTNXJWeUZ5Y21qMlRuaGJTTGVN?= =?utf-8?B?cnBYRmFEWklSWWg3VTE4a3M2M3Bpa2JkbCtYNnI3SHg0Y3NyQUZneDJLT3Er?= =?utf-8?B?RXp6WjJidllubjNkdWlXRUZ0T3ZhMnh1cERoWUJhQ3NwWm9FT1VUYWJSd0dM?= =?utf-8?B?VzYvLzhTeGVSZklUbGxJQ2pYVzBLSVBWL3FKRDBKNkcyd0Z6QVRuTXlteGZh?= =?utf-8?B?ZGkvajRMSFZJaXlRZDNjME95NmswUkFOWDZheGFtaFUwa2xtL1R2eVVCTmFU?= =?utf-8?B?bW82OEpJb28zTFJxWXE5L2Rsb2NVSFFQTk1PaFFHelZRamJmUlFGS0M2UnFl?= =?utf-8?B?bVcvTkxZZWI3QnlrSE04NzlpOHlhSk1oZC9IWGpmZzVZcE5yMDU5WXU0QmN5?= =?utf-8?B?UGZyM2M3Z1hha3U4cnFDMEsrMloyZGFDUWVTejV2OGU2TXUraldCSmpRa0FU?= =?utf-8?B?a1hiRTZZam9hb3BkeHhuL2QxWjZkTThHTlZuTW5hcjZFcmVpVHJRWFR6MjEv?= =?utf-8?B?QlFUT05zTkJPaVJPbzNRTlZ6SEdyZWRKSERsb0tvc1hXa3Y1anE1UE1JNzVx?= =?utf-8?B?L1hCVjlZT1J3Y0tDU3VEcEU1dlpiQUdCU0xVMkRHWml5UEJVS2o3V0xMSjdv?= =?utf-8?B?cXFKcXhHcXVoZUEyQmgydGoxREZoRjZMbkdpVDJLd1NtRE1qTVMxaThiWEU5?= =?utf-8?B?MHBRQi9LU3dITzN4T0Jhd1BEVUlNZk5hWnNkaCszaHYrUWNxUGlQWlowK05F?= =?utf-8?B?OGUxWXNuait0cHpCWmVRcnpMSTNYK0FYcFN0bkpxQTdhUDNNNUpmZXhpQ0hK?= =?utf-8?B?dGE3Qy9xQlgvaE9OSy9Pd3dnVDQrUE9ROER0TmtZYmU3Uk1yVFBZeHVNMzN3?= =?utf-8?B?ME9qSy95OEFGSngyY09XeW82SHpsd0s3NHVkUlh1eEJ2VnVsdVhaTnMySG0x?= =?utf-8?B?VVNwS2UzeDJuSFZZREZOSWF0YnphN2c4TngxMDc4QW1aZzhFbVJwMEFGempO?= =?utf-8?B?TzFVZWpITlpLVlFZZkdidGViN2phY3U4N0x2OElaV0podHZlOHVKWW5TSVBx?= =?utf-8?B?ODQ3SEhnNFB3Z1BzS3RtNlVjV3VUaVQ0ZUhXT2VjYVM5U0UwU2JXUUtpRHA3?= =?utf-8?B?RitJUmNidlUyWlEvZUo1UkJXaGlRQVVzNktkaW9FOEVVR0FONUNwcm1hcGtI?= =?utf-8?B?Tkp5Mk5IYkNsTlgzM0hlcWh1NzZ5ZDU0QnROaUVGTWdIRWpMMXV4M3lFbE5n?= =?utf-8?B?S3ZBL1c3c2NTSS9NRzJGeU1RMlBMdVJNZ0pCNjNnclZ2NHBMM1ZxK0FBWSsz?= =?utf-8?B?K1huTnY0NWxtaVBBUDZiU3ZDeERJa3JTMFFDMXgzVVBUTmdYQ0t6Sjhmbmp3?= =?utf-8?B?WjQ3T09jZXFlallVVmQwTURTYW83bEhQdHBiNmJ1V1gwL2JhYmZZcFRTa0do?= =?utf-8?B?YzV4THlGTEgvUHplbUlWb1BEMVJreHdzbXdBV0hONlkwUis0RFVydGhhMTc4?= =?utf-8?B?eWpBd0hCaVRpREMyZE9GZXRVemlCY2ZYancxVTJWdXFTYmlxWmxlZy94RU8y?= =?utf-8?B?UHNhMVg4U0JwY0FRcmNsd3d6MTdyai9KYjdvS1ZwbFpmY1pCWmxIb3ZEVkhJ?= =?utf-8?B?b2xqRmZ1aS9CLzNaTGJvbUlQa1prK0t5cDM5Y1drSzJhTE9RcHJYMlkwcm9G?= =?utf-8?B?Qm5aTndqcEgwNzZVSWJkKzdUd2llbCtzbDFWVVppUEp1dnkwWVp3R2l3bWds?= =?utf-8?B?a3BFS09IMGNVa3RPV0M2VHBlVEc0amkrSEF2WE44T1pFdEdUMi90SGd6V0ll?= =?utf-8?Q?IY3cnHyYU2023Cql9PXJWOk=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fec26095-269f-4d5d-bd60-08d9dfb1f178 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2022 03:22:40.2125 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: avzxUQD+WiqsxQmjw94eheoML7IAjCkGqxbe2Hmx+wMOijPfccNfbRhmZxaI4lHFVxsWUGOJpjIdnGmMT7A+kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1908 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 2/3] libavcodec/qsvenc: Add b_strategy option to hevc_qsv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-01-24 at 10:59 +0800, Wenbin Chen wrote: > Add b_strategy option to hevc_qsv. By enabling this option, encoder can > use b frames as reference. > > Signed-off-by: Wenbin Chen > --- > doc/encoders.texi | 3 +++ > libavcodec/qsvenc.c | 6 ++++-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 8966610263..6c1c4df57a 100644 > --- a/doc/encoders.texi > +++ b/doc/encoders.texi > @@ -3403,6 +3403,9 @@ Maximum encoded slice size in bytes. > @item @var{p_strategy} > Enable P-pyramid: 0-default 1-simple 2-pyramid(bf need to be set to 0). > > +@item @var{b_strategy} > +This option controls usage of B frames as reference. > + > @item @var{dblk_idc} > This option disable deblocking. It has value in range 0~2. > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index f311cd9ce4..a8d876d6d9 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -888,8 +888,6 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > q->extco2.LookAheadDS = q->look_ahead_downsampling; > q->extco2.RepeatPPS = q->repeat_pps ? MFX_CODINGOPTION_ON : > MFX_CODINGOPTION_OFF; > > - if (q->b_strategy >= 0) > - q->extco2.BRefType = q->b_strategy ? MFX_B_REF_PYRAMID : > MFX_B_REF_OFF; > if (q->adaptive_i >= 0) > q->extco2.AdaptiveI = q->adaptive_i ? MFX_CODINGOPTION_ON : > MFX_CODINGOPTION_OFF; > if (q->adaptive_b >= 0) > @@ -910,6 +908,10 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > q->extco2.DisableDeblockingIdc = q->dblk_idc; > #endif > > +#if QSV_VERSION_ATLEAST(1, 8) > + if (q->b_strategy >= 0) > + q->extco2.BRefType = q->b_strategy ? MFX_B_REF_PYRAMID : > MFX_B_REF_OFF; > +#endif > #if QSV_VERSION_ATLEAST(1, 9) > if (avctx->qmin >= 0 && avctx->qmax >= 0 && avctx->qmin > avctx- > >qmax) { > av_log(avctx, AV_LOG_ERROR, "qmin and or qmax are set but > invalid, please make sure min <= max\n"); LGTM, thx -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".