Re: [FFmpeg-devel] [PATCH 02/11] avfilter/af_channelsplit: fix mixed declaration and code

From: Leo Izen <leo.izen@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 02/11] avfilter/af_channelsplit: fix mixed declaration and code
Date: Sun, 14 Jul 2024 13:39:54 -0400
Message-ID: <5a7e78bd-6682-40b9-9360-ebf93548172b@gmail.com> (raw)
In-Reply-To: <D2NQZKJWI96W.1VKVR2820P8JN@gmail.com>

On 7/12/24 11:47 AM, Marvin Scholz wrote:
> Fix a "mixing declarations and code is incompatible with standards
> before C99" warning.
> ---
>   libavfilter/af_channelsplit.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavfilter/af_channelsplit.c b/libavfilter/af_channelsplit.c
> index 43b2667750..b91195a4c6 100644
> --- a/libavfilter/af_channelsplit.c
> +++ b/libavfilter/af_channelsplit.c
> @@ -151,6 +151,7 @@ static int query_formats(AVFilterContext *ctx)
>   
>   static int filter_frame(AVFilterLink *outlink, AVFrame *buf)
>   {
> +    AVFrame *buf_out;
>       AVFilterContext *ctx = outlink->src;
>       ChannelSplitContext *s = ctx->priv;
>       const int i = FF_OUTLINK_IDX(outlink);
> @@ -159,7 +160,7 @@ static int filter_frame(AVFilterLink *outlink, AVFrame *buf)
>   
>       av_assert1(channel >= 0);
>   
> -    AVFrame *buf_out = av_frame_clone(buf);
> +    buf_out = av_frame_clone(buf);
>       if (!buf_out)
>           return AVERROR(ENOMEM);
>   

This LGTM, I submitted a similar patch.

- Leo Izen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".