From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 96E7044160 for ; Mon, 29 Aug 2022 15:00:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C4EEB68BAC6; Mon, 29 Aug 2022 18:00:48 +0300 (EEST) Received: from smtp.outgoing.loopia.se (smtp.outgoing.loopia.se [93.188.3.37]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F41C168B737 for ; Mon, 29 Aug 2022 18:00:41 +0300 (EEST) Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 291492F40A22 for ; Mon, 29 Aug 2022 17:00:41 +0200 (CEST) Received: from s980.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 198782E28685 for ; Mon, 29 Aug 2022 17:00:41 +0200 (CEST) Received: from s473.loopia.se (unknown [172.22.191.5]) by s980.loopia.se (Postfix) with ESMTP id 16EB02201869 for ; Mon, 29 Aug 2022 17:00:41 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.009 X-Spam-Level: X-Spam-Status: No, score=-1.009 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, HTML_MESSAGE=0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=disabled Received: from s899.loopia.se ([172.22.191.6]) by s473.loopia.se (s473.loopia.se [172.22.190.13]) (amavisd-new, port 10024) with LMTP id VRVyYE6tUkIi for ; Mon, 29 Aug 2022 17:00:40 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: peter@zebuhr.se X-Loopia-Originating-IP: 46.59.58.112 Received: from smtpclient.apple (h-46-59-58-112.A213.priv.bahnhof.se [46.59.58.112]) (Authenticated sender: peter@zebuhr.se) by s899.loopia.se (Postfix) with ESMTPSA id 85F8A2C8BC7A for ; Mon, 29 Aug 2022 17:00:40 +0200 (CEST) From: =?utf-8?Q?Peter_Zeb=C3=BChr?= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Date: Mon, 29 Aug 2022 17:00:40 +0200 References: <30245E67-C26D-4DD0-879E-CEF516AD52BF@zebuhr.se> To: FFmpeg development discussions and patches In-Reply-To: Message-Id: <5BC2BCAC-9EE4-4313-A7EB-60F28C868CA7@zebuhr.se> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] Matroska and output_ts_offset X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On 29 Aug 2022, at 16:37, Andreas Rheinhardt wrote: > > The Matroska muxer is buggy wrt. to the ts_offset relating to codec > delay. You can see it in lines 1839-1841 which are commented out. > Commenting them out happened in commit > 82e4f39883932c1b1e5c7792a1be12dec6ab603d, merging the libav commit that > implemented it (namely > https://github.com/FFmpeg/FFmpeg/commit/a1aa37dd0b96710d4a17718198a3f56aea2040c1 ). > It mentions "assertion failures and av sync errors". I can only think of > one way that it could have led to assertion failures, but this should > have been fixed in 4ebeab15b037a21f195696cef1f7522daf42f3ee (and since > then I wondered whether it can't be enabled). > > - Andreas Interesting, It does look like re-enabling that commented out section would indeed shift my teimstamps forward by the encoder dalay and work with my ts_offset setting. I do wonder though, would that not also mean that for the cases where the stream should start at 0 it would result in streams starting 7ms in due to the handle_avoid_negative_ts already having shifted the first packets PTS from -7 to 0? And that would end up being shifted once again for the inital_padding? / Peter _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".