From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8BB89402A1 for ; Sun, 20 Mar 2022 18:04:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0ADFA68991B; Sun, 20 Mar 2022 20:03:59 +0200 (EET) Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D19FA68A7AD for ; Sun, 20 Mar 2022 20:03:52 +0200 (EET) Received: by mail-oi1-f170.google.com with SMTP id j83so14216554oih.6 for ; Sun, 20 Mar 2022 11:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=QE5GkFswCT0D3VclMQKN2hp14xK5bjLHz9MWLjwvYa0=; b=h1E6uppW2wx7fV7SVGqVP6/BXgNdbN6s3OHYeDc6stOZnGKJzpijWEWIYNiCMwzkLF l6fSznVy1Fr1QN6i1bcnE5US4R7X//arBohROLU0cqdEu9ZpJ6e81uP2MIsOr2/3LFG4 KR/EdATMGhWnierMJu2Z/aNmQ3pnI4mqU3c8AbNCJxmST+1gA1F8kRV/+4K0+lFOYPPq c8Rh2c/bh1nem89vy8XleDGBsmnpp3t5qgzKD8dDbikSt235jbeNTKAIKz6iwgso9AYo ARpEgds/A1k4o7XRFDKIE6GHY/7A2TnD6xP5iNVqEu0q5VETWosxse6qmXqJ//44oGrS DtLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=QE5GkFswCT0D3VclMQKN2hp14xK5bjLHz9MWLjwvYa0=; b=PgfLcuxw7Ykp+/1kInDrrabbnTYVkaQbbHwAHMSCKUSFT/zNPTPBgRytbpiJiYifca FaKkaS/OOigp1UK3NIOmyT3j1jCeDWTBU+n/yMRbqL7l2pcoUAatmKF3WsWHRL50ABLW kIW/7nz01VHv61W1BhWkdK50M/q956upChGdt1gc0OACSankH3nqaGhAnfUgwXubdBkc 9U3Eui0Ce08DjgP5HpfU4anDMWSMjfN9pxxjvuVv8b/UPFfjFYJ1YBNU0vxCxJLTFY0R +we5nqk6pCoTJ8NjcWAflBJIa5gwdokHzo/UpY3xW1TmQDpRrWJoL5FnmvTQZyTRhVsy GWlQ== X-Gm-Message-State: AOAM530E8DfoDNsUEuZC3TzTq+SIa5MoQQqBr6bCQCwoBIR9NIBd2h65 hDpidZQLMoSAqcT8pHeAA800+l0YAlwt+Q== X-Google-Smtp-Source: ABdhPJz8Qe2KdX1mR+GYUz6Pz0qA2bUKSYVtjw1f0ogLfX/yunDSQrbQM+zJe3Y4Fw4yFR1YdpL70g== X-Received: by 2002:a05:6808:208c:b0:2da:10e3:c70 with SMTP id s12-20020a056808208c00b002da10e30c70mr8093614oiw.42.1647799430821; Sun, 20 Mar 2022 11:03:50 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id ed22-20020a056870b79600b000da32eab691sm5435466oab.23.2022.03.20.11.03.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Mar 2022 11:03:50 -0700 (PDT) Message-ID: <59d8bb90-f1cc-4dd4-ca31-30eed7d872d1@gmail.com> Date: Sun, 20 Mar 2022 15:03:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220318221907.44594-1-jamrial@gmail.com> <20220318224748.44929-1-jamrial@gmail.com> <20220319182916.GC2829255@pb2> From: James Almer In-Reply-To: <20220319182916.GC2829255@pb2> Subject: Re: [FFmpeg-devel] [PATCH 4/4] ffmpeg: replace custom channel_layout code with an SpecifierOpt based one X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/19/2022 3:29 PM, Michael Niedermayer wrote: > On Fri, Mar 18, 2022 at 07:47:48PM -0300, James Almer wrote: >> This is cleaner and allows fine tuning which stream the option is applied to. >> >> Signed-off-by: James Almer >> --- >> fftools/ffmpeg.h | 2 ++ >> fftools/ffmpeg_opt.c | 84 ++++++++++++++++++-------------------------- >> 2 files changed, 36 insertions(+), 50 deletions(-) > > Not sure its intended or not but > This changes the output of > No, it's probably not intended. > ./ffmpeg -channel_layout 3.0 -ac 3 -f u8 -i /dev/zero -t 1 /tmp/file-old.wav I assume (since i can't test) that a 2.1 layout is being set instead, if any. Guess i need to change how and with what priority "channels" and "ch_layout" in pcm demuxer are parsed. > > thx > > [...] > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".