[FFmpeg-devel] [PATCH] avcodec: reorder MP3 decoder declarations to match MP2 pattern

[FFmpeg-devel] [PATCH] avcodec: reorder MP3 decoder declarations to match MP2 pattern

[sohzm]

Fix inconsistent sample format reporting between probing and decoding.
Previously, avformat_find_stream_info reported fltp format for MP3
streams but frames were decoded as s16p.

Fixes ticket/11561
---
 libavcodec/allcodecs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
index cd4f6ecd59..329e410aee 100644
--- a/libavcodec/allcodecs.c
+++ b/libavcodec/allcodecs.c
@@ -500,8 +500,8 @@ extern const FFCodec ff_mp2_encoder;
 extern const FFCodec ff_mp2_decoder;
 extern const FFCodec ff_mp2float_decoder;
 extern const FFCodec ff_mp2fixed_encoder;
-extern const FFCodec ff_mp3float_decoder;
 extern const FFCodec ff_mp3_decoder;
+extern const FFCodec ff_mp3float_decoder;
 extern const FFCodec ff_mp3adufloat_decoder;
 extern const FFCodec ff_mp3adu_decoder;
 extern const FFCodec ff_mp3on4float_decoder;
-- 
2.49.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec: reorder MP3 decoder declarations to match MP2 pattern

[Lynne]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 1068 bytes --]

On 22/05/2025 06:21, sohzm wrote:
> Fix inconsistent sample format reporting between probing and decoding.
> Previously, avformat_find_stream_info reported fltp format for MP3
> streams but frames were decoded as s16p.
> 
> Fixes ticket/11561
> ---
>   libavcodec/allcodecs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
> index cd4f6ecd59..329e410aee 100644
> --- a/libavcodec/allcodecs.c
> +++ b/libavcodec/allcodecs.c
> @@ -500,8 +500,8 @@ extern const FFCodec ff_mp2_encoder;
>   extern const FFCodec ff_mp2_decoder;
>   extern const FFCodec ff_mp2float_decoder;
>   extern const FFCodec ff_mp2fixed_encoder;
> -extern const FFCodec ff_mp3float_decoder;
>   extern const FFCodec ff_mp3_decoder;
> +extern const FFCodec ff_mp3float_decoder;
>   extern const FFCodec ff_mp3adufloat_decoder;
>   extern const FFCodec ff_mp3adu_decoder;
>   extern const FFCodec ff_mp3on4float_decoder;

It should be the other way around, the float decoder should be picked first.

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".