From: Lynne <dev@lynne.ee>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec: reorder MP3 decoder declarations to match MP2 pattern
Date: Thu, 22 May 2025 06:25:57 +0900
Message-ID: <59bd4c1c-7c4f-4f09-848b-2615e32de771@lynne.ee> (raw)
In-Reply-To: <20250521212107.221399-1-sohambharambe9@gmail.com>
[-- Attachment #1.1.1.1: Type: text/plain, Size: 1068 bytes --]
On 22/05/2025 06:21, sohzm wrote:
> Fix inconsistent sample format reporting between probing and decoding.
> Previously, avformat_find_stream_info reported fltp format for MP3
> streams but frames were decoded as s16p.
>
> Fixes ticket/11561
> ---
> libavcodec/allcodecs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
> index cd4f6ecd59..329e410aee 100644
> --- a/libavcodec/allcodecs.c
> +++ b/libavcodec/allcodecs.c
> @@ -500,8 +500,8 @@ extern const FFCodec ff_mp2_encoder;
> extern const FFCodec ff_mp2_decoder;
> extern const FFCodec ff_mp2float_decoder;
> extern const FFCodec ff_mp2fixed_encoder;
> -extern const FFCodec ff_mp3float_decoder;
> extern const FFCodec ff_mp3_decoder;
> +extern const FFCodec ff_mp3float_decoder;
> extern const FFCodec ff_mp3adufloat_decoder;
> extern const FFCodec ff_mp3adu_decoder;
> extern const FFCodec ff_mp3on4float_decoder;
It should be the other way around, the float decoder should be picked first.
[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-05-21 21:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 21:21 sohzm
2025-05-21 21:25 ` Lynne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59bd4c1c-7c4f-4f09-848b-2615e32de771@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git