From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E1A6847838 for ; Tue, 26 Dec 2023 03:43:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BD8A468CA85; Tue, 26 Dec 2023 05:43:41 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 083DF68CA85 for ; Tue, 26 Dec 2023 05:43:33 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703562219; x=1735098219; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=4o/40GXmmtN2u1+SdNHPgIiWLoDyeM/l5QRBhxWwogA=; b=L14HVDWjBYQGtpDmNPjWBjnv6dBCO5y48EtHm4jLt45fjKZI5+UGgyKb Z6CtYXDy9ZgfBnNc7rAmvy7wxMTtX44HcG4508mH2md1l70fbDrctgPVN 95QBMzugM/wphBNMRwEhzFbmrYxxRG7a2VMx+WnjVAbz0s+jZQWtk/BRo RBYt5wfGc9m7FbytljYPiv0beQ9nKNbXs6iv/gv9B6r62ldlyJCKBlPX0 54YbgLmf1xWLBZbbJkTLbguRknyKlAlOkBlW0PBVEf93a7W6ktl4CM+sd f25Wcj3BGSm6KDiHu5koUcGZlAe9jxst4BbSXZHRWDQT8hDhnAp2X2OTG A==; X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="460646664" X-IronPort-AV: E=Sophos;i="6.04,304,1695711600"; d="scan'208";a="460646664" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2023 19:42:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="727644752" X-IronPort-AV: E=Sophos;i="6.04,304,1695711600"; d="scan'208";a="727644752" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Dec 2023 19:42:10 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 25 Dec 2023 19:42:09 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 25 Dec 2023 19:42:09 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 25 Dec 2023 19:42:09 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 25 Dec 2023 19:41:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W25JCEyeZo5fqRXceHN2WETKYcMTHTvx6e1V/8mondAnw0LCIl33mm47XqDNSzz9ZpdcvHoNTzCjuMXCfTzp1ZKZZJPIqkYevxE+s02E4ufNsYaAuWNShwcE4z07Tt9JMdZt+veSJ7Db8ZnH9NFtwymAV7ESZWRzI8lA2fGtag3n6tNaPQlPAKss+vZ1wDFAzMemymARo3AJo2G0yGXFxeXBMXkm15w8Nq6yg9M2+N5UhwMD6QFFrwdRO32ZRPm3KcfY6IOLHAMDicwYXRayAfeMPA4BSLSD8ttZeRho9YQahGCrjhKu3PjJKP0ElHAGSGJUQwbMXha/ccEU6lVRxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4o/40GXmmtN2u1+SdNHPgIiWLoDyeM/l5QRBhxWwogA=; b=l+Cbg4ssLTJfKK+qQT0s3+iikbEqmM3Yo4kdbR7fSWKuzTJzNRi4RTsO7+B6rOdKRMzHgGRvfyEA/d+o78U/KOHlfSA4q/rASea8eiHislS1Yo+CdTi5XfKLXswQQlxSG45yHgbQ6JrYwjMJO7D4PbtOnLdciSuG3FYqhUNhphW57yjyGiIpa5wga8YXG5a3CDpx96n4UMpFfqI/G4VxeVUFd/UfH1hEOqMPAIJH8ut+CHxSVGDiSlwZ4IoXacgxywsIOSzEcM6y3wQ+3lyEeIxQtnu/pl3cn8CG7UAFJuVt47Isj6tftpRPyDbN1DcQ4hE2MbzilxCshbD/XgEhZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by PH8PR11MB8257.namprd11.prod.outlook.com (2603:10b6:510:1c0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.26; Tue, 26 Dec 2023 03:41:49 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::43fa:28c3:7592:9f49]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::43fa:28c3:7592:9f49%4]) with mapi id 15.20.7113.027; Tue, 26 Dec 2023 03:41:48 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v1] avcodec/av1dec: Add tile list OBU to decompose list Thread-Index: AQHaM18UuTF0F5Vr3E+ZBi8a6HaHkLCy55oAgAE1coCAAGcLgIAAackAgAYGgwA= Date: Tue, 26 Dec 2023 03:41:48 +0000 Message-ID: <598db5043d56322c5c4f13b901ef3f4b24ff2e43.camel@intel.com> References: <20231220084356.796186-1-fei.w.wang@intel.com> <0ec4a5a324fcb829eea33916dfc4b44e7a91b79b.camel@intel.com> <51d4f55fcabe1704f17ac4154b3d108fec4dbacc.camel@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5030:EE_|PH8PR11MB8257:EE_ x-ms-office365-filtering-correlation-id: fa0f5821-de51-43cf-fc47-08dc05c4972f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9NCIdk88B4FD9wsWaZf6Wo3uGgPOuGbSXtLhn7uz/pgPIhraHK8UPA9K+ISoYi7afAXtesDqCO5dm1DMe6WPBTwx8YJp4G+tNR7Jyi2KQSbyZf8EJkauUBbe5KP3q/h3UJNeh5V0nMnwXET++te1GuN2wxfoj08mk8PUFxcxas6E4+O8rnUqQlqqUcTqZGAkMlIH8ozSnbYrQJsltn8xk8QNfW9tk8GbTQdIaNRjow3aiwiy07QCW/EmgWffzr8jVTTXP4eMyZofeII+JKo8CCtS2Mf8RJZcmOGgIDg0fGYiuvpUEWpyEiev4iyC1D3re5n8dGdF4dZ94XrC23rbvrsJ43XuscOAbvefqOPUzXFQtT/OfyeZntZE6UtUTLImkQTTYAENG09UA/OYDX/GYSHTONgp0s7Jey4PZsH/V8cFsdAzEds6wkQ9ByLfhnNpI6bLscQENTk8xmcKTHON6lYNsqH53f4CM0db0xODupGPp9ki+o0QUhlZBlX9FHTE7VZYvrTeBdginTVdfazzzUSzlo4TY6nhIFlWgzrNVTXTceL/kogohVOgOr/kdnoxwGZDQMiMKt7+XqQXNIQlwTV/F4n9ydJXACngUGXqPRE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(346002)(39860400002)(136003)(376002)(366004)(230922051799003)(64100799003)(1800799012)(451199024)(186009)(316002)(66899024)(8936002)(8676002)(71200400001)(478600001)(6486002)(36756003)(86362001)(2616005)(26005)(6506007)(6512007)(966005)(38100700002)(122000001)(82960400001)(38070700009)(83380400001)(41300700001)(91956017)(64756008)(6916009)(66476007)(66556008)(76116006)(5660300002)(4001150100001)(2906002)(66446008)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UDVnSHJXSmNqVTZOTU1YNFJDLzQ2bFhBWWkwbXlWdEJQQkRIVjFTZjk2eWtK?= =?utf-8?B?dWRqUWVKR2I2UUQ4bnF3dmliNmlEUG9mT2wrMktvMXdJaUJkSkxVRWVBdkNj?= =?utf-8?B?cjhhM2U5Z2dVa1JFd2I5YTNvOVliaGFSc3BidmpIREM0VGc1K3JheDd0Q1dU?= =?utf-8?B?WmlyUFRxcm56blVZNHBHUUlodUdlMjMxT0h2Z21URDlpNkFQWUVDNjhoUUxu?= =?utf-8?B?Q1BYNU1XcytoVHFKS0VDY0FUYXdtV0hYL0tXQVJLNitlR1pGWG4vbHlPcHF4?= =?utf-8?B?angrT0s1WUdNcnhOdU10Q21TdXhCamZENDVZbzRiMzJKSWc5ZTRTL3hNbHd6?= =?utf-8?B?OExEMU1BMFdpQ0xTb2w0NmFTMnhjL0orUnZoM1JmMVB5aHBOVFI0b0Z2YUFY?= =?utf-8?B?eHUzMS9rOG93VGp0dngzL2o4RUtqRFkzNEZxRnQyUzJ0NlA5SnNpZmcwK0lX?= =?utf-8?B?SEFxN2hMbXpDbDNNZFd1WFhtTWx4dU43Z3BhRi9ZMW9EK0QwdThHRVFmeHFU?= =?utf-8?B?YmlUY1lhb1dqNmdxRURUd2UvY2U0aE92S0VPdTBaNEpROXl2ZFpwNjhLS2s0?= =?utf-8?B?bHZ4VHk4RGZ0VHRIUDd5QllVME9lVTh6Mm1MK2tjeWVGREE5am5leTNIYUo4?= =?utf-8?B?TU44MStkWUFQK3JpdHJVTTZzY1Y0Mnl6NkZ3RGZOUWN3c0lJK1BkQVRPOTlY?= =?utf-8?B?QVFLdW1DWHFJOGt1SFdtL3VVN0cwbXVOS2t4c0Q5YVV3dUNXblBvcGxtNVd1?= =?utf-8?B?NFloeXNwY0J2U0llczc0VThYQlpQS2FhWEU0dlpQbXhScXllRy9BWEd0ckxz?= =?utf-8?B?cVVBUGRIcG5vNFJ6M01hZVlhRFB3dnpHZ0pGS0RiOGFrMjBGNlBFWVJheHVa?= =?utf-8?B?S1ZXSUJTUFVrOUV1Ly9jTWtZaXpmVmUrMHJLbFZ5ZDNyeVc0Z09uUFZWYWV0?= =?utf-8?B?OXNXRG9RVUU3U05WaENmS0EvSUpuZXhNVDlrSXpwSjR4b0NFY0VCL2lSZlFN?= =?utf-8?B?TWFzc0M4TFNrdTRpbXFueWJILzY3UnJSV0doeXcrMDBFRmZJR3pSUDFQbmpS?= =?utf-8?B?M0IzZW9MZG5Yay9JQ3lYU0FWRFRYYTE3TUtzdUhMN2Fld2hmOXJUcE9jUUlM?= =?utf-8?B?aUtrRWFLenFNTmxBWDNVdml3TjlWT3h1R1hFWXdkeVlndllvb0NZUzE5UGkv?= =?utf-8?B?N3Bac3hxOFNvNWlJVGw1WHowVUh0Z2djZXRvdzZiYktBTm1MSEZPSkdXeGh3?= =?utf-8?B?T0dNRWJqNTBlb3EzcFFrSG5CeUl1WlI5b1JTUWkxOG9uaFFUTW9uelFPR011?= =?utf-8?B?bTFOZHBwWFJqWEg5QlFZYWVXZkc5S3FDYU90dFREelJya3c0VDBuNGF5N1dw?= =?utf-8?B?eGdkcVdybTJIV2xmUStSOW5xc0huRmxMRGZtVit6MlR2MU53dUxNVmlUV0tF?= =?utf-8?B?OVp3ZldDeFdLeDJtQVlQSWVmdEs1ZGpnN0xIN3phNzNKVkt6VGpEaGhNYjVj?= =?utf-8?B?WFBlanpJdGs3ZUIwUnNnNVBSOVZlUGUvWldzTndFNTZDdzUwUlNjSlN1dVdm?= =?utf-8?B?Lys2Q0JnY3czOWVSbUswL1c5ZkpqK0xVcjBqUzgzZWp4TXBPdExDWmFBSkVn?= =?utf-8?B?b01zd1MzL2VERkxKYXJtWlI0MlFrT3BxZzR5NS9QTTRaOEZQaDR2UXI0SUkr?= =?utf-8?B?bHBBUUdqWGNDaHVTeTBrejJjRG12VE5MWnZrWmN5RFRFUTFNNkhXWm9BSmpk?= =?utf-8?B?MDJhZ0c2Y3FUalI4d2lteFIwVWJ3ZTg1VzRVY0FueWo1STRoeDlhYjYwWVZx?= =?utf-8?B?NzhDQWxaR1FsWUQ1QTA3dlcrakNUTlZYZ0tCV2JOSUdRMUhlZzdNU0g1TkEw?= =?utf-8?B?bUZpWm5DZkdyQ0UrNmt1akI5MlZ5L0VCMjFlT3U4b0JUTVhYWTdmZHU3dDYr?= =?utf-8?B?NFNkUUUrZlUrbktUT1FPM3lzWW92SVZscGJsb1BEU1A1ZGhNakhiT2J4aURt?= =?utf-8?B?aXlzSWtmcXM5N1NuU0hjSXB1NzV2YmVPK2ZGR01iUmdEQVc2K1RvMlNlNDNw?= =?utf-8?B?YzhKdVo1czFpYU94aHB2c0ZEbkJUUkxIKzV5ZEZQdGV4VkFIeURYMHMxKzBx?= =?utf-8?B?b0xTeGI1Q1d6OUxHUXd5N09RdDB1RFdKd0o4L1FXRG9BU3BlYk9MNW5qZnBP?= =?utf-8?B?aGc9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa0f5821-de51-43cf-fc47-08dc05c4972f X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2023 03:41:48.7976 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Yg+ElBs0i+B21hcO6NgI7RcightmZ09UMCqalJ2S+HbTa0UIlSkFlFgWeExKWDbk2EZRlkZ5I/TsXHxt9Bg2EQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8257 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/av1dec: Add tile list OBU to decompose list X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2023-12-22 at 08:41 +0100, Andreas Rheinhardt wrote: > Wang, Fei W: > > On Thu, 2023-12-21 at 20:14 +0100, Andreas Rheinhardt wrote: > > > Wang, Fei W: > > > > On Wed, 2023-12-20 at 17:11 +0100, Andreas Rheinhardt wrote: > > > > > fei.w.wang-at-intel.com@ffmpeg.org: > > > > > > From: Fei Wang > > > > > > > > > > > > Show the unsupported message and return unsupported for > > > > > > clips > > > > > > contain > > > > > > tile list OBU since it hasn't been implemented. Otherwise, > > > > > > decoding > > > > > > maybe successful but result is incorrect. > > > > > > > > > > > > Signed-off-by: Fei Wang > > > > > > --- > > > > > > libavcodec/av1dec.c | 5 +++++ > > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > > > > > > index 4dcde234c6..629e37c3f8 100644 > > > > > > --- a/libavcodec/av1dec.c > > > > > > +++ b/libavcodec/av1dec.c > > > > > > @@ -805,6 +805,7 @@ static const CodedBitstreamUnitType > > > > > > decompose_unit_types[] = { > > > > > > AV1_OBU_SEQUENCE_HEADER, > > > > > > AV1_OBU_TEMPORAL_DELIMITER, > > > > > > AV1_OBU_TILE_GROUP, > > > > > > + AV1_OBU_TILE_LIST, > > > > > > > > > > What do you need this for? Decomposing it would only change > > > > > whether > > > > > CodedBitstreamUnit.content is available, but you are only > > > > > reading > > > > > CodedBitstreamUnit.type. > > > > > > > > To show the unsupported error and let user know that there are > > > > tile > > > > list OBUs in bitstream that decoder can't handle them. > > > > Otherwise, > > > > like > > > > my commit mentioned, tile list obu bitsteam may be decoded > > > > 'successful' > > > > according to log. > > > > > > > > > > As I said: You do not need CodedBitstreamUnit.content for the > > > error > > > message. > > > > No, obu will be filtered if it is not listed in decompose, decoder > > can't receive its type neither. > > > > Did you test this? If so, this would be a violation of the > documentation > of decompose_unit_types: "Types not in this list will be available in > bitstream form only." My reading of the code of > cbs_read_fragment_content() in cbs.c is that it does what it is > supposed > to do. I was misled by the incomplete log. Decoder can receive tile list OBU bitstream. Fixed it together with another version. Sorry for the noise. https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=10358 Thanks Fei > > If you were right, it would also mean that the current case for > AV1_OBU_TILE_LIST and AV1_OBU_PADDING is redundant (and that the > default > case will be used instead). > > - Andreas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".