From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 4B1F34B89D
for <ffmpegdev@gitmailbox.com>; Fri, 25 Apr 2025 23:32:04 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2777668B144;
Sat, 26 Apr 2025 02:31:40 +0300 (EEST)
Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com
[209.85.210.174])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 83F9D68B07F
for <ffmpeg-devel@ffmpeg.org>; Sat, 26 Apr 2025 02:31:33 +0300 (EEST)
Received: by mail-pf1-f174.google.com with SMTP id
d2e1a72fcca58-736aa9d0f2aso3589598b3a.0
for <ffmpeg-devel@ffmpeg.org>; Fri, 25 Apr 2025 16:31:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1745623892; x=1746228692; darn=ffmpeg.org;
h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date
:references:in-reply-to:message-id:from:from:to:cc:subject:date
:message-id:reply-to;
bh=HPuQYMsPC6f+aMHqSx06dHeyx7FOdBq9huaqZtORRvM=;
b=gcGVmDMCr+b6MnH0IFmtWKpZR9NuzC6ZcLfCiLdMSM51/kbIk25Foe/FeCQLikknaB
PcqOmW5ETHeeCq4+n80xf1ZCjT5S9o0gFww5xh4jUEHrauO/STN4Cenhz9d75xOhRo9a
OQoIk6p5mOGq70wlq9KUPvjBJla7jJfUorxn2ga1LHNtuSHevls6nyROduGshBPtAHXa
GdEfxUUm6RAHses1P6EIApyeJQECrMVLAVdgkuxuIN+J0TSf4s4w61W3mUbcFW8ymT7s
v6a7Wj2K0+ZoStzfZDuVLMqnEvtJYTnpHn37MvI/Nx1T7BW1O7kP4YO2UebfxlJpc9kq
MnNw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1745623892; x=1746228692;
h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date
:references:in-reply-to:message-id:from:x-gm-message-state:from:to
:cc:subject:date:message-id:reply-to;
bh=HPuQYMsPC6f+aMHqSx06dHeyx7FOdBq9huaqZtORRvM=;
b=gkEdCzNHbXmsPHiglEsFm3g4wrahvTzZA2bwYEXgaNAYRlYR3MWih5Y0/Qhs3zj9tC
JNX9kraz47dYo7Ck8dgY0tNFnrxbEeK/1QSV8alf8oYdNhYP1X2lG6rCkL3qVS+9XQ8e
5CGSVHX45ogNAPHLyma3zjGCfbQ2BaaH1efeHxOCAzjpkR0APovJr0X9pu3SAwUQ3wAp
nvfjwefCAlRabPmJQHzkOf6oKiEkEqCkk+UtlaIbDZBu/LmHXZxtrR7fyqIrSM6wLppc
Sl3ap9jeS4+LXsDgGD5OlZfePIbJ7Km4OqPHEtMe5thg2K+/I1ha3aahMsYFgPr0H7On
RufQ==
X-Gm-Message-State: AOJu0Yxc99AlA9W9LNDJOLQBFFIMfu/BBl/Eee6VOY/aBhh30DnbVOBx
vSRdUQYSVRWeZjeoNf5gbmTjx06UszquBRgB0LDltle100YKsMsKK+chwA==
X-Gm-Gg: ASbGncuY8fitSsGtPngS8ep1+i95pSzCM2bO2BPQSQ2c7l56hopARht5U0gHzrM+hU5
E++1qH/K2MdbTbUYK6mpn/+pfC1rIKZRpC2uWR2C0DvxOulDZ+gKYat9MXKhAgYbVx4WLQ/oyyL
CGIm8pZTFqLTSm32T5NjYF1lD4IQ+7i03gc7LanuIm+UuhF0m+OTIA+hnfbtvQBMJgqkIE0ntnK
DyhJtaI0g26pVD1doi9N4qElFx9mq+yk8NYj1JwqAS4cLqHSTuDV8jpru0Ur4ZC3i1LMdDn6Ze5
/mZkIa3sE8ep7KbK37haB5ToTXaTxqs6v16/EfvInlPkLQNiiVrQ/soUSno=
X-Google-Smtp-Source: AGHT+IFv3pwVhkz5RJSveFCknx8YSqD7tNIcBnxxgYhkt1ol19eWatUhH0Pk2jF0WWcDNzansMgXKw==
X-Received: by 2002:a05:6a00:1901:b0:736:4644:86ee with SMTP id
d2e1a72fcca58-73fd74c8252mr5597904b3a.14.1745623891829;
Fri, 25 Apr 2025 16:31:31 -0700 (PDT)
Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-73e25a9a0a6sm3881605b3a.138.2025.04.25.16.31.31
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Fri, 25 Apr 2025 16:31:31 -0700 (PDT)
From: softworkz <ffmpegagent@gmail.com>
X-Google-Original-From: softworkz <softworkz@hotmail.com>
Message-Id: <5972ecf2135429e957d04c08d201a8e4717a6f97.1745623868.git.ffmpegagent@gmail.com>
In-Reply-To: <pull.66.v7.ffstaging.FFmpeg.1745623868.ffmpegagent@gmail.com>
References: <pull.66.v6.ffstaging.FFmpeg.1745457192.ffmpegagent@gmail.com>
<pull.66.v7.ffstaging.FFmpeg.1745623868.ffmpegagent@gmail.com>
Date: Fri, 25 Apr 2025 23:30:58 +0000
Fcc: Sent
MIME-Version: 1.0
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH v7 03/13] fftools/avtextformat: Re-use BPrint
in loop
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: softworkz <softworkz@hotmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/5972ecf2135429e957d04c08d201a8e4717a6f97.1745623868.git.ffmpegagent@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
From: softworkz <softworkz@hotmail.com>
Instead of initializing a new BPrint in each iteration of
the loop, re-use the same BPrint struct and just clear it
for each iteration.
Signed-off-by: softworkz <softworkz@hotmail.com>
---
fftools/textformat/avtextformat.c | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c
index 1939a1f739..5ba427d6f2 100644
--- a/fftools/textformat/avtextformat.c
+++ b/fftools/textformat/avtextformat.c
@@ -308,24 +308,28 @@ void avtext_print_integer(AVTextFormatContext *tctx, const char *key, int64_t va
static inline int validate_string(AVTextFormatContext *tctx, char **dstp, const char *src)
{
- const uint8_t *p, *endp;
+ const uint8_t *p, *endp, *srcp = (const uint8_t *)src;
AVBPrint dstbuf;
+ AVBPrint bp_invalid_seq;
int invalid_chars_nb = 0, ret = 0;
+ *dstp = NULL;
av_bprint_init(&dstbuf, 0, AV_BPRINT_SIZE_UNLIMITED);
+ av_bprint_init(&bp_invalid_seq, 0, AV_BPRINT_SIZE_UNLIMITED);
- endp = src + strlen(src);
- for (p = src; *p;) {
- uint32_t code;
+ endp = srcp + strlen(src);
+ for (p = srcp; *p;) {
+ int32_t code;
int invalid = 0;
const uint8_t *p0 = p;
if (av_utf8_decode(&code, &p, endp, tctx->string_validation_utf8_flags) < 0) {
- AVBPrint bp;
- av_bprint_init(&bp, 0, AV_BPRINT_SIZE_AUTOMATIC);
- bprint_bytes(&bp, p0, p-p0);
- av_log(tctx, AV_LOG_DEBUG,
- "Invalid UTF-8 sequence %s found in string '%s'\n", bp.str, src);
+
+ av_bprint_clear(&bp_invalid_seq);
+
+ bprint_bytes(&bp_invalid_seq, p0, p - p0);
+
+ av_log(tctx, AV_LOG_DEBUG, "Invalid UTF-8 sequence %s found in string '%s'\n", bp_invalid_seq.str, src);
invalid = 1;
}
@@ -355,6 +359,7 @@ static inline int validate_string(AVTextFormatContext *tctx, char **dstp, const
end:
av_bprint_finalize(&dstbuf, dstp);
+ av_bprint_finalize(&bp_invalid_seq, NULL);
return ret;
}
--
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".