From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 07AA548838
for <ffmpegdev@gitmailbox.com>; Thu, 24 Apr 2025 01:14:13 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6F94668B7FD;
Thu, 24 Apr 2025 04:13:47 +0300 (EEST)
Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com
[209.85.216.45])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 73C4268B412
for <ffmpeg-devel@ffmpeg.org>; Thu, 24 Apr 2025 04:13:40 +0300 (EEST)
Received: by mail-pj1-f45.google.com with SMTP id
98e67ed59e1d1-301c4850194so357776a91.2
for <ffmpeg-devel@ffmpeg.org>; Wed, 23 Apr 2025 18:13:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1745457219; x=1746062019; darn=ffmpeg.org;
h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date
:references:in-reply-to:message-id:from:from:to:cc:subject:date
:message-id:reply-to;
bh=HPuQYMsPC6f+aMHqSx06dHeyx7FOdBq9huaqZtORRvM=;
b=fweSeR9d2ShcVoqo0RFLgxuUaMUJDlf0u08ztp+MFviMWARqv9LTFIkzhcsa5rUbaE
OSxbvP46ML58nd4Tj3bJILOY6LW2JF8WsFK903+xcr9lEdqfPXID3Pf8huIbmB3+Rf8d
mgp1ojTU21/O3/LKy2WzwTIwaF3FlnVKw9vzXApSMJuhp72VfI1Kejh+khTjbzJrNyWC
P+e1JXFYqZToPoMgCJng5nNujrQZiUESgMk1HKstACxJjIjsuXGVsqU544Xna0El9Gnz
JCT4cv6kzkAuxspb8RphWAudsOoUdJvL2j5uQKNY14swBnm1/lPLwCL1Perg1Z5V4FyK
N9dQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1745457219; x=1746062019;
h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date
:references:in-reply-to:message-id:from:x-gm-message-state:from:to
:cc:subject:date:message-id:reply-to;
bh=HPuQYMsPC6f+aMHqSx06dHeyx7FOdBq9huaqZtORRvM=;
b=c2GGNu3IiXfe2pCMYQkZK9UBRUqtKuz+jNW98DJf6I/bHMAGc+sVQM9YXj/O82DHZO
SFMzkamvtjAa1hKn3oNsEDvLMgifcZVq1C7w08eV+hgV2sjnDkJdVwnY/AqYRqVoW3HV
wTPCtZI9Mh7LwVwBvPgPYAriL7mMUupsOZnqAcWTxCHD3k5jN5JoE5nsSc1BMKhWZjOw
ri7iUAhxJu1EY35N/raj4cABV6m/Z6bQlT2SiyWcZUKoNpEaHURjQtTSKD5FFabBrg/2
BI5SGchEN9e4nDbY90D3hyzlWIR8hUIccGc6XR0MTnLo/3ftjIZJX2PogXkOxld6DSex
VC4w==
X-Gm-Message-State: AOJu0Yy3HUp0cm2L2vlXyfhN+bhBKleTlY6Ve8Ld9qAQPFbi/mlJ5hwZ
vzvGwr9HwqlbyCUutnNycM00fDRMRb4QgyqfZqe/r8FfGxjBdWe0TZcbtw==
X-Gm-Gg: ASbGnctFMZTnTAiufhAAsXpRAfJoOBxuZ2iSqVLnv20cYzIURSNpfaaS7cQSADXHzvN
wwkafBz5iUVmCp1VIW5PSXjtpl0pPHAUEur7uln6m9P0CekPOQg+ae7brvAxbWx6iucr7e7gvGI
ujX8LCeug5uGCjywMSxVZxqSyH5g112ibTi0msJxQXMK0NYK3/KiCzY+RLJcekD8HxUz8MMWeV3
HqjS8HEapc4KCMU2lNB/U2YLx7lM8bJkYrr/8N3/rdGa8daEvoGTH0HYTHfd0LJHfLiP/1DzRu6
scPTQKJzqOA74hmGptpdtrdipTIYMOGByqp+9GPFVXvL7H31dNqP4C0XsCo=
X-Google-Smtp-Source: AGHT+IGFOkvKHv6revgpiDx/LOuLz0Va+H4XKULxex1EJ+aJTbECA62giL5z6GgqHsz1/jlhx6kOgg==
X-Received: by 2002:a17:90a:c2d0:b0:301:a0e9:66f with SMTP id
98e67ed59e1d1-309ed270b49mr1390757a91.14.1745457218746;
Wed, 23 Apr 2025 18:13:38 -0700 (PDT)
Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50])
by smtp.gmail.com with ESMTPSA id
98e67ed59e1d1-309ef061a39sm21044a91.13.2025.04.23.18.13.38
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Wed, 23 Apr 2025 18:13:38 -0700 (PDT)
From: softworkz <ffmpegagent@gmail.com>
X-Google-Original-From: softworkz <softworkz@hotmail.com>
Message-Id: <5972ecf2135429e957d04c08d201a8e4717a6f97.1745457192.git.ffmpegagent@gmail.com>
In-Reply-To: <pull.66.v6.ffstaging.FFmpeg.1745457192.ffmpegagent@gmail.com>
References: <pull.66.v5.ffstaging.FFmpeg.1745358943.ffmpegagent@gmail.com>
<pull.66.v6.ffstaging.FFmpeg.1745457192.ffmpegagent@gmail.com>
Date: Thu, 24 Apr 2025 01:13:01 +0000
Fcc: Sent
MIME-Version: 1.0
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH v6 03/13] fftools/avtextformat: Re-use BPrint
in loop
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: softworkz <softworkz@hotmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/5972ecf2135429e957d04c08d201a8e4717a6f97.1745457192.git.ffmpegagent@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
From: softworkz <softworkz@hotmail.com>
Instead of initializing a new BPrint in each iteration of
the loop, re-use the same BPrint struct and just clear it
for each iteration.
Signed-off-by: softworkz <softworkz@hotmail.com>
---
fftools/textformat/avtextformat.c | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c
index 1939a1f739..5ba427d6f2 100644
--- a/fftools/textformat/avtextformat.c
+++ b/fftools/textformat/avtextformat.c
@@ -308,24 +308,28 @@ void avtext_print_integer(AVTextFormatContext *tctx, const char *key, int64_t va
static inline int validate_string(AVTextFormatContext *tctx, char **dstp, const char *src)
{
- const uint8_t *p, *endp;
+ const uint8_t *p, *endp, *srcp = (const uint8_t *)src;
AVBPrint dstbuf;
+ AVBPrint bp_invalid_seq;
int invalid_chars_nb = 0, ret = 0;
+ *dstp = NULL;
av_bprint_init(&dstbuf, 0, AV_BPRINT_SIZE_UNLIMITED);
+ av_bprint_init(&bp_invalid_seq, 0, AV_BPRINT_SIZE_UNLIMITED);
- endp = src + strlen(src);
- for (p = src; *p;) {
- uint32_t code;
+ endp = srcp + strlen(src);
+ for (p = srcp; *p;) {
+ int32_t code;
int invalid = 0;
const uint8_t *p0 = p;
if (av_utf8_decode(&code, &p, endp, tctx->string_validation_utf8_flags) < 0) {
- AVBPrint bp;
- av_bprint_init(&bp, 0, AV_BPRINT_SIZE_AUTOMATIC);
- bprint_bytes(&bp, p0, p-p0);
- av_log(tctx, AV_LOG_DEBUG,
- "Invalid UTF-8 sequence %s found in string '%s'\n", bp.str, src);
+
+ av_bprint_clear(&bp_invalid_seq);
+
+ bprint_bytes(&bp_invalid_seq, p0, p - p0);
+
+ av_log(tctx, AV_LOG_DEBUG, "Invalid UTF-8 sequence %s found in string '%s'\n", bp_invalid_seq.str, src);
invalid = 1;
}
@@ -355,6 +359,7 @@ static inline int validate_string(AVTextFormatContext *tctx, char **dstp, const
end:
av_bprint_finalize(&dstbuf, dstp);
+ av_bprint_finalize(&bp_invalid_seq, NULL);
return ret;
}
--
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".