From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5043C439D4 for ; Thu, 4 Aug 2022 11:20:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E90B768B976; Thu, 4 Aug 2022 14:20:23 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6F30F68B647 for ; Thu, 4 Aug 2022 14:20:17 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 274BKGYP025158-274BKGYQ025158 for ; Thu, 4 Aug 2022 14:20:16 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id D5EFAA1468 for ; Thu, 4 Aug 2022 14:20:16 +0300 (EEST) Date: Thu, 4 Aug 2022 14:20:16 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20220727120000.3596575-1-thomas@gllm.fr> Message-ID: <594cbc99-5291-42ff-d0d-17235b38dc1@martin.st> References: <20220727120000.3596575-1-thomas@gllm.fr> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 2/2] libavcodec: Set hidden visibility on global symbols accessed from x86_64 assembly X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 27 Jul 2022, Thomas Guillem wrote: > DECLARE_ALIGNED, DECLARE_ASM_ALIGNED, and DECLARE_ASM_CONST will include > attribute_visibility_hidden. Hmm, I'm not entirely sure that we should do that - if we should add such extra meaning to those macros. How many symbols would it need to be applied on, if we don't apply it via these macros? I was a bit concerned that DECLARE_ALIGNED could be used for e.g. stack local variables (where visibility doesn't make sense) - but we do have LOCAL_ALIGNED_* macros for that instead, so maybe it could work this way after all? Do note, that these are currently defined in libavutil/mem.h, but after the next major bump they'll be in libavutil/mem_internal.h. Currently their contents are duplicated in the both, so any changes would need to apply to both. I see that libavutil/mem.h (which is a public installed header) doesn't explicitly include libavutil/internal.h, so if someone uses those macros without including libavutil/internal.h, attribute_visibility_hidden would be undefined. After the next bump, when these macros are entirely internal, this issue is much clearer (and at that point, I think it could be a bit more tolerable to extend their meaning to include visibility). // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".