From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CBBEC4B8A9 for ; Thu, 18 Jul 2024 09:38:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B6DC568D9FC; Thu, 18 Jul 2024 12:38:03 +0300 (EEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E85D068D999 for ; Thu, 18 Jul 2024 12:37:57 +0300 (EEST) X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.11.12] ([95.33.108.53]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N3KPq-1sLt4h0Ul8-00vGvj for ; Thu, 18 Jul 2024 11:37:57 +0200 Message-ID: <593d1c9b-a040-40e9-93f9-d6966eeb080b@gmx.net> Date: Thu, 18 Jul 2024 11:37:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <8c6c11a6-bc55-41a0-9f98-262c60f63ec8@gmx.net> Content-Language: de-DE In-Reply-To: <8c6c11a6-bc55-41a0-9f98-262c60f63ec8@gmx.net> X-Provags-ID: V03:K1:SemtKaomcVFO8COB4nbFBeV2Kr/I6AHPfz9CL87k9sMs8YI/7gT GltS6DjL5NlBANVIccGwkqQisD+BTydW8u2w/30e3NDNYtNwLdaUFknadAQIKBi/GJjPhkB 9vMvzT1D1iq6O/VWeVe/yBSnFN39k/6pmDYotfiEOzxYr3MxBxPHp/Yh+XR5br6Jq75uMpQ a0y37/5bLN2LiyW2Seq0g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:yOsZyPw1n1Q=;23n0LaNuh06pDYOKhy+7nxap3DD 2yxXtdZH/0dIPEBmMIoUhnPwKsKA/y5YogA5KhEIlIOjgj8YaYbxcOttiW4X3q5OMzWZQ6+57 H4OtxiRKEzErPkXXCVN26zYmrI4l3WnF1WtVkSFR7IBuqwe5Ipa+PHTMTOHQI7nuV8Zdl4ZaN ltG7C3Xub1kUITmhBAGJuX4Ur+IvwWnD79QYZncxtqed4QN1xmh0HpO2yfqF2K0W8h9iaEF11 wW1EsEBzP7Lh+3qqeNubjblsfegqmZBxEOOSI11bhBKirRSDCNdleDbal+urahHo62NzJ40zm Upg7DSccvYQlbofygV4k2PUbL5d0lYqTINli8ZSPAs1QUJ1MSIybkkRlqKOfKT6vL+b05N6nO cnxorIevAlqSM4g7JTvRsuIDtHYf0U4aHQyQY01kGhFOAV/rocjmejj2+MyrpwYKbDuT5kZIb FTCd3bfEqMIZi2U100WRucGenjuxg89UsUmFQqqe2XtIL1CgqivJG4p8cnuBp/0YAGTEzhb19 owGgsq4EN6V/gVxUaxJjI0uP0RB0xeF65PNDBz5qYlIdP/f5QaYyhlRpvdb6BRKcxdAI5JtRo l+/gG5oLylxnwIVxogCGSXaZCO8e/FqkqsGeyOhEUHnPWSLit1R6zmAWi5b6PYfmPOwMQJI+/ ARVTOgtN98WgAvnsJhuRiLXjc2rkEbmyvcBxVLPy1YU0ZRj/c698D32wRqg/VXZykr4oe3hTN vG+mQZ11BAr69iIjzO66XDbsYpjRcgBNt7NGi9qCXPj9mPwMo5ax0YAC4ZqOoTmK9RKdrqMih XlF6d4g7R0+TW3ja2USx1JEA== Subject: Re: [FFmpeg-devel] [PATCH v2] libavformat/vapoursynth: Update to API version 4, load library at runtime X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Stefan Oltmanns via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Stefan Oltmanns Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hello, I adressed the issues/concerns that were raised with the first revision of the patch. Any feedback? Did I do something wrong? Best regards Stefan Am 06.07.24 um 23:08 schrieb Stefan Oltmanns via ffmpeg-devel: > Hello, > > this is revised patch, to sum up the changes: > > The current VapourSynth implementation is rarely used, as it links the > VapourSynth library at build time, making the resulting build unable to > run when VapourSynth is not installed. Therefore barely anyone compiles > with VapourSynth activated. > > I changed it, so that it loads the library at runtime when a VapourSynth > script should be opened, just like AviSynth does. > On Windows the DLL from VapourSynth is not installed in the system > directory, but the location is stored in the Registry. Therefore I added > some code to read that information from the registry. > > As the V4 API is designed with dynamic loading in mind (only a single > import), I updated the implementation to V4 (changes are mostly > superficial, no structural changes). The V4 API is already several years > old, fully supported since R55 released in 2021. > > > Changes from first patch: > -Separated the Windows-specific function for getting the DLL location > from the platform-specific includes > -It is not enabled by default in configure > -The header files are not included anymore > > > I would like to include the header files for this reason: > While most Linux distributions ship ffmpeg, only very few contain > VapourSynth. Therefore ffmpeg won't be compiled with VapourSynth support > by these distributions, because no VapourSynth headers. Including the > headers in ffmpeg would mean they can compile with VapourSynth support > and if a user decided to install VapourSynth from somewhere else or > compile it by himself, ffmpeg support would be ready and no need for the > user to install another ffmpeg or compile one. > I'm not sure what the rules for shipping include files are, as there are > a few 3rd-party include files in ffmpeg. License is not an issue > (Vapourynth is LGPL v2.1 or later like ffmpeg). > > > > make fate runs without any issue. I tested VapourSynth input scripts > with various color formats on different platforms: > > Ubuntu 22.04 > macOS 13 (x86_64) > macOS 13 (arm64) > Windows 10 (msys2/gcc) > > It compiles on these platforms without any warning and runs without any > issues. > > Best regards > Stefan > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".