From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 362F3455EC for ; Tue, 7 Feb 2023 08:18:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 087C468BD3D; Tue, 7 Feb 2023 10:18:45 +0200 (EET) Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 454F368BD3D for ; Tue, 7 Feb 2023 10:18:38 +0200 (EET) Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4P9wxl5J48z9sb8 for ; Tue, 7 Feb 2023 09:18:35 +0100 (CET) Message-ID: <5919fecc-bb8e-43ae-8cf2-ad63d0a95ad4@gyani.pro> Date: Tue, 7 Feb 2023 13:48:22 +0530 MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org References: <20230204100121.6815-1-ffmpeg@gyani.pro> <167575737404.10789.1016094525223863600@lain.khirnov.net> Content-Language: en-US From: Gyan Doshi In-Reply-To: <167575737404.10789.1016094525223863600@lain.khirnov.net> X-Rspamd-Queue-Id: 4P9wxl5J48z9sb8 Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg_mux: terminate stream thread queue only on sq_send EOF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2023-02-07 01:39 pm, Anton Khirnov wrote: > Quoting Gyan Doshi (2023-02-04 11:01:21) >> Prior to 2d924b3a630, ffmpeg would exit if any packet write failed. >> After the switch to threaded mode for muxing, ffmpeg only closes that >> OutputStream instead of closng the file. This happens because EOF >> returned by write_packet isn't distinguished from EOF returned by sq_send, >> both relayed via sync_queue_process. >> >> This breaks the abort behaviour when there are multiple streams in an output, >> and can leave the ffmpeg process running beyond the intended point of abortion. >> >> Fixed by marking the OutputStream as finished upon sq_send EOF and letting >> write_packet EOF lead to muxer termination. > What is the situation you're handling exactly? > av_interleaved_write_frame() returns EOF? Yes. Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".