From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 551564321B
	for <ffmpegdev@gitmailbox.com>; Wed, 25 May 2022 08:25:42 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2910F68B511;
	Wed, 25 May 2022 11:25:41 +0300 (EEST)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EDB8768B4E3
 for <ffmpeg-devel@ffmpeg.org>; Wed, 25 May 2022 11:25:34 +0300 (EEST)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 24P8PTY2021031-24P8PTY3021031;
 Wed, 25 May 2022 11:25:29 +0300
Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187])
 by mail9.parnet.fi (Postfix) with ESMTPS id 9A664A142D;
 Wed, 25 May 2022 11:25:29 +0300 (EEST)
Date: Wed, 25 May 2022 11:25:29 +0300 (EEST)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: "Swinney, Jonathan" <jswinney@amazon.com>
In-Reply-To: <36fdb39238cf499c815f9c2704381656@EX13D07UWB004.ant.amazon.com>
Message-ID: <58ba7bc-d8c1-b240-c5dc-e6177f16f1f@martin.st>
References: <36fdb39238cf499c815f9c2704381656@EX13D07UWB004.ant.amazon.com>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] checkasm: added additional dstW
 tests for hscale
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: "Pop, Sebastian" <spop@amazon.com>,
 "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/58ba7bc-d8c1-b240-c5dc-e6177f16f1f@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Wed, 25 May 2022, Swinney, Jonathan wrote:

> Signed-off-by: Jonathan Swinney <jswinney@amazon.com>
> ---
> tests/checkasm/sw_scale.c | 38 ++++++++++++++++++++++----------------
> 1 file changed, 22 insertions(+), 16 deletions(-)
>
> diff --git a/tests/checkasm/sw_scale.c b/tests/checkasm/sw_scale.c
> index 3c0a083b42..6c223c48f9 100644
> --- a/tests/checkasm/sw_scale.c
> +++ b/tests/checkasm/sw_scale.c
> @@ -148,7 +148,11 @@ static void check_hscale(void)
>         { 8, 18 },
>     };
>
> -    int i, j, fsi, hpi, width;
> +#define LARGEST_INPUT_SIZE 512
> +#define INPUT_SIZES 6
> +    static const int input_sizes[INPUT_SIZES] = {8, 24, 128, 144, 256, 512};
> +

While these are all nice even values, would it make sense to test things 
with uneven sizes too?


This patch does seem good to me, however it does break the checkasm test 
on x86. Offhand I don't know where it differs between how swscale is used 
in reality (where I presume it does work just fine) and how it's set up in 
checkasm.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".