From: "Martin Storsjö" <martin@martin.st>
To: Krzysztof Pyrkosz via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
Cc: Krzysztof Pyrkosz <ffmpeg@szaka.eu>
Subject: Re: [FFmpeg-devel] [PATCH] swscale/aarch64/rgb24toyv12: skip early right shift by 2
Date: Mon, 17 Feb 2025 10:51:06 +0200 (EET)
Message-ID: <58a22ef0-b630-2357-13fa-e683e06da6c1@martin.st> (raw)
In-Reply-To: <20250211214310.116203-2-ffmpeg@szaka.eu>
On Tue, 11 Feb 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote:
> It's a minor improvement that shaves off 5-8% from the execution time.
> Instead of shifting by 2 right away and by 7 soon after, shift by 9 one
> time.
>
> Times before and after:
>
> A78:
> rgb24toyv12_16_200_neon: 5366.8 ( 3.62x)
> rgb24toyv12_128_60_neon: 13574.0 ( 3.34x)
> rgb24toyv12_512_16_neon: 14463.8 ( 3.33x)
> rgb24toyv12_1920_4_neon: 13508.2 ( 3.34x)
> rgb24toyv12_1920_4_negstride_neon: 13525.0 ( 3.34x)
>
> rgb24toyv12_16_200_neon: 5293.8 ( 3.66x)
> rgb24toyv12_128_60_neon: 12955.0 ( 3.50x)
> rgb24toyv12_512_16_neon: 13784.0 ( 3.50x)
> rgb24toyv12_1920_4_neon: 12900.8 ( 3.49x)
> rgb24toyv12_1920_4_negstride_neon: 12902.8 ( 3.49x)
>
>
> A72:
> rgb24toyv12_16_200_neon: 9695.8 ( 2.50x)
> rgb24toyv12_128_60_neon: 20286.6 ( 2.70x)
> rgb24toyv12_512_16_neon: 22276.6 ( 2.57x)
> rgb24toyv12_1920_4_neon: 19154.1 ( 2.77x)
> rgb24toyv12_1920_4_negstride_neon: 19055.1 ( 2.78x)
>
> rgb24toyv12_16_200_neon: 9214.8 ( 2.65x)
> rgb24toyv12_128_60_neon: 20731.5 ( 2.65x)
> rgb24toyv12_512_16_neon: 21145.0 ( 2.70x)
> rgb24toyv12_1920_4_neon: 17586.5 ( 2.99x)
> rgb24toyv12_1920_4_negstride_neon: 17571.0 ( 2.98x)
>
>
> A53:
> rgb24toyv12_16_200_neon: 12880.4 ( 3.76x)
> rgb24toyv12_128_60_neon: 27776.3 ( 3.94x)
> rgb24toyv12_512_16_neon: 29411.3 ( 3.94x)
> rgb24toyv12_1920_4_neon: 27253.1 ( 3.98x)
> rgb24toyv12_1920_4_negstride_neon: 27474.3 ( 3.95x)
>
> rgb24toyv12_16_200_neon: 12196.3 ( 3.95x)
> rgb24toyv12_128_60_neon: 26943.1 ( 4.07x)
> rgb24toyv12_512_16_neon: 28642.3 ( 4.07x)
> rgb24toyv12_1920_4_neon: 26676.6 ( 4.08x)
> rgb24toyv12_1920_4_negstride_neon: 26713.8 ( 4.07x)
>
> ---
> libswscale/aarch64/rgb2rgb_neon.S | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
Thanks, applied.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-02-17 8:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 21:43 Krzysztof Pyrkosz via ffmpeg-devel
2025-02-17 8:51 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58a22ef0-b630-2357-13fa-e683e06da6c1@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=ffmpeg@szaka.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git