Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Sanjay Jangid <sanjayjangid20m@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH] avformat/mov: prevent excessive allocation in mov_read_udta_string
Date: Wed, 30 Jul 2025 17:02:16 +0530
Message-ID: <58B165F0-8252-41E3-BDE4-39909079EAD6@gmail.com> (raw)

Signed-off-by: Sanjay Jangid <sanjayjangid20m@gmail.com>
---
libavformat/mov.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index c935bbf..725a9fa 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -459,6 +459,10 @@ retry:
            data_type = avio_rb32(pb); // type
            avio_rb32(pb); // unknown
            str_size = data_size - 16;
+            if (str_size >= INT_MAX / 2) {
+                 av_log(c->fc, AV_LOG_ERROR, "str_size is too large\n");
+                 return AVERROR_INVALIDDATA;
+             }
            atom.size -= 16;

            if (!key && c->found_hdlr_mdta && c->meta_keys) {
-- 
2.50.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

                 reply	other threads:[~2025-07-30 11:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58B165F0-8252-41E3-BDE4-39909079EAD6@gmail.com \
    --to=sanjayjangid20m@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git