From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6A39D40BC3 for ; Tue, 8 Mar 2022 08:49:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 19AB268AF07; Tue, 8 Mar 2022 10:49:22 +0200 (EET) Received: from server6.ceeqoo.com (server6.ceeqoo.com [178.77.101.243]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 88FF968A7A1 for ; Tue, 8 Mar 2022 10:49:15 +0200 (EET) Received: from mailix (www.noaport.de [109.90.164.154]) by server6.ceeqoo.com (Postfix) with ESMTPA id 8A63FBD5F3 for ; Tue, 8 Mar 2022 09:49:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=noa-archive.com; s=default; t=1646729354; bh=C4pqKskAQaQsFckTyarExN0QZJlWaxtYNhJrXPv7NYk=; h=Received:Subject:To:From; b=EnLcWgbCeJxBTNGatBbef5uXvVEHuu4xHv/wJVsGu0C0jZ2DvcmrDXsP5xTn/SeN/ EEULncil8pt9Qxogg1yIiZlbqEvneHSrEP7m7hqQtVtbn0T+Jg6IwoGz+YxiiigS46 mInvaznaqTwZDIOchp8Pq47dannRO3/SvCRdDLkw= Authentication-Results: server6.ceeqoo.com; spf=pass (sender IP is 109.90.164.154) smtp.mailfrom=t.rapp@noa-archive.com smtp.helo=mailix Received-SPF: pass (server6.ceeqoo.com: connection is authenticated) Received: from [192.168.0.125] (sandtrout.kuhnle.local [192.168.0.125]) by mailix with ESMTPSA (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128) ; Tue, 8 Mar 2022 09:49:14 +0100 Message-ID: <588b1d9f-c249-9acf-09d7-991682483710@noa-archive.com> Date: Tue, 8 Mar 2022 09:49:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220307231743.28998-1-michael@niedermayer.cc> From: Tobias Rapp Organization: NOA GmbH In-Reply-To: <20220307231743.28998-1-michael@niedermayer.cc> X-PPP-Message-ID: <164672935492.18079.12114804817932699013@server6.ceeqoo.com> X-PPP-Vhost: noa-archive.com Subject: Re: [FFmpeg-devel] [PATCH] avcodec: Add dv marker bsf X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 08/03/2022 00:17, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/bitstream_filters.texi | 15 ++++ > libavcodec/Makefile | 1 + > libavcodec/bitstream_filters.c | 1 + > libavcodec/dv_error_marker_bsf.c | 117 +++++++++++++++++++++++++++++++ > 4 files changed, 134 insertions(+) > create mode 100644 libavcodec/dv_error_marker_bsf.c > > diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi > index a0092878c8..6a882ade97 100644 > --- a/doc/bitstream_filters.texi > +++ b/doc/bitstream_filters.texi > @@ -132,6 +132,21 @@ the header stored in extradata to the key packets: > ffmpeg -i INPUT -map 0 -flags:v +global_header -c:v libx264 -bsf:v dump_extra out.ts > @end example > > +@section dv_error_marker > + > +Blocks in DV which are marked as damaged are replaced by blocks of the specified color. > + > +@table @option > +@item color > +The color to replace damaged blocks by > +@item sta > +The error status to replace. If -1 then the stamask is used. -1 is the default. > +@item stamask > +A 16 bit mask which specifies which of the 16 possible error status values are > +to be replaced by colored blocks. 0xFFFE is the default which replaces all non 0 > +error status values. > +@end table > + > @section eac3_core > [...] In my opinion it would be more user-friendly to use a single "status" option of AV_OPT_TYPE_FLAGS with "s0" ... "s15" constants, instead of the "sta"/"stamask" option pair. Maybe there also could be constants for hard errors (STA = 0111 / 1111) and error concealment types A/B/C to make the option value readable. Also it would be nice to add the link to S314M documentation pages also in the option documentation. Regards, Tobias _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".