From: "Rémi Denis-Courmont" <remi@remlab.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/videotoolboxenc: Fix variable type of AV_OPT_TYPE_BOOL
Date: Tue, 16 Jul 2024 18:15:44 +0300
Message-ID: <5856182.LKnha9BjQV@basile.remlab.net> (raw)
In-Reply-To: <6c493ada-50f3-437c-b9e2-45e1bc3bec7f@gmail.com>
Le tiistaina 16. heinäkuuta 2024, 18.10.28 EEST James Almer a écrit :
> No, because -1 is allowed for AV_OPT_TYPE_BOOL, which is used as
> "undefined" in plenty of options.
> And we don't use bool type anywhere as it's not really portable, or at
> least didn't use to. Dunno the current state ever since we moved to c11.
stdbool.h is mandatory in C11. Using booleans is generally better since it
enables better inference for optimisation and diagnostic passes.
--
Rémi Denis-Courmont
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-07-16 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 14:46 Zhao Zhili
2024-07-16 14:53 ` Rémi Denis-Courmont
2024-07-16 15:10 ` James Almer
2024-07-16 15:15 ` Rémi Denis-Courmont [this message]
2024-07-16 15:18 ` Zhao Zhili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5856182.LKnha9BjQV@basile.remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git