Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] avformat/hls: reset the playlist init segment on seek
@ 2023-08-15 20:53 Timo Rothenpieler
  2023-08-19 11:13 ` Timo Rothenpieler
  0 siblings, 1 reply; 2+ messages in thread
From: Timo Rothenpieler @ 2023-08-15 20:53 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Timo Rothenpieler

The mp4 demuxer gets very upset when it gets flushed and not re-fed this
data.
---
 libavformat/hls.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavformat/hls.c b/libavformat/hls.c
index 2a2fe28a54..c625e30291 100644
--- a/libavformat/hls.c
+++ b/libavformat/hls.c
@@ -2506,6 +2506,9 @@ static int hls_read_seek(AVFormatContext *s, int stream_index,
         /* Flush the packet queue of the subdemuxer. */
         ff_read_frame_flush(pls->ctx);
 
+        /* Reset the init segment so it's re-fetched and served appropiately */
+        pls->cur_init_section = NULL;
+
         pls->seek_timestamp = seek_timestamp;
         pls->seek_flags = flags;
 
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [FFmpeg-devel] [PATCH] avformat/hls: reset the playlist init segment on seek
  2023-08-15 20:53 [FFmpeg-devel] [PATCH] avformat/hls: reset the playlist init segment on seek Timo Rothenpieler
@ 2023-08-19 11:13 ` Timo Rothenpieler
  0 siblings, 0 replies; 2+ messages in thread
From: Timo Rothenpieler @ 2023-08-19 11:13 UTC (permalink / raw)
  To: ffmpeg-devel

On 15.08.2023 22:53, Timo Rothenpieler wrote:
> The mp4 demuxer gets very upset when it gets flushed and not re-fed this
> data.
> ---
>   libavformat/hls.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/libavformat/hls.c b/libavformat/hls.c
> index 2a2fe28a54..c625e30291 100644
> --- a/libavformat/hls.c
> +++ b/libavformat/hls.c
> @@ -2506,6 +2506,9 @@ static int hls_read_seek(AVFormatContext *s, int stream_index,
>           /* Flush the packet queue of the subdemuxer. */
>           ff_read_frame_flush(pls->ctx);
>   
> +        /* Reset the init segment so it's re-fetched and served appropiately */
> +        pls->cur_init_section = NULL;
> +
>           pls->seek_timestamp = seek_timestamp;
>           pls->seek_flags = flags;
>   

Would appreciate some quick review on this, since I'm not super familiar 
with the HLS code.
It works fine and looks correct to me though, so if nobody does, I'll 
apply this in a couple days.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-19 11:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-15 20:53 [FFmpeg-devel] [PATCH] avformat/hls: reset the playlist init segment on seek Timo Rothenpieler
2023-08-19 11:13 ` Timo Rothenpieler

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git