Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls: reset the playlist init segment on seek
Date: Sat, 19 Aug 2023 13:13:12 +0200
Message-ID: <57ffbb32-1d0d-0c7c-bf00-e77aeaaa3179@rothenpieler.org> (raw)
In-Reply-To: <20230815205330.56868-1-timo@rothenpieler.org>

On 15.08.2023 22:53, Timo Rothenpieler wrote:
> The mp4 demuxer gets very upset when it gets flushed and not re-fed this
> data.
> ---
>   libavformat/hls.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/libavformat/hls.c b/libavformat/hls.c
> index 2a2fe28a54..c625e30291 100644
> --- a/libavformat/hls.c
> +++ b/libavformat/hls.c
> @@ -2506,6 +2506,9 @@ static int hls_read_seek(AVFormatContext *s, int stream_index,
>           /* Flush the packet queue of the subdemuxer. */
>           ff_read_frame_flush(pls->ctx);
>   
> +        /* Reset the init segment so it's re-fetched and served appropiately */
> +        pls->cur_init_section = NULL;
> +
>           pls->seek_timestamp = seek_timestamp;
>           pls->seek_flags = flags;
>   

Would appreciate some quick review on this, since I'm not super familiar 
with the HLS code.
It works fine and looks correct to me though, so if nobody does, I'll 
apply this in a couple days.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2023-08-19 11:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 20:53 Timo Rothenpieler
2023-08-19 11:13 ` Timo Rothenpieler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57ffbb32-1d0d-0c7c-bf00-e77aeaaa3179@rothenpieler.org \
    --to=timo@rothenpieler.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git