From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7836F464A6 for ; Sun, 18 Jun 2023 22:27:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 94AAB68BF2A; Mon, 19 Jun 2023 01:27:01 +0300 (EEST) Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ED10468B649 for ; Mon, 19 Jun 2023 01:26:54 +0300 (EEST) Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-558b70c715cso1196074eaf.2 for ; Sun, 18 Jun 2023 15:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687127213; x=1689719213; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=/Gfn2y0Kll2tQVz1iXESfXFPEmymxd4PNoVUFXyfr3I=; b=ExUWmWQ+8mewLAqW8n66tHi5rQ+Ok4SvmsIgjIuMG+9zVzenN/X++ws/8YWok1TvL2 EI/UV13s30DP1etuLMqxm45xX/Qe8OOqGHBpgoUiINpCaeSaXc4RKZd5+7CSUtsfRSS4 iZj9XEWODHHTc7y2Hkm6vjk+AcA3pzQPo27AD/ffqnvOi0g9yHdwNlvjSWznk1ogFw+V 8OIHYgf98p8H3pP3LXHJriUeP8wMIQ+19VGQ99QylHrX/Ua/VTmbJTo0FK677eGABzzi T+ylCq4J8cW35PUeTumQwX4IRAJoNOIVONKYJrvlvBoFvHrYlQ3dVNbpnbIdKw978Coo SkHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687127213; x=1689719213; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/Gfn2y0Kll2tQVz1iXESfXFPEmymxd4PNoVUFXyfr3I=; b=jkYormsAwMxdEV8bNFAe1A+0J9k5tUboOggDbYWDd1810zUbKQcF7Nvo5Rt3k/mAEZ YhHH8fbSl3lrCKQb47tY3dP+kk2C7kKuuJf3otwWN1XWQtD/8mzKAVlNP0wvwjiYxV3y K5xRTTsNVw/wIIA7RVmyHoEpN0lmVaFzT5BzCKG75h8B6p0uX/BIJ6UHWHb1wz73rc4L jGW2YpACJ1G/1fLG4dBdCl5nNDWYHvYKT70nN13kbzHAMRPJmXNTff08HO8pvFB++hWS rqFJMsOqN00QwRw2FwH+iILjqvPY183dy5h/FY+kkeVMzA7Gn62qu/7oKnp84a02yaKp Lhdw== X-Gm-Message-State: AC+VfDwIB5UFNN0GbytEZLsXDHINKcT4xaBiHDKLE8CogbWcGGIcqCLg IPxEfaCuGY2uEc06wgK/pkpY0JhdFic= X-Google-Smtp-Source: ACHHUZ4qgeRsrlq8R7qQ0W4aao14PU0heM/VEWUlAWlEFFYeJP3pu8ueoRhABcNBcTdhqHxlQeVPmA== X-Received: by 2002:a4a:ce84:0:b0:557:ccb2:7fff with SMTP id f4-20020a4ace84000000b00557ccb27fffmr3018420oos.1.1687127212708; Sun, 18 Jun 2023 15:26:52 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id cb10-20020a0568201b8a00b0055ab0abaf31sm8713424oob.19.2023.06.18.15.26.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jun 2023 15:26:52 -0700 (PDT) Message-ID: <57ad78e8-1287-b468-1438-1ed68b58a236@gmail.com> Date: Sun, 18 Jun 2023 19:27:00 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 To: ffmpeg-devel@ffmpeg.org References: <20230618215021.3044-1-michael@niedermayer.cc> <20230618215021.3044-4-michael@niedermayer.cc> Content-Language: en-US From: James Almer In-Reply-To: <20230618215021.3044-4-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 4/6] avcodec/evc_parse: Check log2_sub_gop_length X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/18/2023 6:50 PM, Michael Niedermayer wrote: > Fixes: 1.70141e+38 is outside the range of representable values of type 'int' > Fixes: 59883/clusterfuzz-testcase-minimized-ffmpeg_BSF_EVC_FRAME_MERGE_fuzzer-5557887217565696 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/evc_parse.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/evc_parse.c b/libavcodec/evc_parse.c > index 44be5c5291..822b236423 100644 > --- a/libavcodec/evc_parse.c > +++ b/libavcodec/evc_parse.c > @@ -277,6 +277,8 @@ EVCParserSPS *ff_evc_parse_sps(EVCParserContext *ctx, const uint8_t *bs, int bs_ > > if (!sps->sps_pocs_flag || !sps->sps_rpl_flag) { > sps->log2_sub_gop_length = get_ue_golomb(&gb); > + if (sps->log2_sub_gop_length > 5U) > + return NULL; > if (sps->log2_sub_gop_length == 0) > sps->log2_ref_pic_gap_length = get_ue_golomb(&gb); > } LGTM, but please let me apply it as part of my evc patchset to prevent conflicts. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".