From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 135E642071 for ; Mon, 28 Mar 2022 02:26:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2AC7C68B2AD; Mon, 28 Mar 2022 05:26:39 +0300 (EEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6BAA868A8FD for ; Mon, 28 Mar 2022 05:26:31 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648434396; x=1679970396; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=NWg1bI2IrD4wvtsNK4Ckt/OHkEuW4vmc/oZwOuoVYlg=; b=eo60Veu2ATAY1kZLsZSlXH/zfu9a23yoDyc9o8XXQTeCQhxcO6su+hIr P/N365aJQpJOF307lnlkF92z2GoJ1IqUw+xjM5HEguiIQbfGsRGQizasO StIFVKYdkfMLY++381LdC7nHutj/ytDJqdDSWDMC17w1KNRy6gH8HdOWY 7BCoPTo11lC7vOmDWhrWgrbQoX4dPSwI1lrzflurA/V+drNRzXcKlYeMY me9me+PgJ5WIVy4F3KYwbzgoml35BjcKX1JyOPy0Awq09HzYiWiHz1xee NmKmOppYpPsKDk7683J13Y3pxVKkRzoQgvZ9adLl7o1LWU6uGhTJREPXS A==; X-IronPort-AV: E=McAfee;i="6200,9189,10299"; a="241049779" X-IronPort-AV: E=Sophos;i="5.90,216,1643702400"; d="scan'208";a="241049779" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2022 19:26:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,216,1643702400"; d="scan'208";a="651462927" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP; 27 Mar 2022 19:26:28 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 27 Mar 2022 19:26:28 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 27 Mar 2022 19:26:27 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 27 Mar 2022 19:26:27 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Sun, 27 Mar 2022 19:26:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hXJN8mreOUien3K2qUYE5gNNybYXY58BHGOi8Zh4s2etkhPOu2IU/SCIMHH5fTqxGtzUsa2mftY8sj1kX1f7Rz4ay4o0AbCjJxIwcrp5EapLT/Nubw3m96sw7up3vjuYijKLf+k/zBxf0o6LE5gL7S7mnjUOw7TBaAmID7J4n4w7FNsC3bXCqAuI2ZABJ+zq8v3LFJnGgdLsNp02GtpK7D7MQ7lSZO/nib3GnXitk3pcZqSCTJtIvAIuf5Lco0r3SorhCGk1y1dEaJNj8NXZG7u13cL86vxgO6CSjI/3DMeCpfnHSXwA+VKEkBkLmQNMCPY9eQF836rDDmhLyTxjZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NWg1bI2IrD4wvtsNK4Ckt/OHkEuW4vmc/oZwOuoVYlg=; b=G13kU0+gFXuSn1RwKXiTe8EsSFlYJnmDarr59e6w1OzYwZTEN1kcM89RzIGxq3waWy3qhnrdBk6qMjC/MbHcR13LSIrcSe4xX2yc72hShzbNca61lsUZnVVBNVh0RpevyDYnJSqAv8I1anxlIEkfuf/hE1V3TsNI02GWASHpzrwPthLp0qx7lqPAetjVy6Ip5/knODgv9A4uj+WoGwVdReMnGqtdfda7C2qCMmEeOc6a0y57tr9yB3Opp66IFvarj784jWg4N5j9LL9SMK0too7xM5PINohSlwX3lwuZvvlxpzJ2xYRIZXSs0byvFwpwb7mO8sDk8lEaoY5znTw/LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by MW3PR11MB4650.namprd11.prod.outlook.com (2603:10b6:303:54::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.16; Mon, 28 Mar 2022 02:26:10 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::c0b8:e06a:3d29:da25]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::c0b8:e06a:3d29:da25%5]) with mapi id 15.20.5102.022; Mon, 28 Mar 2022 02:26:10 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2 3/3] libavcodec/qsvdec: using suggested num to set init_pool_size Thread-Index: AQHYOpEcm1jg5zkYQEeAelY1P1CQRqzEwbgAgA9fhIA= Date: Mon, 28 Mar 2022 02:26:10 +0000 Message-ID: <57a8a823dd8f53dec096f5747a552d88b20b5b77.camel@intel.com> References: <20220318062511.382951-1-wenbin.chen@intel.com> <20220318062511.382951-3-wenbin.chen@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 246bca5f-cc1c-4f12-3c30-08da10625274 x-ms-traffictypediagnostic: MW3PR11MB4650:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dfkXUIqPddbbVHH5rEgFa5/4bDu3XsUPJ6n8nVaOBodd9j7bj+CBqmAC77UXKUsmFfRfTjFcbm98jWTboqjJvhnK/JEyskoWGQTwqlABd2atG3R3sUe+BbYWC9abqiVu7Ks29Ib+a4Cq7T0pFMd/jjfIOx3+pXZnU8AJaHSzWOOqVQQMhrNQ364K7M5VG1UdNsespX9cxvhWt4RvE8jFXj14md8bKyMVvzTkawYWLIGZ1Ty31gFHCl76sK4tTgvwyhQNW0aWBNLuIvQmNoHAgX7FXlwHkxNm1ktWho4D2LaKBZ3+N3d8RUsAuTU/NolZYLfpoCOaS9xL1vlJLm6qm8FoC+TCFoMKBPfbBMkSY8vI9Xk4LHCegZXmMuKHpVFG1jHZrTqcD4/9N87lG3OkFqu3QkBEZQJlH8dc/mWawbqEPtH3LI+7JI8B7rD3HPGxfVD7OtnKY9azFP3gDJrIonYGjnf9MzJE/hZXNA2kjE4P8b+wRrJ51ri9ZZ0dHT+oPy16MYLz57rI8RTXjrj6t1l38x15wUir7hpmWRz7pqaEg0Lw/bVFKPlDPq2e1v8YwohntA6OnTZHnpt6RJjWO4xX3uFpwMS1wYtGXzeXWBjqvnrmQ57C4K95jVaEzjZ45bjnvjK6wlF404xn5c7+V5ibfga8D7vt/GbjghAsX0V3ZLI2Ia1XvqQf9PDvBxhGK5AwjAuTfGZ/+DpWh1YgutwnztZoEPY7EE1m7yh67vg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(71200400001)(36756003)(83380400001)(6512007)(82960400001)(5660300002)(53546011)(38070700005)(6506007)(8936002)(86362001)(38100700002)(316002)(6916009)(2906002)(122000001)(508600001)(26005)(91956017)(76116006)(186003)(8676002)(66556008)(66476007)(66946007)(2616005)(66446008)(64756008)(6486002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?c1ZRYWt4R2tzUzZqU1NwRXZnd3I4TDFQeENmc3JtM1RITlJHZFdGdXV4MXRK?= =?utf-8?B?anRDNE9kaHpNamZYTjRSYkRlVkpZRUkvdGZhc0oyS0pkOFlvazUvNDRrdXd0?= =?utf-8?B?YWU4aUZsakZ6cTBrdVppRWF5Y1l2b1Jjc2JEWk9OZUwxbEI4WVhHa0YzcUkw?= =?utf-8?B?OElJK3VyRXhHeW5QQzlhMXF2Yi9vMlc0TXlLeGZkdWRZQkcvL2ZIOHIyZ2JQ?= =?utf-8?B?MjBta3lCMDVJcjI2YWdrZGt6SU5lNUtEWlRJa2E2SVdzSjlOcnlKNWE0Q0Zr?= =?utf-8?B?UHk2dWJKNGl5K0tMSlhsNitLR2NNV0dyVkVESFpIWTNPVjZoRWUxeHU0bW1V?= =?utf-8?B?LzIrN1J3Y29idGFZck1URzhiZXJZTk0rZFJKWVl1NVRicDcrMWdwa2ozSWVi?= =?utf-8?B?c1BhU3NtVG5MTXNEL1Rnc2c2eDdXaVJwRGdpdXRLWFl2RjNLV3BHQ3dXQUxo?= =?utf-8?B?UFFObHNpSkRHN012ZldHeXpXMkJETnAzU3dtL1IrQXZNUS9QSlMrMVBWQkRa?= =?utf-8?B?QUE0WVNCL3N1aEJrblkydHFaNGhTRXBQcEhWZmZ3UDFnNm85amxZRWVEVmcx?= =?utf-8?B?YTJVUklvY2pBdndxV0JqSHlOSXo4RklKclZ0ODU5aldIYmtnZllBZk8zZTZY?= =?utf-8?B?VXhJd3RzNkVFbzBVTWFmUmZ2Z0lGcFE0QjdLUGxzSFhWVmRXd0tqWHNnOHQr?= =?utf-8?B?UHFXaXBBRGZYV2YrNjI5RjJhRHF4RGhzOThoR2FkTnFGS2duUEVWWTJyY1Bl?= =?utf-8?B?dXhzbjcrL1FNdnAzRWlESmtFcy9CaHVtRUFsWEJBQUl2SnVOQTlYZDg1ZktS?= =?utf-8?B?OThYamlHQjBBcjN2MkxjRG9KU0ZnRzQwN211UmhjWmdiVXBaY2N1Skxwc3dL?= =?utf-8?B?OFZ1QjZQblhhTWpQTXcxSHBVTHgrbngzYVN6b1pkb1JjbW5QQ1IzWnhFdkFH?= =?utf-8?B?L1hWSXYrRlNpWVhLQTdJODEzcXg1bW9QeU4vSDQzeGxTK05UMkpaUnRldFo3?= =?utf-8?B?K0E0WTNGYjBhdU1pZHZ4L0F0T3NQSVJVMkpSdzhUdVFycFhST1h4QWFwT3pE?= =?utf-8?B?RnFNaE9HNDUyQWduU0xpcTMzYThMWFRqNTV5a1EzejFnV1pTUGNuenkvcy9O?= =?utf-8?B?WWxmSlE3TTJjRW5qTDB4em1CYUVDNUNCdmxBK3lvOC9yMklMM2F6NWR1TCtx?= =?utf-8?B?b3ZoMlducHFCV3JId0I2cWhKSTJ3T1dyNnY3aEFtdmpqVUFMOWpCa1Nrdlc4?= =?utf-8?B?OTdoUVkwclV0dTJXOC8wY0NWNEVDT2hVWE1RcHJKTE5TQTdiVHdKTmJlT0JK?= =?utf-8?B?TmVWeEFoTVlRa2RNQTRNOC96bzFOWVFuN1lZKzhvam56SGJDQVMwZ0kxNXpC?= =?utf-8?B?MDRaQjI2S1FhaHFRQUgrYlI2L0tabDFreEIxSG0wb091NzhXTUlzQU1tUDBD?= =?utf-8?B?aXdocGxvTmhMZEZ6MHVxY3JFM2YreGNpZGp0VU9JOWhBQWtYMURrRDc4L1RV?= =?utf-8?B?U01KUmpCbFBFOXBXemkxbm42UHNGVFhxZE9BcTJCWlpUWE50dkdUSHNhYVBY?= =?utf-8?B?QnQ3NkJxdTFMSnFmYy8yWWRlU0xyK0VSc20zbzFFMEYxdTFYd2l4WUdGQ0xU?= =?utf-8?B?d2liSjR2QzJVNldDQmoxQXVaOE5GSlRkZ01KMlUwREVTQ3oxSG9BLzdTNWFO?= =?utf-8?B?NWNFQjZTNGFPekVpa0wwNFMxaTE1WFc4QTJTZjBKTHlHbk9iQWQrWTlMWWRM?= =?utf-8?B?WVY3U1VFd2xoNzkvUnlTOWIrVmsvWVdES3kwY2t2bGdzc2tOdS93MXRTaStY?= =?utf-8?B?ZUNFeVhKT2hmaGZsMEtzRVoyaWVGYUlsdFpDUGprUjVxWlpsTjh0YXBwTkZz?= =?utf-8?B?SDBMakdyRS9pa2tnYktXblQ0U1Z1NjZQVTJ5WVdRVDlNZUF6d3RpekRaT2hE?= =?utf-8?B?ODI5VkZBaDlteDhhb0NEWVdTelNNSUZicmxtRFJBYU9Fb0NQQmtRamdBeVUx?= =?utf-8?B?SlBpcGxYckRNaWU2Y3NvZHZTNEl1eldiRi9sOVdqd3Q0cERGS3hvUCs5bFlj?= =?utf-8?B?UGo4cStkR1RWSFlPdGVEeWg1RTd1QzJZZjh4LzFKaW96YTNUVE9HQUlrS0d5?= =?utf-8?B?aGdvYnNjZFdCeENRUDA5YTVmYVJ4aW0yWnd2dENLV1JiK0VFM3ZudktQbmNi?= =?utf-8?B?ZFZVdUFtK0gyOE9tVy8yeld1WmFqK0ZDampSVE4wNlNYdURYd2VlaElZMERv?= =?utf-8?B?czVRVkhjTjRPNXAzVWE5MWpWQXY4YjJXa25rQnhhQ21MK0dRKzVadC85ait4?= =?utf-8?B?ZThUSGNXeldYMTZENXJuUjZEMWRJNXFsZkNVNVN2ejNWMjQvamFQWXIvTkhP?= =?utf-8?Q?O5oZtRNF/MIBSEzA=3D?= Content-ID: <1515F3859B748A49A8622A452CCB0DEF@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 246bca5f-cc1c-4f12-3c30-08da10625274 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2022 02:26:10.1597 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6riSojWyMkeL5pHkZPyE8xqIdZgionM+KpP48J6yRo1+HTdvjiosXz+xnu1jlz4NW/xlD0lHfSBvi5APR9OfOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4650 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2 3/3] libavcodec/qsvdec: using suggested num to set init_pool_size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2022-03-18 at 07:40 +0000, Soft Works wrote: > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > > Wenbin Chen > > Sent: Friday, March 18, 2022 7:25 AM > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH v2 3/3] libavcodec/qsvdec: using > > suggested num to set init_pool_size > > > > The init_pool_size is set to be 64 and it is too many. > > Use IOSurfQuery to get NumFrameSuggest which is the suggested > > number of frame that needed to be allocated when initializing the > > decoder. > > Considering that the hevc_qsv encoder uses the most frame buffer, > > async is 4 (default) and max_b_frames is 8 (default) and decoder > > may followed by VPP, use NumFrameSuggest + 16 to set init_pool_size. > > > > Signed-off-by: Wenbin Chen > > Signed-off-by: Guangxin Xu > > --- > > libavcodec/qsvdec.c | 14 ++++++++++++-- > > 1 file changed, 12 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c > > index 210bd0c1d5..9875d3d632 100644 > > --- a/libavcodec/qsvdec.c > > +++ b/libavcodec/qsvdec.c > > @@ -88,7 +88,7 @@ typedef struct QSVContext { > > uint32_t fourcc; > > mfxFrameInfo frame_info; > > AVBufferPool *pool; > > - > > + int suggest_pool_size; > > int initialized; > > > > // options set by the caller > > @@ -275,7 +275,7 @@ static int qsv_decode_preinit(AVCodecContext > > *avctx, QSVContext *q, enum AVPixel > > hwframes_ctx->height = FFALIGN(avctx- > > > coded_height, 32); > > > > hwframes_ctx->format = AV_PIX_FMT_QSV; > > hwframes_ctx->sw_format = avctx->sw_pix_fmt; > > - hwframes_ctx->initial_pool_size = 64 + avctx- > > > extra_hw_frames; > > > > + hwframes_ctx->initial_pool_size = q->suggest_pool_size + 16 + > > avctx->extra_hw_frames; > > frames_hwctx->frame_type = > > MFX_MEMTYPE_VIDEO_MEMORY_DECODER_TARGET; > > > > ret = av_hwframe_ctx_init(avctx->hw_frames_ctx); > > @@ -793,6 +793,9 @@ static int qsv_process_data(AVCodecContext *avctx, > > QSVContext *q, > > } > > > > if (q->reinit_flag || !q->session || !q->initialized) { > > + mfxFrameAllocRequest request; > > + memset(&request, 0, sizeof(request)); > > + > > q->reinit_flag = 0; > > ret = qsv_decode_header(avctx, q, pkt, pix_fmt, ¶m); > > if (ret < 0) { > > @@ -802,12 +805,19 @@ static int qsv_process_data(AVCodecContext > > *avctx, QSVContext *q, > > av_log(avctx, AV_LOG_ERROR, "Error decoding > > header\n"); > > goto reinit_fail; > > } > > + param.IOPattern = q->iopattern; > > > > q->orig_pix_fmt = avctx->pix_fmt = pix_fmt = > > ff_qsv_map_fourcc(param.mfx.FrameInfo.FourCC); > > > > avctx->coded_width = param.mfx.FrameInfo.Width; > > avctx->coded_height = param.mfx.FrameInfo.Height; > > > > + ret = MFXVideoDECODE_QueryIOSurf(q->session, ¶m, > > &request); > > + if (ret < 0) > > + return ff_qsv_print_error(avctx, ret, "Error querying IO > > surface"); > > + > > + q->suggest_pool_size = request.NumFrameSuggested; > > + > > ret = qsv_decode_preinit(avctx, q, pix_fmt, ¶m); > > if (ret < 0) > > goto reinit_fail; > > -- > > Thanks for the patch! I have that on my list for quite a while. > Will look at it shortly. Hi Softworz, This patchset LGTM and works well, do you have any comment ? Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".