From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id F1A8B4FFB3 for ; Fri, 4 Jul 2025 15:17:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3276968FB0A; Fri, 4 Jul 2025 18:17:57 +0300 (EEST) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 9195068FB19 for ; Fri, 4 Jul 2025 18:17:50 +0300 (EEST) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-453608ed113so11680145e9.0 for ; Fri, 04 Jul 2025 08:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751642270; x=1752247070; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=NCW/TjRQDe0TATnEXAcMiKFxv2qvyLv9GQJMl1ib6Pg=; b=DSvpPFk0wINmYmI+j0kbnD/EZCfd1uvYtxJFeVrf/7D/4uSaFY1ieHHzK/llDJXxm9 OftmWwbxWmIWunEEOxuo3DSftOoMBIIh4MsfNZ9wlgYJwec6qpIdIpxO/Cg/LdoocAS6 CGylSkZiWU7Sb7ZRBT8gIcqKuaajyJ03bC9dRaHnj5Jr6urT/Ob4j8io1//vlMu5EXr6 Uw6pWPvpHRVoKZm0ZnP4CLyStfOYgL4qzQRPko5Te4tPAGI/JnR3reGf1K6mlhoIjKcH ZTROVZaEtuo8ggCzWv06iG4KXSd3JpsqJh3BtE9x7w1SRKZlaTuyqHSBF4beqU0po2g5 l6Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751642270; x=1752247070; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NCW/TjRQDe0TATnEXAcMiKFxv2qvyLv9GQJMl1ib6Pg=; b=H4+3BAKMweHKqwS2XuYRIUIls2OzKf1RIBcd7Nq89IKipxg9JT7PEM1wki5ugqMleo ZSfiW7L76M7uJsXK6U1d0iJvARpjHGlHPeozGgJMP7jwOYE4J2eGnsec+VX24RP5NcUi 19wkHiRLtNQ6/UW5mBDbm9dXPWB2C2Di+czUOsohMngV6WBb4J1YqJsEk+5NXDfSH44G prfo4qaPu3+S9MZM9/wCYCwWnZCS20INMr0HRu1J2jUgLZ3krw4NAdh+wtUeWZjbaQwF 0W7xJgcxPCvb3GjU8JTywI1wtFGXwKcNJONMbL97YcWPDDXgmp//o8YDM14Da9vYJ8n+ UeCw== X-Gm-Message-State: AOJu0Yx9fmg91UMDUzRpvFNM9DmlZb7Ykv37lej2HMgccKJ2CbHvbSTR mfMScX5rP1YjOSm+ZyV3XriXa60n9UGmMRc/dj6CeboeOn29afmcQBg9CQCvGw== X-Gm-Gg: ASbGncspoA5TaBJon78hjm0mkwP3E2oCXOKISMSAZ7MCRdXX+OeDWweY7H2XUyDJYh4 gaJntI9IgNsn8D9ntAKmriCIONx+VXCg8tS+UGGI3QbQ02p/+QLu4jDhQsRj4CKOaRK4lmrYZ6z pCmn/JHYe1fEEflrLoT8jlhJfCeRiKZHv6ErlFfsV7v0uTnTzR3sBW4btZvFGi+pMjDSDngXCvE fhBgHPGuDgOWJ3WdcLcuibdgtHNd/yDBU44m4dDiNpZosZ0oD5DbM509PTcBCCn/KcH4q1Lvqj7 QdXzKekBF5NcOE+oZ9/N46cH7xN1kKWyCcaJZvzop80vdZ0iL4dXL/xyOcCDzuL1VlO9ZVIPYS7 Ej0Jtnb8asFOP9e+oTkj2trQvzT6CxQ6/VC8QUF4utkatMB0FBTyIVV0jW0ebamKfKzzl5O6BPl XK X-Google-Smtp-Source: AGHT+IFDcWD8MbFRrZfyhDeBlGZFVc9MB/ln7BI4WPUN4bySSJS10vxTueGbyQkkCLUeDuK1fUJF/g== X-Received: by 2002:a05:600c:870d:b0:453:b44:eb69 with SMTP id 5b1f17b1804b1-454b308d0damr34053735e9.13.1751642269584; Fri, 04 Jul 2025 08:17:49 -0700 (PDT) Received: from [192.168.178.137] (p200301023701fa007c711eeeaa4bf578.dip0.t-ipconnect.de. [2003:102:3701:fa00:7c71:1eee:aa4b:f578]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b968ebsm2692951f8f.47.2025.07.04.08.17.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Jul 2025 08:17:49 -0700 (PDT) From: Marvin Scholz To: ffmpeg-devel@ffmpeg.org Date: Fri, 04 Jul 2025 17:17:48 +0200 X-Mailer: MailMate (2.0r6222) Message-ID: <57B7B3CD-F138-42B0-906B-0E78F9F39AE1@gmail.com> In-Reply-To: <20250628142725.26651-1-epirat07@gmail.com> References: <20250624180202.15430-1-epirat07@gmail.com> <20250628142725.26651-1-epirat07@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] lavf/rtpdec: fix RTCP SR packet length check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 28 Jun 2025, at 16:27, Marvin Scholz wrote: > The minimum valid packet length is 28, given that the length includes > the packet header. > > This didn't cause any issues so far as the code did not care about the > last two fields in the SR section, but will be relevant in a future > commit. > --- > libavformat/rtpdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/rtpdec.c b/libavformat/rtpdec.c > index d54ac31eb0..5aecf7fbc7 100644 > --- a/libavformat/rtpdec.c > +++ b/libavformat/rtpdec.c > @@ -187,7 +187,7 @@ static int rtcp_parse_packet(RTPDemuxContext *s, const unsigned char *buf, > > switch (buf[1]) { > case RTCP_SR: > - if (payload_len < 20) { > + if (payload_len < 28) { > av_log(s->ic, AV_LOG_ERROR, "Invalid RTCP SR packet length\n"); > return AVERROR_INVALIDDATA; > } > -- > 2.39.5 (Apple Git-154) If there are no objections, I plan to push this patchset start of next week. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".