From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D1EA944F01 for ; Tue, 29 Nov 2022 16:47:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E05568AEE0; Tue, 29 Nov 2022 18:47:08 +0200 (EET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B50DD68A65A for ; Tue, 29 Nov 2022 18:47:01 +0200 (EET) Received: by mail-wm1-f51.google.com with SMTP id p16so11406080wmc.3 for ; Tue, 29 Nov 2022 08:47:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:references:in-reply-to:message-id:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=nV8i7cbANOFWE1QuSDHmQcAzQbjLaas6OnMrvPWMv50=; b=RaNYpCEBkX4OAt4oPWtMcW1dRdRGJPTX7f3p6YfcxpZpuCA8aSnGu9MTMMl97pRsI2 MbFO6Uqgb1oAYNyfTXbJiBxzTpRz0GV+l0KYwrcWjMBcprvgw+xmdRcy5/lU4IkxwZ+s tRZ3Qki8YEAiTP0KZYYFCGSHqCZIooIUdml7aKDpJL5D10UKXZg3rrPUjcSHfQashgZQ UA//zQJ+LJxtXOQhqXRac4lG7BLSZVwOoDiem3mezXWcr6XBvznMs4SaSE9jqaswmbuA UoEb8+EMdCWHTNXv3rKB6P8yq5BQjz2GKH8Fcx2uA/CXHbpGf7eFK/Qp9qyqOfCp2iVS dzlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:subject:references:in-reply-to:message-id:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nV8i7cbANOFWE1QuSDHmQcAzQbjLaas6OnMrvPWMv50=; b=TGqsuCMUwcRy9Ws1ACLFqUKfBp+4L40g5Nj1lu31aAfA1aHrGzKlTzAfMIB0szZFZn z/DNAcNoa9XZyxAJKJMagkz6HoK/r80bVCpjj/BTKV3yJUdak/AmDud80mFqHOY1unBq OTtkxv67y2KFgXdhvm5KGZGlbZnEk0ToKf6m3okBFu55/54cIPf9g2Bs8sHU/cTF1dBl AHZz1I/nXVZEF/CcslsKaR17wlFS7f0xZXAx1bl5RVpYfh6Trj0o73NvXpqzt4NQcTZc REfKCazylqVT5DsrTpIonpsVC2CQsdDuiKdmaqxbCcf2o5tO3p6BHITXB9N7KWNBX+9L Vj0A== X-Gm-Message-State: ANoB5pnHApOlXClqFAh05DxSrJoPKVDg65itvljnhHMZIu0sikZrYib0 sjzQtTdCxJb8FzUvbN8NANdsF6YiwWlJfg== X-Google-Smtp-Source: AA0mqf44rZLaz2BPMx3Mc31XACu9c6GwpcIADYahuI+sa5Tnv/rNJ5enopGKMmoDWlH8GwDk6b8BiQ== X-Received: by 2002:a05:600c:4f44:b0:3b4:7a99:b22c with SMTP id m4-20020a05600c4f4400b003b47a99b22cmr4926300wmq.11.1669740420812; Tue, 29 Nov 2022 08:47:00 -0800 (PST) Received: from [192.168.4.24] ([46.121.212.87]) by smtp.gmail.com with ESMTPSA id d8-20020a5d6dc8000000b002415dd45320sm13986320wrz.112.2022.11.29.08.46.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Nov 2022 08:47:00 -0800 (PST) Date: Tue, 29 Nov 2022 18:46:52 +0200 From: Alessandro Di Nepi To: ffmpeg-devel@ffmpeg.org Message-ID: <579ffa65-32b2-4f60-bbc3-4376e34fa892@Spark> In-Reply-To: <20221127173343.2577-1-alessandro.dinepi@gmail.com> References: <20221127173343.2577-1-alessandro.dinepi@gmail.com> X-Readdle-Message-ID: 579ffa65-32b2-4f60-bbc3-4376e34fa892@Spark MIME-Version: 1.0 Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Just to add that this fix, once approved, should be cherry-picked to all the release branches where d7f4ad88a0df3c1339e142957bf2c40cd056b8ce has been cherry-picked. Basically, 4.4, 5.0, and 5.1. Thanks On 27 Nov 2022, 19:34 +0200, Alessandro Di Nepi , wrote: > The commit d7f4ad88a0df3c1339e142957bf2c40cd056b8ce introduced a race > condition where the passed opaque pointer reference might be NULL, > when the decoding process starts. > This patch checks that vtctx has a value before accessing it. > > This patch fixes #10079. > > Signed-off-by: Alessandro Di Nepi > --- > libavcodec/videotoolbox.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c > index 1b1be8ddb4..615e2b087a 100644 > --- a/libavcodec/videotoolbox.c > +++ b/libavcodec/videotoolbox.c > @@ -692,6 +692,11 @@ static void videotoolbox_decoder_callback(void *opaque, > { > VTContext *vtctx = opaque; > > + if (!vtctx) { > + av_log(NULL, AV_LOG_WARNING, "vt decoder cb: vt context is null"); > + return; > + } > + > if (vtctx->frame) { > CVPixelBufferRelease(vtctx->frame); > vtctx->frame = NULL; > -- > 2.37.1 (Apple Git-137.1) > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".