Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/aac_ac3_parser: do not override the profile set by the decoder

From: James Almer <jamrial-at-gmail.com@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/aac_ac3_parser: do not override the profile set by the decoder
Date: Mon, 7 Jul 2025 10:21:49 -0300
Message-ID: <57850567-055d-44a1-9f66-999c4b18653a@gmail.com> (raw)
In-Reply-To: <20250707131930.2924213-2-nicolas.gaullier@cji.paris>

[-- Attachment #1.1.1: Type: text/plain, Size: 1006 bytes --]

On 7/7/2025 10:19 AM, Nicolas Gaullier wrote:
> Parsing the ADTS header is not enough to detect HE-AAC v1/v2.
> 
> Regression since 64bb91fd3b5a00a8849531c7e8dd207f2a626096.
> 
> Fixes #11600
> 
> Signed-off-by: Nicolas Gaullier <nicolas.gaullier@cji.paris>
> ---
>   libavcodec/aac_ac3_parser.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/aac_ac3_parser.c b/libavcodec/aac_ac3_parser.c
> index b49ce0277c..51c801214c 100644
> --- a/libavcodec/aac_ac3_parser.c
> +++ b/libavcodec/aac_ac3_parser.c
> @@ -152,7 +152,8 @@ get_next:
>                   ff_adts_header_parse_buf(buf, &hdr) < 0)
>                   return i;
>   
> -            avctx->profile = hdr.object_type - 1;
> +            if (avctx->profile == AV_PROFILE_UNKNOWN)
> +                avctx->profile = hdr.object_type - 1;
>               /* ADTS does not support USAC */
>               s1->key_frame = 1;
>               bit_rate = hdr.bit_rate;

Should be ok.

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".