From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D3E5243D66 for ; Tue, 9 Aug 2022 11:13:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DD46E68B7F3; Tue, 9 Aug 2022 14:13:12 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E20A568B697 for ; Tue, 9 Aug 2022 14:13:06 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 279BD6CO020972-279BD6CP020972 for ; Tue, 9 Aug 2022 14:13:06 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 4442DA1468 for ; Tue, 9 Aug 2022 14:13:06 +0300 (EEST) Date: Tue, 9 Aug 2022 14:13:05 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20220623180407.21081-3-jdek@itanimul.li> Message-ID: <5734bfec-e85e-903d-e047-282d58010bf@martin.st> References: <20220623180407.21081-1-jdek@itanimul.li> <20220623180407.21081-3-jdek@itanimul.li> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 3/3] lavc/aarch64: hevc_add_res add 12bit variants X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 23 Jun 2022, J. Dekker wrote: > hevc_add_res_4x4_12_c: 46.0 > hevc_add_res_4x4_12_neon: 18.7 > hevc_add_res_8x8_12_c: 194.7 > hevc_add_res_8x8_12_neon: 25.2 > hevc_add_res_16x16_12_c: 716.0 > hevc_add_res_16x16_12_neon: 69.7 > hevc_add_res_32x32_12_c: 3820.7 > hevc_add_res_32x32_12_neon: 261.0 > > Signed-off-by: J. Dekker > --- > libavcodec/aarch64/hevcdsp_idct_neon.S | 148 ++++++++++++---------- > libavcodec/aarch64/hevcdsp_init_aarch64.c | 34 ++--- > 2 files changed, 97 insertions(+), 85 deletions(-) LGTM. The patch is a bit hard to inspect thoroughly (to see exactly how little has changed) due to the functions being moved around at the same time as they're modified, but I checked and the changes do look fine. By splitting things up in individual macros for each function, (e.g. add_res_4x4, add_res_8x8 etc, then add_res setting the mask and calling the others) you could keep the code in place and make the diff even easier to read, but it's not strictly necessary. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".