From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4CA404118E for ; Tue, 4 Jan 2022 02:16:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 192DE68B10F; Tue, 4 Jan 2022 04:16:22 +0200 (EET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E3BCB68B10F for ; Tue, 4 Jan 2022 04:16:14 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641262580; x=1672798580; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=gb9CWLIzGHsz6NMuqKbWkl/xa0YMCYdXB5HqU5DarfM=; b=loK6C9XwzRB1zN4Z0rtvf3C45X9dlNtBapt1yuFHjUkpIJgv1vQLD66z KULifYhWzh84BkM4hMuFVT2IWpAKlkUpfVie43G1L53KGVInVzIlNdTiB YVtOhV0NjinHKeeMLB5/VRxUKqTeWubp5ztC5E5Vft4ZQbKSzwhBLnylv odCVioaJCx6gdb+Wh07pPnHALe9UJMvv7472KzwqUEfHP1QGya/6x7ZK5 DvJQbyi7gwqKbDwAuNumJ4aMiMewxSOH0lT6x+uELCtAE/EmvJI2Dfz1i V68QBisCy9oPbpMnE+AWVgdD2zA4mNaWJ+nDsB5jp+U20RLkYG9VLgkyw g==; X-IronPort-AV: E=McAfee;i="6200,9189,10216"; a="222135630" X-IronPort-AV: E=Sophos;i="5.88,258,1635231600"; d="scan'208";a="222135630" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2022 18:16:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,258,1635231600"; d="scan'208";a="525823020" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga008.jf.intel.com with ESMTP; 03 Jan 2022 18:16:12 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 3 Jan 2022 18:16:12 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 3 Jan 2022 18:16:10 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 3 Jan 2022 18:16:10 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 3 Jan 2022 18:16:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XM+YasRVFK/0Hm+zmlXhSvlrEZdXaZIDOIWkUa/iGgZkX+ka8TJySikbz3ukQcOAQHDR0xvVKKHAGK+R2WEOZpY8SwBwncooMsxIuuxOZwod8mxZnhaDC+JItVBAhX7PFtHjBw+lnWmPxXVpIm99ninOIb+4gr/Q441b8UFaF/VjJI/UgR2X26aQaEjBl6EmKtWAXyhb+ttEh4QT+lt/nveY3Ne7Wj2x4jYxf7mEMoAnmptG8PXmw6R8xjPXPUz3qvwmH5zo4v6O+YtfDdnVAiiOHbMJzcVWztu5HsxHh9ew1n0tO4LxhKUTwux3UQOgMUOqD3jlLeJxLS26IMY/Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gb9CWLIzGHsz6NMuqKbWkl/xa0YMCYdXB5HqU5DarfM=; b=BbB+MhazK1HCPQhY+LYrHubDNpTsTYfgxufZhGCoQMS6CEi8Yy2mpbsPxr9m+0fBqAFclwM0VjliNO+zA5ew/NoKz8CSDD/MyQr7/r7NDe9nTLzU4YFAN4diZ0tuTn81f8Hqe0Z5MA4QcJg9G+oxmnQCFRbzYSRI77De4skGeOvgc/l7/DeIV3sp+JvojlngbkVky81V/NA/Vm4+3FzAcXEROrT8VipySUGn1WfSib9oiKmrezZwG8jJIfLUcRN8+bwtwpV3Ish8u99DBYuOIIFtUoTaYIL39O9wiFy7ibJ3v3ntzReKi+2NTz5xyl7CRccrReF6Pn0/BzXVCDeVjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN8PR11MB3636.namprd11.prod.outlook.com (2603:10b6:408:8c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.14; Tue, 4 Jan 2022 02:16:05 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%4]) with mapi id 15.20.4844.016; Tue, 4 Jan 2022 02:16:05 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2] avfilter/vpp_qsv: fix regression on older api versions (e.g. 1.11) Thread-Index: AQHX/4q8dtdgWGYF0U24GWemf7V/l6xSIvaA Date: Tue, 4 Jan 2022 02:16:04 +0000 Message-ID: <56d6ca16679da102a94bd5d330777324cc0a200a.camel@intel.com> References: In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5148d5d6-cad2-4984-a51e-08d9cf28297d x-ms-traffictypediagnostic: BN8PR11MB3636:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2150; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Gql3bklHvAPZANNGoD2BFphKTnBCsWGI3119p1jZo4X35QlRGiJRLhFOrcGvwuTKNM1QbeVOcPVVCbN7CeW1gjFBegNsCcm2+B550/xJaQOvd33XSCTWDbSyGhC5bINz8Aw92uQ3JFzqHm1dgLYPbFbkkHDeuUINenWkARZ6nGkTyDLDbbevV1EqgNc09KYmFoA8zYvImZEXzuJqJw4h/OihhGz53bOL1pkVQF9vJKEI0UgNzwuYsNIvyGrJGIafxRGHAIJgcFLzdUJWoElw9EdyyfyhDz3imRwGiWRAXwJFP+zcHVQ6OeZUwOXcQgc8Tb3ACmdatWSHskGBoB/AWxf8J2sM+VK7VBktcFVtro06DrQz/lSg+eL8rgSmRxgw5IwEWmh7eVtSB9rSOXev6vFUjKtbPb0XcgbBcPmyLa6PgsaKZiiTT76f/KMS/mYvPvpMGITvVGE+ihGuHHaDewv4Q/zUUMxsyrAHDApWebAfBKoSm2M2aXfDINXl/0TGFYRHOGvJcCkipWxIks/h3uG3IXsh7a/lDde/43fMJO2sJ0kg1ODxQFOk8w/mAXp0EYwEVrICiqFMrbYKm7LTFcwly2BSHX9kfu7XBZ77++X+x3B0g4fLyjguu+0zBf5Cvxl8NXnZpj69b1ir9aBJkpai27FzdalqEcVdT0PSYWfztgDLHFstSjKPX6Io1RNFlkQ0nV+E9025r4RglydrQhXYSwV5dD00ulyIEA/RYMyt6jbhnYsCzznL7u7ye/nUi6GQgWcm7P4dPd6zSGjLTEnlZTbsAv3mdYld1LudvELVZdIxLJ8VfJY5CUbZ9RKa/oGB4jxpFJLRCIFUQooaNIRsInc8G7XVP7Dy2th1GcM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(508600001)(5660300002)(91956017)(6506007)(76116006)(4326008)(316002)(66946007)(64756008)(66446008)(83380400001)(186003)(66556008)(38070700005)(6916009)(966005)(86362001)(66476007)(6486002)(2906002)(8676002)(71200400001)(38100700002)(122000001)(36756003)(82960400001)(8936002)(6512007)(2616005)(26005)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dTk3dXVqZldOVXQ0cEhJd0loTGl4ejFJWWlWaGJKNXlTenUvU2pQYlNZQTRQ?= =?utf-8?B?MTNQUXhVNjltWHluSnpSYTl1Y0NJUVg5RlhEcVplTVhzenBtNG41RWpmM05i?= =?utf-8?B?SVRna0RqdTgwNnE3VGQvYnpJTm9oYVVRNk5nTzRydUlGaDc1ZTIrNHR2Mitx?= =?utf-8?B?anJjMDJ1ZDFqaXlWK1FEL0tNeGN6K3c1aC9FYnNaNFJGNzBtZUZPaUw4UHFr?= =?utf-8?B?MEVSck1xdkw1QmdMd2syeW50bVNRNVZCeXBXRXpSemlOQ3ZpZFd2RVRwSmFx?= =?utf-8?B?eEpna2E2cU1UcnBCMkJpbTYwQkVtcHVNbE43L0tQZTRrQjhlQXorQXEzQ0V6?= =?utf-8?B?MVZxeUVlUm9QNUh6bFY4NGpRdUluS1lFdm53cm1rRFV4cG91elZzUEpQbVZp?= =?utf-8?B?WUtPZ2x1eWZncGt4QVMzY2t5alprWCtiR3ZoL1ZBYjhvdTF2WmVDRkkvS0Vs?= =?utf-8?B?UkVsVC9QdTNmd3ZIcm9NRXJDclFUY2V6dGlTQWY3anowSzRjN0h5b2c0OTds?= =?utf-8?B?M1hTRTVLYm8rQ0VkOEV2ekJMcGlZWEV3T3dtbXNBK3gvKy9lRmhvR3Bna0xm?= =?utf-8?B?dm9GRzBsU2tKV0JXOW9DU2toTGYxek8wZ01oWS9qYVFmTUZoaGJ5MXFSZWhz?= =?utf-8?B?cWsvUGVKYTZmRmRzRU9wbDhyQThIRGFoVTE5R1VvQUJ6ajBnQ01xSlVCVkhW?= =?utf-8?B?WnZJNWZHZ1E3aVBlUS9GODJMWm1qM0hOWmNxcS9BdlZiUHNtZkkvQno1Kzda?= =?utf-8?B?VTBMMC9xb1VCS0tFL2hqSnJ6MEdVWXgwUWh2V0pOVFlrd1lSMHJ0cVNEcFF4?= =?utf-8?B?NnNzSWR1UUU0L0VNY2FEZlRySFE5aFFZMGh2OXhseXFiakJLakwzeUVxRy9W?= =?utf-8?B?TU9zTG1oTXh5Wm95cUo4bGwrRUhrbHhLb3hvK280SWZrNjRGcjR6R1k1Qy92?= =?utf-8?B?ZkloNjN3M2NJWW0xMkROc0wrVnowdUF6TExNR3FucE4vYkI2N2U5ZXMyMmgx?= =?utf-8?B?YUpQdVQ1QnBWODJZenMzNXBZaXczK2p1YzEvNzlPYkx4RnhxUDduYjJ5YlR2?= =?utf-8?B?R2d4OHRNKzkvYk9KMTZJRUZmbUZnSlJxMG0xbDRhOFJzU0hSUDVLWTl5eGNz?= =?utf-8?B?bmlLTmZEdTRyakZKMmJhMFVjWG1nRjJkRjV5NjJQVlNaOVJldW54eWRxWVVj?= =?utf-8?B?UWw2cERMejNPdUFvUHg3Q1FTTXQ3RWpQLzd5a3RwZUgyS2FQM09kY0R4SVk5?= =?utf-8?B?bXF6QXpLV2FIUHhsOXBGNUFkY1VTQWVYZE1EcFI3dDMzemg3dFY5UUY4WVpw?= =?utf-8?B?L00xdEVvMmJhaWdHSXlsTXYySXJjbEZTL2tNeHIrdzVlbFhYdTJMQnhpOVJp?= =?utf-8?B?ejlRc0FPZ2RISFdFOXJ3Ky9nc2pKVlRoRFRJZU9kdGFRNk1keDMyNGEwSjg1?= =?utf-8?B?a3lreGU5Y2p2eXk4bmJMUkF2dG8xbzJXKzU5R09EeDVuSjh0dThEb1FPdHh1?= =?utf-8?B?NjNTSGcrL3VGL0lrZmI4dXpobnkvL0QvY0U0bXFxRVFoNkdzWktsNFdNTEFp?= =?utf-8?B?dEpVTlhxaGhWU204dUt1UmNkOTZjWk1URDdXNGtMb2REK1l5cUNnM1ZxVUNQ?= =?utf-8?B?SzJ5dXM1MTBxREsrbzIxRVQ0WUkreU8xdml3Q1l4Z0VES3U5N1AyN25KdHdz?= =?utf-8?B?a2YwdnJQVTN2VkMya0NxSUJxYUhOQlMrUnNqeVczTDFqa3RTV3F6L0tUQ1pN?= =?utf-8?B?QXZ2UmUxNFZOY0VGYjRXSVNtUlhFOVNjc1RiM2h5V1d4UnNTb2xTaVlyZlVx?= =?utf-8?B?NnpDTlFsOVhDTm94bFUwbzEzQ3lNY25PQjZzRmsyenBZQ2RQZXBvTk1pOUxh?= =?utf-8?B?MTNwb3BYMFFpTXRuMVFmWFl1Mmo2Q1RrUzdyQUUyY0hib1NFcC9kNVJHSnpO?= =?utf-8?B?MVp2eGFTWHB5VFFQZXJla0x6L0I5K1BtZkZOMUNPRFdVQ1l6Umd1ZU5yQllJ?= =?utf-8?B?bnBWS2lBRnpnZWpPZ0pjQWUrUzkyUVBGWXJtdGFHM3R5Ym5Ndy9GajBaRUZh?= =?utf-8?B?ZHpyY3FidDFtS08xQWhuUng3TE5rclZLSGd2dWp0T0JOWGJXOEQwMzcvd1RS?= =?utf-8?B?Z0t2Rk5QakM2Z2orZmtCcUd0bWF4d3g0eFFhOGhEUVNzUGlCeC9wbm1mVEE0?= =?utf-8?Q?84oZh9xftyGpzMnhJ8WwCD4=3D?= Content-ID: <195026D8784EC34A95F0884C0DC49FBE@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5148d5d6-cad2-4984-a51e-08d9cf28297d X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2022 02:16:05.0282 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vGpt4KqxTkpWO0AxdwDFyaDG8G0AKlj8t2YUJ30ZiQhTL6sc0Z9uM6eyUrbneAhCFgbAF2aJbnILDdKOm9p5og== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3636 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2] avfilter/vpp_qsv: fix regression on older api versions (e.g. 1.11) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "softworkz@hotmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 2022-01-02 at 03:41 +0000, ffmpegagent wrote: > From: softworkz > > Commit 8b83dad82512a6948b63408f964463b063ad24c9 introduced a > regression in a way that scaling via vpp_qsv doesn't work any longer > for devices with an MSDK runtime version lower than 1.19. This is true > for older CPUs which are stuck at 1.11. > The commit added checks for the compile-sdk version but it didn't test > for the runtime version. > > Signed-off-by: softworkz > --- > avfilter/vpp_qsv: fix regression on older api versions (e.g. 1.11) > > Fix a recently introduced regression when using QSV VPP. > > v2: Fixed commit message wrapping > > Published-As: > https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-15%2Fsoftworkz%2Fqsv_vpp_regression-v2 > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging- > 15/softworkz/qsv_vpp_regression-v2 > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/15 > > Range-diff vs v1: > > 1: eea966f702 ! 1: ccede9d840 avfilter/vpp_qsv: fix regression on older api > versions (e.g. 1.11) > @@ Metadata > ## Commit message ## > avfilter/vpp_qsv: fix regression on older api versions (e.g. 1.11) > > - Commit 8b83dad82512a6948b63408f964463b063ad24c9 introduced a > regression in a way > - that scaling via vpp_qsv didn't work any longer for devices with an > MSDK runtime > - version lower than 1.19. This is true for older CPUs which are stuck > at 1.11. > - The commit added checks for the compile-sdk version but it didn't > test for the > - runtime version. > + Commit 8b83dad82512a6948b63408f964463b063ad24c9 introduced a > + regression in a way that scaling via vpp_qsv doesn't work any longer > + for devices with an MSDK runtime version lower than 1.19. This is > true > + for older CPUs which are stuck at 1.11. > + The commit added checks for the compile-sdk version but it didn't > test > + for the runtime version. > > Signed-off-by: softworkz > > > > libavfilter/vf_vpp_qsv.c | 32 ++++++++++++++++++++------------ > 1 file changed, 20 insertions(+), 12 deletions(-) > > diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c > index ab58a5777e..09590157e3 100644 > --- a/libavfilter/vf_vpp_qsv.c > +++ b/libavfilter/vf_vpp_qsv.c > @@ -139,8 +139,9 @@ static const AVOption options[] = { > { "height", "Output video height", OFFSET(oh), AV_OPT_TYPE_STRING, { > .str="w*ch/cw" }, 0, 255, .flags = FLAGS }, > { "format", "Output pixel format", OFFSET(output_format_str), > AV_OPT_TYPE_STRING, { .str = "same" }, .flags = FLAGS }, > { "async_depth", "Internal parallelization depth, the higher the value > the higher the latency.", OFFSET(async_depth), AV_OPT_TYPE_INT, { .i64 = 0 }, > 0, INT_MAX, .flags = FLAGS }, > +#ifdef QSV_HAVE_SCALING_CONFIG > { "scale_mode", "scale mode: 0=auto, 1=low power, 2=high quality", > OFFSET(scale_mode), AV_OPT_TYPE_INT, { .i64 = MFX_SCALING_MODE_DEFAULT }, > MFX_SCALING_MODE_DEFAULT, MFX_SCALING_MODE_QUALITY, .flags = FLAGS, "scale > mode" }, > - > +#endif > { NULL } > }; > > @@ -304,6 +305,7 @@ static int config_output(AVFilterLink *outlink) > QSVVPPParam param = { NULL }; > QSVVPPCrop crop = { 0 }; > mfxExtBuffer *ext_buf[ENH_FILTERS_COUNT]; > + mfxVersion mfx_version; > AVFilterLink *inlink = ctx->inputs[0]; > enum AVPixelFormat in_format; > > @@ -317,6 +319,11 @@ static int config_output(AVFilterLink *outlink) > param.ext_buf = ext_buf; > param.async_depth = vpp->async_depth; > > + if (MFXQueryVersion(vpp->qsv->session, &mfx_version) < 0) { > + av_log(ctx, AV_LOG_ERROR, "Failed to query mfx version.\n"); > + return AVERROR(EINVAL); > + } > + > if (inlink->format == AV_PIX_FMT_QSV) { > if (!inlink->hw_frames_ctx || !inlink->hw_frames_ctx->data) > return AVERROR(EINVAL); > @@ -467,19 +474,20 @@ static int config_output(AVFilterLink *outlink) > #endif > } > > - if (inlink->w != outlink->w || inlink->h != outlink->h) { > #ifdef QSV_HAVE_SCALING_CONFIG > - memset(&vpp->scale_conf, 0, sizeof(mfxExtVPPScaling)); > - vpp->scale_conf.Header.BufferId = MFX_EXTBUFF_VPP_SCALING; > - vpp->scale_conf.Header.BufferSz = sizeof(mfxExtVPPScaling); > - vpp->scale_conf.ScalingMode = vpp->scale_mode; > - > - param.ext_buf[param.num_ext_buf++] = (mfxExtBuffer*)&vpp->scale_conf; > -#else > - av_log(ctx, AV_LOG_WARNING, "The QSV VPP Scale option is " > - "not supported with this MSDK version.\n"); > -#endif > + if (inlink->w != outlink->w || inlink->h != outlink->h) { > + if (QSV_RUNTIME_VERSION_ATLEAST(mfx_version, 1, 19)) { > + memset(&vpp->scale_conf, 0, sizeof(mfxExtVPPScaling)); > + vpp->scale_conf.Header.BufferId = MFX_EXTBUFF_VPP_SCALING; > + vpp->scale_conf.Header.BufferSz = sizeof(mfxExtVPPScaling); > + vpp->scale_conf.ScalingMode = vpp->scale_mode; > + > + param.ext_buf[param.num_ext_buf++] = (mfxExtBuffer*)&vpp- > >scale_conf; > + } else > + av_log(ctx, AV_LOG_WARNING, "The QSV VPP Scale option is " > + "not supported with this MSDK version.\n"); > } > +#endif > > if (vpp->use_frc || vpp->use_crop || vpp->deinterlace || vpp->denoise || > vpp->detail || vpp->procamp || vpp->rotate || vpp->hflip || LGTM. I wonder whether you installed libmfx and msdk runtime from different packages, so the mfx version is higher than the runtime version? Thanks Haihao > > base-commit: d6b2357eddca392ee137cb2a92ff178a0a7d0cce _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".