From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8403344233 for ; Wed, 2 Nov 2022 01:32:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8BBD568BE3E; Wed, 2 Nov 2022 03:32:30 +0200 (EET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 02A7D68BD2B for ; Wed, 2 Nov 2022 03:32:23 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667352749; x=1698888749; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=kk8cF0cgcOZMXIShmB1rIenk5jXvOpEZqt28zsuX5kk=; b=ngZBY+X0Z10H4dw6rTeO9aX9wz8C9jm/aUsdwz0ZiBjFzME4ycMjMbJ4 wzL/VQfjwl4bR3m+aKQKEkz9AS7tyBUQsclzFQDaXc2UR6qtVIWcgY8lm Mjx5inOT3je21NhTiqg6pRD7tfZ4ILfv0dI7yMa3L1uivW690PhWuMwoK K6r6qysKXX1/MJqEHEdCJQZa6guZib20SuDP7WUJA/RBKFr0AeUE2mo2W TUwLYkIdcPmgxXvqIdBlYjs0ipXQccq81gZtD8W8oeD8gO6Zcw6DbWWL9 +eRsIxiWjuyuRf+AbCFIT7nF2RZR4eogMXwM1MQAiOrzjFZ+9tVr5UzKj g==; X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="289673038" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="289673038" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2022 18:32:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="612054185" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="612054185" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 01 Nov 2022 18:32:01 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 18:32:01 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 1 Nov 2022 18:32:01 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 1 Nov 2022 18:32:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VEIadEmhOpXmdhRH3Att0QkcX65ouwWFuZAYDCJyT1LHdD1uYZSZJY5vi9rs05HgebaCxo6VBjgrREXzwWwwxsgmUeKqtmimHZEkP9QuQWb35apSKf7Bf8m/Sa6TCZNOx59JOb6wMEfT2QU6JNrNhq/I0/GXl8l1KQE6YQJl5A6ZyL8Tots2JwkT2tyVB/lY8/XOTe1jxaXfhM52kFtP/ce0B7XfMeEYmp2ffmR4DDafvsa8PnlQYcEfVb46sexo/xg7MyCdF3pp6lnBHwU/S3HyM8DfPQNMGJafv8QSMGT5yzizOT366DVlpoU3N0IH3iddSDUIqR2NuEiIDbmDuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kk8cF0cgcOZMXIShmB1rIenk5jXvOpEZqt28zsuX5kk=; b=hufuInm75ACDrwDbG5zuWVbSdBWUWNfZ7y2+h8Mda0HyLR2FBqSzPaNJtAck1ER5JH9d217baT5jmRXBdD7nc8DR+CW/dPX20hMsHOuK3H8OV1KLi/hLWzD7OGN6lNNUUuHltQGsCCl2LdgHTy1IGyoSlMM8ODk8AY/2eMr3AGNEwkhd56cmdxnR6oSU8w4WdcH4SIpRnXR48I42dpUw2n9gdwc+ib3RtGFieVcjdcMDj5kFKKH5EDCqn4S7bJp9+v71TJ5c6enTXcTVQVkOY1Wm64UukEHbyExR0rqKLbqzNoCKbIUvLhlkDMEb7R5rY3k9ZxLJhfYnhanNVJoHkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by CH3PR11MB7180.namprd11.prod.outlook.com (2603:10b6:610:148::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Wed, 2 Nov 2022 01:31:58 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::684d:f7e7:6cb8:d10a]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::684d:f7e7:6cb8:d10a%3]) with mapi id 15.20.5769.019; Wed, 2 Nov 2022 01:31:58 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" , "ruijing.dong@amd.com" Thread-Topic: [PATCH] avcodec/av1_vaapi: fixed a decoding corruption issue Thread-Index: AQHY7ZpBBdDQ8LomRk+LISMjSTDFw64q2eqA Date: Wed, 2 Nov 2022 01:31:58 +0000 Message-ID: <56669686584ae7c2b9637cc0e4db54749bf4a6da.camel@intel.com> References: <20221101023218.667352-1-ruijing.dong@amd.com> In-Reply-To: <20221101023218.667352-1-ruijing.dong@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5030:EE_|CH3PR11MB7180:EE_ x-ms-office365-filtering-correlation-id: e3b62c42-c299-4234-843c-08dabc7208bc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tF1ibVM0+6SgKErAtvzYYpFZGdYTLmPZN9+WpntzIGccJKETEHiHGEp7XFGQgSChm+Z5xasItDKmYuOXId5ZlWyyvUOc6m3i6V1OdroUdUXhd/M2jAwKgkSAVxfzyNZWaT3Lt6K40EgqyonzPYZlL2bSAwswJyNcSEHnppXHILztn+TBMORVJw78YoWFqmXYGEXPLLv2DCdCi6ERcMe8FgASMOxcP3vW8S1j6FQ/XKNWglb/H6Ju0ApOHSc21/bpUv5koWtCw6+fgaVdCbBo/bE3BZYP/Hrr5U19OSjPZSaq2Fg9H16JC2mlCfcptPOCFYyNqlpz4mBQez/IEkkzRVZoRepPjfqgzsirKbTbNqsE5I7jcBVW2+gyjUpFUFHG+bDIOs/JNrHvHEnAeP4Xr8M4P76QRm598g004G4tc3DOuDfdpUjua2NfbzVUIwnBaulvm8uA62sM1n2LzHkSUX+YgKIFtyInDHKZLOtMd/NFODMtCh7oZ+fF64ztvaGsO/XTCm9y+mIPlu7uQAOQR56dBjMnzyI4psrw7zBjP6jxzRFngFvKnpQvrQWwTeA4PeJ3pdLM5fluij1nwSeX9KkxC8DQi7ldJ048Jaw2TgOTglchiPn2QGfeNcdQTVXMzigVTtGixepez3yrgt3/foODFQNd0ZH25w9+05+rVVw/QlGNGSwyI3AgbxEt8Bsmm7NN3NFHHMXEPHOwZSFoSrwYWjLJdNXlOQQMoD9luXbZopgZvywoWIuAbPVULsvBbMMoNgeEPRHYdqQB/m7msCSytX8728sIyIOcfifRABM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(39860400002)(376002)(136003)(346002)(451199015)(478600001)(38070700005)(36756003)(110136005)(122000001)(6506007)(2906002)(41300700001)(4001150100001)(186003)(8936002)(316002)(86362001)(966005)(38100700002)(2616005)(26005)(6512007)(6486002)(8676002)(5660300002)(64756008)(66946007)(66476007)(71200400001)(66446008)(66556008)(91956017)(83380400001)(82960400001)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OE81U1NLYk1QWFkyTmFXa1JyeUtjZHFJK0IxWExGeVU4bHNBVVU0RVlWQ1o1?= =?utf-8?B?c2pOcm1tdWwrb3BCdGJNNm1UWkpORUpCdjBmMjFPK3NLMFNnWldEemlQZTBD?= =?utf-8?B?MkF1TklNZGQwN1RGVE43MlZ5SlI0N2FqLzVkbzFseUg0emRKWlNQS2NjZWNx?= =?utf-8?B?aE1aV1lQN0JOUk9ZeWEvZkl4dlVlUFpUaVA2UDNyOXJ3ZnVEM0theVNuNzl5?= =?utf-8?B?TXU0Y01NWE5QYVVZd2VJeXNHQnRGYUJqNVpUZnBIeTZ3WkpscFl3YWtaUkpp?= =?utf-8?B?TWN3R3VlbTc2NmNWSG9NT2R1ZFdoc2NzcU9EVFFETlh3V21LVlNVMkhtaUhE?= =?utf-8?B?anNXM2tERktqOUt2V3M5Zk1IVE5lSzllSnhURG54UGQrS0EwZDdEc0dIM3I2?= =?utf-8?B?RmZNdjRBcUIxV1RTNHpLWUVHbEcrNnFaaU5tWlkzSE9Xay9lMmkyK0kzNEl5?= =?utf-8?B?YjBiQ1c1VVk5VEh1R3JPTWU1eWRWeWFQQWNBdnlnN0NONG9yRjFOV3RvRm5Q?= =?utf-8?B?bkt2TndKVnovSDBFblpibE1taTFnWEdsNWNEdnBSRG94c0FDNWRaaWZvR2Zo?= =?utf-8?B?TUVYVXZPYlpLK0xGNFdJd3FOME9VWU5JWks0elFWaENNdWdpRHg0bG5NVURU?= =?utf-8?B?YzVGUW5wZStSQk5xaHROTHBHc2dGdVJnZ1grMXYrNDcya2NaS3FyUkgwdDJG?= =?utf-8?B?OGEzL3dQS05ibnhHQ054Mk1oOW5rTkJjTUdXcjhObkxURXM0OHd5Z0pONHF1?= =?utf-8?B?N05Sd1ZSR0xQTnU3KzZHTmZvTHYxY0VRSksyU3lXbXhmVktwMVYxcVNBeTlw?= =?utf-8?B?RTRPUExBY0lONTRIR2dveFJiWG9HSk5rWmRqbWNKWlhKNU4zRlBuNFBYNkQ2?= =?utf-8?B?akIzNEZvVSs3N2g1SVJ2UXNXaDczQnZNWlUyVHJJU29RYUJHeG1jMFdtZDlW?= =?utf-8?B?WW03RnBWKzA5TEJabm9qRUVjZklOUXIwUVRYWnhIMnEvV0RwMDIwUkFJbmY0?= =?utf-8?B?NDJreU5TcDk4TG00SzNoRzdoVFFiNlNzMm5TNG9NWXA0N0ltUGtvUTRDU2tm?= =?utf-8?B?Q3k3L1VEN1ZzY0xNbTF3aCsvVVdxY1IyalpBUm5iQUREVkpFYndZQzAyeUxR?= =?utf-8?B?TDZmM2VuUTBlTjIrckR1UkZTMDRFNEN1RlBoQTF1bHhmYzNUTzgwajRWeGlL?= =?utf-8?B?RXQ3ZStRSkFPSmZQVzVuSG01UUhQd1hzTGNNT0lWaHFmQzgvNVh1NWM1R0JR?= =?utf-8?B?dUFDekNwUnFaWmZsQmx4eDlYbno2RWpncnNtZ1RZYjI0bFUzQitCU3hsK0g1?= =?utf-8?B?UFRDTVRVaHlYUUhmZUtMTUl0MU45bnZHOEF4R09YRU03cW1MNUtnSzlvREx4?= =?utf-8?B?ODVhdW9sS2pmZGx1OTcrb1BJSmJwYm5PaWJvNFNQell2anhVM0xQa1RlRWVB?= =?utf-8?B?c3M4bGJHOXZjWDhNRlVNY1kwQnhRZTUyVXVXNmtNbGlodzRtTm1XakhqNFhy?= =?utf-8?B?aDhubExGNDh1NkNEcUI5TE4zN2ZmQTh3dkpkbnRUeER5UmUxbGFrZVdlc0pp?= =?utf-8?B?Y204VjJlV0lteDcxb092SWxsbGZMVFByZ3R3czN3REUyTFlyVE5BaVQ2aW1j?= =?utf-8?B?RXEwNThidkFoMGtKNDkxb2g2WnBYcmxnbDkyV21vSVF6L3BWL1ZrSlhnc1NK?= =?utf-8?B?ajdOa25xcUplV0h5bXlkSkQ1Y0grdzVjNEVQMmc2NitWQ1J6Z1UxZk11TGlB?= =?utf-8?B?Z0ZOL3l4SVVXVk0xL1o1UXJ0d0NHOEYrZS9FQkxNbFJYbUtFc0Nwc0FzRmM5?= =?utf-8?B?VkJvaVNIZDltczhubS9NMEJVMmpVZDN3ZFpWQWVENmczbGk2SjBUeWs1bkVK?= =?utf-8?B?RHcycmF2eFIrcUNhQW1CN1kwNGtJcGZtK3QrRWQ0VzFVdjBoSUVHalUvSlJo?= =?utf-8?B?MFl1TlB2OWg2cXdNMjRUeStMckFpUzgrZW1GeGh5bDF5THNLbndzUWlxSUcy?= =?utf-8?B?SlRlY1BSR1VWc3dRbXJ2cVdrTWRRVzRHeDA2K2hadnlPSURHQUhoVEtoN2lW?= =?utf-8?B?UFZwU25lV2sybXJjQUFvVHhxYkNuUHJnaE5KUHNpZ0g2NUNod2xUZEFYWkJt?= =?utf-8?B?MWZ0dzR2eGxrblFIdWEybGhQYUtpRzV6S0NsMlFWVUdaYm1zRjA2Z0pDL2VE?= =?utf-8?B?U0E9PQ==?= Content-ID: <5862842A37E9FA46A43A41D896053E78@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3b62c42-c299-4234-843c-08dabc7208bc X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 01:31:58.4587 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S5+XJljsVUobbtukXskX++GKrUXi8nEGG7FVyRD8Nd4XwumaivJX9RIh9xRBUhGGfd4rxFXc1tgIlr42GND8sA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7180 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] avcodec/av1_vaapi: fixed a decoding corruption issue X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-10-31 at 22:32 -0400, Ruijing Dong wrote: > v2: update commit message Updates shouldn't appear in commit message. You can use "--annotate" of git send-email, then add your updates below "---" after sign-off. Thus the patch can be applied without updates. For example: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200909033956.27248-1-fei.w.wang@intel.com/ BTW, please indicate your patch version in the title. You should use '- -subject-prefix="PATCH v3"' in next time. > > In av1_spec.pdf page 38/669, there is a sentence below: > > if ( frame_type == KEY_FRAME && show_frame ) { > for ( i = 0; i < NUM_REF_FRAMES; i++) { > RefValid[ i ] = 0 > ...... > } > ...... > } > > This shows that the condition of invalidating current > DPB frames should be the coming frame_type is KEY_FRAME plus > show_frame is equal to 1. Otherwise, some of the frames > in sequence after KEY_FRAME still refer to the reference frames > before KEY_FRAME, and if these before KEY_FRAME reference > frames were invalidated, these frames could not find their > reference frames, and it could cause image corruption. > > Mesa fix is in > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19386 Don't need to reserve blank space at the beginning of each line. Thanks Fei > > cc: Fei Wang > Signed-off-by: Ruijing Dong > --- > libavcodec/vaapi_av1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vaapi_av1.c b/libavcodec/vaapi_av1.c > index 63374c31c9..d0339b2705 100644 > --- a/libavcodec/vaapi_av1.c > +++ b/libavcodec/vaapi_av1.c > @@ -274,7 +274,7 @@ static int vaapi_av1_start_frame(AVCodecContext > *avctx, > }; > > for (int i = 0; i < AV1_NUM_REF_FRAMES; i++) { > - if (pic_param.pic_info_fields.bits.frame_type == > AV1_FRAME_KEY) > + if (pic_param.pic_info_fields.bits.frame_type == > AV1_FRAME_KEY && frame_header->show_frame) > pic_param.ref_frame_map[i] = VA_INVALID_ID; > else > pic_param.ref_frame_map[i] = ctx->ref_tab[i].valid ? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".