From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] lavc/vvc: Remove left shifts of negative values
Date: Tue, 23 Jan 2024 11:17:57 -0300
Message-ID: <565ea856-5d98-42bd-bad0-92e7fdb04db5@gmail.com> (raw)
In-Reply-To: <20240120145104.22141-1-post@frankplowman.com>
On 1/20/2024 11:51 AM, post@frankplowman.com wrote:
> From: Frank Plowman <post@frankplowman.com>
>
> VVC specifies << as arithmetic left shift, i.e. x << y is equivalent to
> x * pow2(y). C's << on the other hand has UB if x is negative. This
> patch removes all UB resulting from this, mostly by replacing x << y
> with x * (1 << y), but there are also a couple places where the OOP was
> changed instead.
>
> Signed-off-by: Frank Plowman <post@frankplowman.com>
> ---
> libavcodec/vvc/vvc_ctu.c | 4 +--
> libavcodec/vvc/vvc_filter.c | 4 +--
> libavcodec/vvc/vvc_inter.c | 24 +++++++--------
> libavcodec/vvc/vvc_inter_template.c | 4 +--
> libavcodec/vvc/vvc_mvs.c | 46 ++++++++++++++---------------
> 5 files changed, 41 insertions(+), 41 deletions(-)
Applied, thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-01-23 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 14:51 post
2024-01-23 14:17 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565ea856-5d98-42bd-bad0-92e7fdb04db5@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git