From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2712042FEC for ; Thu, 13 Jan 2022 04:09:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 926F568BBCA; Thu, 13 Jan 2022 06:09:05 +0200 (EET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 044B968AC71 for ; Thu, 13 Jan 2022 06:08:58 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642046944; x=1673582944; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=l1Zrh5aiV4nd2suHiZjUgfOELtZjemywEmVB8LLV5og=; b=myNhqWrl/UtiVE9J6588xCf2QxPRdwYwjVOp/+gV1//kYpnolmR1x6Zr 1T08Hjhr2ANlEUNn71jNkMhb6Yj1h9n7IyvL+BbLdAgmBvPCWRwbPF2zm Hr6nBZ0lngqDFUBH2CKg29z4O341AI8LDcGfqh7VLM5fPJiUy0cIrJNUH sy0nnwfAFnUaxyOazWCIY1jq5fquwj4Egx8SQQa3GB4nKv+jK59FCgizT yAua4pdr3+8jufM+0SaC4Ze7Gwn4gd/89oIRr160/jMbAi4Q5hd7vtRP+ UbkhlC2G49YcaOsrjQiuGHq4mOsaGqhpMF+YgwUaZTgLUHtjx61gZkhUl w==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="330275365" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="330275365" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 20:08:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="670387506" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga001.fm.intel.com with ESMTP; 12 Jan 2022 20:08:57 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 20:08:56 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 20:08:56 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 20:08:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QP1MSHJLYzf08Lv7hpPxXNvFW4LtIk4zH3zFoeM9EW0Kba7RMomj9T2TcBIpgGBQg3Et1IFaVBzckWuLTmCsFa02qjhKdj/XLbaE0Dsqr3rvL0rn85zd4UE4JVsgp8RYjQzv5nbT4V2kUN1PzCP2wK7190gXBvDFecKSBgIl4kLYdRaqHEePczMkbMOF6VWj5oa8HVo9Pcy1bg4Wd8gU2Znx/ZnW5IMP55uJzG2rmMYDCdCSiuxrozzCp5z3ym1pb3FTMCUjk82UZtgE3EaHf5TlEAGTSzvcX9pnZtGJgf5C/9XMtUte6AREe8SqY3r/IZFMw3/jqiCB1tn/AwOqpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l1Zrh5aiV4nd2suHiZjUgfOELtZjemywEmVB8LLV5og=; b=D5txXmlQ1E3HRdWSk7cmT7KSrf9OfrSpYnH27XeogovBsF3hC8BIzhooafabFa1HkWDoRsHNBSqN9hMR45u91GuaEBN+fGKdtBUiKzq4qdCgusjBIjAVgHSFxlwpyRMzcYF7+xZH++GxJNtHxMAdqVWAScVOni1SDpPQo0ygCIK098Kgmc0yW/BhqCHBN+yQhA/umioSq/ceYcFfzne/6Lje36zsEeIZ8CAJHIYAasfN397LCJ/+KC5xzWyhw1dVTSogep2WBLP41PNkH1i8YfWqKpJ3PHEK6g9n7nH7gNapX122RPGk3opRq5arw0g2WFRDzE+/7dFyDjSPyK1ZKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN8PR11MB3794.namprd11.prod.outlook.com (2603:10b6:408:8f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Thu, 13 Jan 2022 04:08:55 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%6]) with mapi id 15.20.4867.012; Thu, 13 Jan 2022 04:08:55 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH V2] libavcodec/qsvenc: Add DisableDeblockingIdc support to qsv Thread-Index: AQHYB3WHkaCGsl55kEWEG4fXB2WED6xgV6MA Date: Thu, 13 Jan 2022 04:08:55 +0000 Message-ID: <5654098ef3c0b196c981872ddb789e27c39354ed.camel@intel.com> References: <20220112052850.1147160-1-wenbin.chen@intel.com> In-Reply-To: <20220112052850.1147160-1-wenbin.chen@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: add25a3d-1405-4eb8-0643-08d9d64a6ab7 x-ms-traffictypediagnostic: BN8PR11MB3794:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TWjin8rJzdgVjq1iGnd6ZaoeJo5oKA/R5i+C9OeSZkCx6vg04J3moZwaX8upN46f/iIwdpWGV4pegQ8EkXMUdpCFEenzbXnHx2zdkfMSdjrym/SYnsrq/VB1JqYFgbkDmHguQ/DcRjShlDOmqDFDYtVBa0fOe4kENttwKRg01nt8uRehmpYSsUFOx3vkvXorRpN7yHpQXkg5xqQp6dd4J7OYuIk/6SCDRhNrIyJP35QZzgYcNwB+pVDrio5hCiTnyQMQGUpoxm4GXfL7lYNgGopZF62a6iw3/CAt5BXcH/RatPpvmHsxfinKXZujfs+mjJZU+dHMn/6yEMcLnA2TVN5/jcbG3Tvfet+IDWJRYiY0RYJ4BW4CakzVEg3z8Mo/R9ea/6DC33mLN9tjoBisFl9ig9ujDatDu0nM6WRV5H6xTg5UgIi/5xQfsXhVCSMfekgmdxRfV7DFDRGkOff2QyZuuXnZpLrtE/jn6vttUjYe8r/7LcwYqtCb+MHo4G1zw68ncJimLXbHUlEmRtXR4r10E2HtqrfY5K4ofTaNOBii+l17KrUzMmKTt1Wht+utzRtM7SQtU81ZBOQekR+Swks7xc+LzNPYKM0GBNlOiduaTvICzquQPbQEH23KaH9OCnPwib93NcR3kskMD5f87e+nirvbAM7Wxpej+fWpDPjjkD5tfgocEEqMivorb8NnzoB8Rirtvwnbs2+vjhR8nhXQP6Eq0MHlQsno+9HQ/InbO24z3JuUiGffHH4uUZyrOSELaInz2i2CN4eau1P37BxRFybmp//pt19ZAAfWigz3RBlubyzcJTOu6aL1ptvV x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(76116006)(91956017)(8936002)(26005)(38100700002)(122000001)(66946007)(186003)(71200400001)(66556008)(66476007)(83380400001)(316002)(5660300002)(6512007)(2906002)(6506007)(6486002)(8676002)(36756003)(82960400001)(966005)(38070700005)(86362001)(508600001)(6916009)(2616005)(66446008)(64756008)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RFFtUHdITEhyVURJQ1VQa0dzK2MwNktzRnE1cys5UThkK1JyMWg3bDVXZ254?= =?utf-8?B?SlM1U0dPYVJCNTlPYTRNS0NreGUrT0tOMFAvSWhkTFN5L3VBa0RoMWhGejMv?= =?utf-8?B?eWRsZmxueFk3TkRFblRGQjRnZktvUWYwSHJlQ1RxaFJ2T1Evamo1ang3M2xO?= =?utf-8?B?MGtBNzR2UWhjWWlGVkFZY1h5Uk1zd1U0eXljblpocitXNitqb3pMR05oa2F2?= =?utf-8?B?NzJGU21HR21DeDBGcmtwcjgrQTM4Yk5pek9QUmlxKyt0QUY0UXJKQm9FSkRw?= =?utf-8?B?ZXlmQVlaUlc5Qkw0OCtKZW5xbkNxSmdQbCtZdHVBcWNhMDcxTXZSaFNiNHZo?= =?utf-8?B?VmFtbldxMGd0SDdlV2F2OS9OZnpZdmFFM3FaYTFjZHF0R1FMMUtKUUR6ZEY1?= =?utf-8?B?dDRQNEQyVGxIUFkvN3VoeEgwdWlyL21SeUExS0Zuby8yMU1oVUQ0TzNMNVBV?= =?utf-8?B?NURWbk5zaTZJTFJaS0RlTWllc0ZmM3JCMWtZUUJ6bXpnY2R5Mm55dWthd1M5?= =?utf-8?B?L01tVlJJMWZyRmtyK0tCTzUreEt6NDduUzl5TzJ2TDJhd2tCamw0WlE0eHU1?= =?utf-8?B?VEhjUlZYajgyVEFSL1FzN2NVUUhqcElOVDczNlZSVUJtNldYZXo4bjkyQ09F?= =?utf-8?B?d2grK1NJVk9RSHhuR3AwUjhNMUgxS0RQMjJxTTJ2QW1TWW8xaGhmMnRWaEN3?= =?utf-8?B?ZUVOdmZ1T1FpZXp0Z25xTUNrZjVWd29DWUpLOE4wRzlDQWpjZTJmamZlZnR4?= =?utf-8?B?N1UrZGxjV2RLY3lIVlh2ZE9wTTBUVXVFYm56dEpwN1A1ZTN3NFNrSjJlc1pY?= =?utf-8?B?NEtkNUVEeldTM2gzSHgzTGU5SlFnRmlqMFFXY3pvUlFiUitObzhxMU15eUpi?= =?utf-8?B?RWJEU3BlekxwQjQ1ejNVR2V4a1NKWHlTS29ONTl2VjZET0IzRmlNc0RIbk0y?= =?utf-8?B?cmYvY0RsazFwSXR3bTZlWlFvZkdRcEhiNktVaXh2NUFjVVdTSnpSTm53UWEy?= =?utf-8?B?dm1qUWUzeXZKSU0zMjZveE1kK21DUzJ0ZzEreC9uemdRNUY2VitNNkpVL0lp?= =?utf-8?B?cXFySFVrcHN4MlEwbjlEUlljV0F6amU4aytSMkxxNmxVVE85L2dEYVFGOFZn?= =?utf-8?B?Y3dkZFhMdDV4aFNtUngwTEp3QTJuR0cvM1lNN3A5RFAwbk5ad0h0S1ZXUCtH?= =?utf-8?B?azg5dWxmeTd6Q0RNK2dJditWVDZKOEk4cDVvYWo2U2xJM0NURUczTUc1eStk?= =?utf-8?B?SE9pR0hvaUpqQWMxa0lJRHpiZXNLQXhETzlpb2VsMlhWd25FYkk4Y283dzNi?= =?utf-8?B?cVZBUXdrM0U4Z0Vkd2tSMHBROEh1WmhmYXc0dXRoS0w4V05YejUvbUdYNGpX?= =?utf-8?B?ejNQUHdjNFFDYkdDNCtIRDJud1EyRHVnWkdtclFlTGswS3QzTVV5eEZTWHYz?= =?utf-8?B?WUJjMklaL2xxc3psb0FiUTd1cUJ4LzNWdldTSjAwUVBwdnorMkpoUFB0MmNG?= =?utf-8?B?WEJiWVJvSExzbExaeXBSQkJiRFp0amRmWnkvZ3UrUWdzMFlEbzdYU2Zwemxn?= =?utf-8?B?NW0vMXRiUVlkcDYxV3E5aDM4bXdsMTIzQmNueTlvaS9qUHF0NnZXWllTd251?= =?utf-8?B?UFlrcklnVTNsMVhyRjg3TzVZQVptS0NNeE03M0t5ajJZTUdWaGNRZ0dVWXQv?= =?utf-8?B?VUp3aGswTENxb1ZEZXNHU1NPSTNoL2V1NHl1RDV3cUxUalY2WHc1T2o1YklW?= =?utf-8?B?cjJjTVE4dDZSMWd1RWRBMXc3MnA1MXpTWEFkRlRnbjZuRVZrSUNLNHJycTUy?= =?utf-8?B?R0MwZHlLSjNrUnd2bTJIMTNST2d5UDdLeWN3K1A4cVp2dkJHYzBtd004dmp5?= =?utf-8?B?Tko4SzUxalE5RnRJMnV3ejFMLys4WGpSUjUxdzYvdzE3dUpONTlWWFField5?= =?utf-8?B?SmhkWEwzTDNUTHI4K2lucEVNN0hHc1VyZC9nUXVEOTRvTjk4S3F3alB5ZDI2?= =?utf-8?B?QktER1NtL1hGb2w4UUpUVmV4TzdIYXVxaHhZSE5WRFovQjZqZVUwMFlKQTBn?= =?utf-8?B?MXRqcDVMOTJWTkxlOU52VnpmZ3VTYTg5ckNzRytpeXh2OUQxVXpST2ltVFgw?= =?utf-8?B?eDlZbEhWYm96enBRVEpRMFoxblJFejBMNDQwVEFPYlA2QVcyL2t0TEwyNXZx?= =?utf-8?Q?Yuzb8CZ+CIeIw3BOYPCo+UM=3D?= Content-ID: <4457C229BF820548AB796BCC4A9DB98E@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: add25a3d-1405-4eb8-0643-08d9d64a6ab7 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 04:08:55.4689 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lYRVCXw2HDvPYTZmso+b8tazLte9hmIxdf4UghVTLbxwvixWkGLYw+ey9i9Oc92mzEFquSEE7yIt0gQZuxpIcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3794 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH V2] libavcodec/qsvenc: Add DisableDeblockingIdc support to qsv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 2022-01-12 at 13:28 +0800, Wenbin Chen wrote: > Add dblk_idc option to 264_qsv and hevc_qsv. Turining on this opion can > disable deblocking. > > Signed-off-by: Wenbin Chen > --- > doc/encoders.texi | 6 ++++++ > libavcodec/qsvenc.c | 8 ++++++++ > libavcodec/qsvenc.h | 3 +++ > 3 files changed, 17 insertions(+) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 68921fbd40..6fc94daa11 100644 > --- a/doc/encoders.texi > +++ b/doc/encoders.texi > @@ -3299,6 +3299,9 @@ This flag controls changing of frame type from B to P. > @item @var{b_strategy} > This option controls usage of B frames as reference. > > +@item @var{dblk_idc} > +This option disable deblocking. It has value in range 0~2. > + > @item @var{cavlc} > If set, CAVLC is used; if unset, CABAC is used for encoding. > > @@ -3391,6 +3394,9 @@ Enable rate distortion optimization. > @item @var{max_frame_size} > Maximum encoded frame size in bytes. > > +@item @var{dblk_idc} > +This option disable deblocking. It has value in range 0~2. > + > @item @var{idr_interval} > Distance (in I-frames) between IDR frames. > @table @samp > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index a13718652e..3a51d00ca9 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -346,6 +346,10 @@ static void dump_video_param(AVCodecContext *avctx, > QSVEncContext *q, > av_log(avctx, AV_LOG_VERBOSE, "FrameRateExtD: %"PRIu32"; FrameRateExtN: > %"PRIu32" \n", > info->FrameInfo.FrameRateExtD, info->FrameInfo.FrameRateExtN); > > +#if QSV_HAVE_DISABLEDEBLOCKIDC > + av_log(avctx, AV_LOG_VERBOSE, "DisableDeblockingIdc: %"PRIu32" \n", co2- > >DisableDeblockingIdc); > +#endif > + > } > > static void dump_video_vp9_param(AVCodecContext *avctx, QSVEncContext *q, > @@ -885,6 +889,10 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > q->extco2.ExtBRC = q->extbrc ? MFX_CODINGOPTION_ON : > MFX_CODINGOPTION_OFF; > if (q->max_frame_size >= 0) > q->extco2.MaxFrameSize = q->max_frame_size; > +#if QSV_HAVE_DISABLEDEBLOCKIDC > + if(q->dblk_idc >= 0) > + q->extco2.DisableDeblockingIdc = q->dblk_idc; > +#endif > > #if QSV_VERSION_ATLEAST(1, 9) > if (avctx->qmin >= 0 && avctx->qmax >= 0 && avctx->qmin > avctx- > >qmax) { > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > index 31516b8e55..aa49b35f07 100644 > --- a/libavcodec/qsvenc.h > +++ b/libavcodec/qsvenc.h > @@ -44,6 +44,7 @@ > > #define QSV_HAVE_TRELLIS QSV_VERSION_ATLEAST(1, 8) > #define QSV_HAVE_MAX_SLICE_SIZE QSV_VERSION_ATLEAST(1, 9) > +#define QSV_HAVE_DISABLEDEBLOCKIDC QSV_VERSION_ATLEAST(1, 9) > #define QSV_HAVE_BREF_TYPE QSV_VERSION_ATLEAST(1, 8) > > #define QSV_HAVE_LA QSV_VERSION_ATLEAST(1, 7) > @@ -97,6 +98,7 @@ > { "b_strategy", "Strategy to choose between I/P/B-frames", > OFFSET(qsv.b_strategy), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 1, VE > }, \ > { "forced_idr", "Forcing I frames as IDR > frames", OFFSET(qsv.forced_idr), AV_OPT_TYPE_BOOL,{ .i64 = > 0 }, 0, 1, VE }, \ > { "low_power", "enable low power mode(experimental: many limitations by mfx > version, BRC modes, etc.)", OFFSET(qsv.low_power), AV_OPT_TYPE_BOOL, { .i64 = > -1}, -1, 1, VE},\ > +{ "dblk_idc", "This option disable deblocking. It has value in range > 0~2.", OFFSET(qsv.dblk_idc), AV_OPT_TYPE_INT, { .i64 = -1 }, - > 1, 2, VE}, \ > > extern const AVCodecHWConfigInternal *const ff_qsv_enc_hw_configs[]; > > @@ -169,6 +171,7 @@ typedef struct QSVEncContext { > int rdo; > int max_frame_size; > int max_slice_size; > + int dblk_idc; > > int tile_cols; > int tile_rows; patchwork failed to apply this patch, see https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220112052850.1147160-1-wenbin.chen@intel.com/ Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".