On 17/06/2024 21:01, Lynne wrote:
> On 17/06/2024 09:35, Anton Khirnov wrote:
>> No tests?
> 
> Tests for this particular part are tricky. We still have the SBR issue 
> where we add a single sample of delay to the output, which the reference 
> samples and their decodings do not. Adding a test would mean modifying 
> the samples in a way where we would not be able to use them after fixing 
> this (in addition to all the other regular AAC samples with SBR we have 
> that would become irrelevant).
> 
> My plan is to fix this after this patch, as its a troublesome topic.

Additionally, we also don't correctly take into account encoder SBR 
delay signalled via MP4.