Re: [FFmpeg-devel] [PATCH 3/3] avutil/stereo3d: set a sane default value for AVRational fields

[James Almer <jamrial@gmail.com>]

On 6/18/2024 6:13 PM, Michael Niedermayer wrote:
> On Tue, Jun 18, 2024 at 04:20:34PM -0300, James Almer wrote:
>> Prevent potential divisions by 0 when using them immediately after allocation.
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>   libavutil/stereo3d.c | 14 +++++++++++++-
>>   1 file changed, 13 insertions(+), 1 deletion(-)
> 
> i must have applied the wrong patches locally but this fails to build
> 
> CC	libavutil/stereo3d.o
> libavutil/stereo3d.c: In function ‘get_defaults’:
> libavutil/stereo3d.c:31:47: error: incompatible types when assigning to type ‘int32_t’ {aka ‘int’} from type ‘AVRational’ {aka ‘struct AVRational’}

This sounds like you still have Derek's old version in your tree. He has 
since changed it and pushed a different one.

>     31 |     stereo->horizontal_disparity_adjustment = (AVRational) { 0, 1 };
>        |                                               ^
> make: *** [ffbuild/common.mak:81: libavutil/stereo3d.o] Error 1
> 
> thx
> 
> [...]
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".