From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C6F234ADFE for ; Mon, 24 Jun 2024 12:58:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E550B68D605; Mon, 24 Jun 2024 15:58:08 +0300 (EEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6CD5568D2E3 for ; Mon, 24 Jun 2024 15:58:02 +0300 (EEST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-7066c9741fbso1716133b3a.2 for ; Mon, 24 Jun 2024 05:58:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719233879; x=1719838679; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=FCEgbTcavNDddMXYhHdYZEcPaKdTXli9xkJUX/QJsO8=; b=ibbKmFE+QlAq4FdZWKNK/N1ETaE4PAHkQSgl9ICNyimL3DyYeS1aQfJHGGgnvveHR8 YC3O/p4yqFdUCRZaXPaQnw8QTn4gCYbMRTrxzXf45I0PjovoORuZSgRxgGkNcwJ8pJAw ruseGeVS5R/GbWR4IZRnW+ZApXCJkjI+gBP4w5WAf0l2OultasLpw7LMrPFHvzrHYfEJ x1btsqdlPT7Xz5qpc5lfmtG0Ek3+pgTnSNfYLYJBH+wxqG5eH+wMA8WHTglG2DwSJR8U hZaboXmuHwJmdkW/Q7XNzcUDw9fo4qmwEnQiMeExJ9GOlfd2YSetuL1RFibYbCEX0Kla 9Yvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719233879; x=1719838679; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FCEgbTcavNDddMXYhHdYZEcPaKdTXli9xkJUX/QJsO8=; b=skM8CHIDQSgQ6nR0tvc/b9A9JU+9zgjY/LOzY9aXUnEDIa3M7fsQmicsia/XExXmwn DZSOOINczGj1NYqrmzxd3aAvU8IiqjDrlfG6OkuVZDdfbbuofBUDgamaUNxrYV2hhov8 zG4RKcu003YAaEz1wl/+1NmNyB0sR5MsmxVHnl2nmwnccKqeCuGFEWfIj9t6wxirILlY Dp6qLCZnKDostHN6q3qWKwU0j1vwCgGKkvEAODA/Z+wFnuvPfRmKW24B8fT1P8XmgfUU Nt0fmjNrPZRgvaDhG4KkcJTdpuZuaY0U7apEgxdAU0T2lb5w6gzyLXcJR37E1VLaATXf +wRA== X-Gm-Message-State: AOJu0Ywj28PkQq8Dsp9ywSjXPN4pPwxkZ0fzAe7z8H/RY9PiX4eKZyXG xtPgW3R4ugQTt1rwFeVTgLwtwN61afodQHVAzHg++mKPvGt2x+R9Sbk5BQ== X-Google-Smtp-Source: AGHT+IFiyIPA+kXQVmKoxvoGVdFDe5OobyYGk+9HeRpdMlHFXyPe+2LPt3HuskR7X2gWxjXEJjgtlw== X-Received: by 2002:a05:6a00:138a:b0:706:381e:318c with SMTP id d2e1a72fcca58-7067459db3amr6286066b3a.7.1719233878950; Mon, 24 Jun 2024 05:57:58 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70651194b01sm6145601b3a.71.2024.06.24.05.57.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jun 2024 05:57:58 -0700 (PDT) Message-ID: <55c43602-178b-40f2-9e24-69fd9d2a9b29@gmail.com> Date: Mon, 24 Jun 2024 09:58:14 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20240622231520.7410-1-jamrial@gmail.com> Content-Language: en-US In-Reply-To: <20240622231520.7410-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 01/10 v4] avutil/stereo3d: add a Monoscopic view enum value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/22/2024 8:15 PM, James Almer wrote: > We need a way to signal the frame has a single view that doesn't map to any > particular eye, and it should be the default one. > > Signed-off-by: James Almer > --- > libavutil/stereo3d.c | 1 + > libavutil/stereo3d.h | 5 +++++ > 2 files changed, 6 insertions(+) > > diff --git a/libavutil/stereo3d.c b/libavutil/stereo3d.c > index 19e81e4124..37cf093099 100644 > --- a/libavutil/stereo3d.c > +++ b/libavutil/stereo3d.c > @@ -71,6 +71,7 @@ static const char * const stereo3d_view_names[] = { > [AV_STEREO3D_VIEW_PACKED] = "packed", > [AV_STEREO3D_VIEW_LEFT] = "left", > [AV_STEREO3D_VIEW_RIGHT] = "right", > + [AV_STEREO3D_VIEW_MONO] = "monoscopic", > }; > > static const char * const stereo3d_primary_eye_names[] = { > diff --git a/libavutil/stereo3d.h b/libavutil/stereo3d.h > index 00a5c3900e..9a004d88a1 100644 > --- a/libavutil/stereo3d.h > +++ b/libavutil/stereo3d.h > @@ -156,6 +156,11 @@ enum AVStereo3DView { > * Frame contains only the right view. > */ > AV_STEREO3D_VIEW_RIGHT, > + > + /** > + * Frame is monoscopic. > + */ > + AV_STEREO3D_VIEW_MONO, > }; > > /** Looking more into this, i don't know if this is a good idea, or even backwards compatible. AVStereo3DView is right now only ever looked at if type is not 2D, so adding a view that only applies to 2D seems pointless. And if we make it the default, users (wrongly) making the assumption packed view is the default will find themselves with a 3D type signaling a monoscopic view. For now I'll apply patch 2 adding unspec type plus the patches that don't deal with the view added here, unless there are objections. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".