From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A0A85432F0 for ; Tue, 30 Aug 2022 19:33:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3AFE568B9DC; Tue, 30 Aug 2022 22:33:33 +0300 (EEST) Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6704C68B9B2 for ; Tue, 30 Aug 2022 22:33:27 +0300 (EEST) Received: by mail-qt1-f170.google.com with SMTP id x5so9385062qtv.9 for ; Tue, 30 Aug 2022 12:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=zOAaAahHoYOcARW3RxZ/kVy3ZntWa6GHnu4VWW+VDwg=; b=Pf965TJLq/gYOp1tyaNvR1c+RDuxXOpkPhkdXpgsEBObnafz/rKyroRmzEOmXdg6jI H5OV9flLPQdbpGz0ZLQh/lJ9yIdz0rU6OayCtgDak/mC/eooSWyhlF+gJDeTNQnb30/J 3UOm3yiIV8CJ35APog4k56b9mVpGADFaF+BrMXMHf/4LQAAdNS/dw9BpmvjpkR2NwcPh x8yBK6d/+cgAM9y5P3jiKmh4c65d9xhDiUFRW5BBRO5PibMGIMNDiMdMkajDomxE7cHG w8q3Jsj4kfNvQqVAnF79FpxWbhuVvwIE0q+7sbkEH6LFw8Il0ANrJ3DAWPXG+OtkdrOC hq+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=zOAaAahHoYOcARW3RxZ/kVy3ZntWa6GHnu4VWW+VDwg=; b=CnHiS/uKAu8DIMn3CFfSG/PbH7wj/rCKyTKLEu6MVELmIW6NyTMHB2Y1UABZBbwfjj pSA883cWZG/ZV+Kd8bHI/3iBBq6EekbSgw6SwzNBaDV9WiU2KXjzvyzBoLR8nIfhHlJP 8InEYgHGN7TVdUvCIIBOSi/PzV2wF/sGwJNcPKrRBrUh882nQaTrcGUXqDwAEJs7G3MA w5tMBjuobBTZO84w0xq94ICvlYZib6bRp94/k8u9d3ZripWW9XGxPx9DlzyPpD+iOUA3 37lQ7gN0u/m56GrvCG2q+KzZA8Nh5RdzO2uUPwqOIgg+NhI/9AP5fav09yQByFQWDwmb OnhA== X-Gm-Message-State: ACgBeo1oR1inM/jjTQAiC7XAV4tEoNFt/Mu9EFWtBWFLCR8Byki6jPwU HyiGY0ghd+etVtTet+hZ0TrkQjhn3wY= X-Google-Smtp-Source: AA6agR5tn/Dbx6DG9HjKIKwoKpDZwV5oEA9l3+UYhEpSNK0zt3nG2ewUM0+p4O0SW2ESeU/z9AxQ9w== X-Received: by 2002:ac8:574e:0:b0:344:555f:cbe4 with SMTP id 14-20020ac8574e000000b00344555fcbe4mr16315896qtx.276.1661888005867; Tue, 30 Aug 2022 12:33:25 -0700 (PDT) Received: from [192.168.1.35] (c-68-41-54-207.hsd1.mi.comcast.net. [68.41.54.207]) by smtp.gmail.com with ESMTPSA id z20-20020ac87f94000000b003051ea4e7f6sm7979696qtj.48.2022.08.30.12.33.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 12:33:25 -0700 (PDT) Message-ID: <5520bdbb-0f14-8409-32c6-92c14fb8e8eb@gmail.com> Date: Tue, 30 Aug 2022 15:33:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US-large To: ffmpeg-devel@ffmpeg.org References: <20220824151828.24218-1-george@nsup.org> From: Leo Izen In-Reply-To: <20220824151828.24218-1-george@nsup.org> Subject: Re: [FFmpeg-devel] [PATCH] lavu: header and documentation for AVWriter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8/24/22 11:18, Nicolas George wrote: > +``` > + AVWriter wr = av_dynbuf_writer(); > + av_something_write(wr, something, 0); > + if (av_writer_get_error(wr, 0) < 0) > + die("Failed"); > + use_string(av_dynbuf_writer_get_data(wr, NULL)); > + av_dynbuf_writer_finalize(wr, NULL, NULL); > +``` Is there a reason this is AVWriter wr = foo() and not AVWriter *wr = foo()? Most other APIs return pointers to structs, rather than structs themselves (see: av_packet_alloc). Using a pointer would prevent us from having sizeof(AVWriter) as part of the ABI, as was done with AVPacket. - Leo Izen (thebombzen) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".