From: Leo Izen <leo.izen@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] lavu: header and documentation for AVWriter
Date: Tue, 30 Aug 2022 15:33:24 -0400
Message-ID: <5520bdbb-0f14-8409-32c6-92c14fb8e8eb@gmail.com> (raw)
In-Reply-To: <20220824151828.24218-1-george@nsup.org>
On 8/24/22 11:18, Nicolas George wrote:
> +```
> + AVWriter wr = av_dynbuf_writer();
> + av_something_write(wr, something, 0);
> + if (av_writer_get_error(wr, 0) < 0)
> + die("Failed");
> + use_string(av_dynbuf_writer_get_data(wr, NULL));
> + av_dynbuf_writer_finalize(wr, NULL, NULL);
> +```
Is there a reason this is AVWriter wr = foo() and not AVWriter *wr =
foo()? Most other APIs return pointers to structs, rather than structs
themselves (see: av_packet_alloc). Using a pointer would prevent us from
having sizeof(AVWriter) as part of the ABI, as was done with AVPacket.
- Leo Izen (thebombzen)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-08-30 19:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 15:18 Nicolas George
2022-08-24 15:45 ` Soft Works
2022-08-24 15:59 ` Andreas Rheinhardt
2022-08-24 16:01 ` Nicolas George
2022-08-30 17:08 ` Nicolas George
2022-08-30 19:33 ` Leo Izen [this message]
2022-08-30 19:37 ` Nicolas George
2022-08-31 3:13 ` Leo Izen
2022-08-31 3:23 ` Andreas Rheinhardt
2022-08-31 19:28 ` Nicolas George
2022-08-31 23:03 ` Stefano Sabatini
2022-09-01 13:01 ` Nicolas George
2022-09-01 21:33 ` Stefano Sabatini
2022-09-02 6:41 ` Anton Khirnov
2022-09-07 13:30 ` Nicolas George
2022-09-07 20:05 ` Jean-Baptiste Kempf
2022-09-07 21:13 ` Nicolas George
2022-09-08 16:18 ` Anton Khirnov
2022-09-14 21:29 ` Michael Niedermayer
2023-04-25 17:11 ` Nicolas George
2023-04-25 17:20 ` James Almer
2023-04-28 10:00 ` Nicolas George
2023-04-26 9:05 ` Anton Khirnov
2023-04-28 9:58 ` Nicolas George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5520bdbb-0f14-8409-32c6-92c14fb8e8eb@gmail.com \
--to=leo.izen@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git