From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AFF7D400E8 for ; Fri, 4 Nov 2022 02:06:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6462768C052; Fri, 4 Nov 2022 04:06:39 +0200 (EET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4094C68BF8A for ; Fri, 4 Nov 2022 04:06:32 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667527597; x=1699063597; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=5QVUACVm/pwpqDiqk7psZuUabPJGzvwkOt7HLs8IjjA=; b=Pm8XEkFBdjRAlWuPAu3ypqHQmGBvI/Laq+/JRW5xPx4K5jnR73/b+UH5 Jwl4qgiDZh2pm1OC7z7uKuOucaGgK2x0L2wWLAzO0e/UadJeJ02QJWG6h MgNu6slw3mu4upnYTihKZYZ0IG3eIwB+DpSVyTjhPHky9n2NZsmgfgjz2 wlKHdh3e42eupUC/q5s3it8ATR0JJxtptQfPc38CsCMzoFIB61hUMQG+n AmpM3F13HrBY94Qt2bVZWidJGNBDViRnDfcO1gV/o27ebl3wHZQci3GZ3 l8F4RAdLUrVS1gLxJLnKrVknvx+fIN9I2OviaJ0ArZY14nElGLAxJt7PX w==; X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="309849047" X-IronPort-AV: E=Sophos;i="5.96,135,1665471600"; d="scan'208";a="309849047" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2022 19:06:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="880121731" X-IronPort-AV: E=Sophos;i="5.96,135,1665471600"; d="scan'208";a="880121731" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 03 Nov 2022 19:06:29 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov 2022 19:06:29 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov 2022 19:06:26 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 3 Nov 2022 19:06:26 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 3 Nov 2022 19:06:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WFQ66UsKPBGn/IjF8gsHPPhfqFkc0riP2fBUG76NFWosq8OnCuYupZOiCHo+ugYsAGDVTEnLDgaXJjoOrdWI1UkA9bvR7EjTBf6aKLdcth7EGGoZVoZ08hX6d/Fk79DiZ9/hRCABS52/pTIHGJegr8ZQjqg2LhbqmtYHISY+stBNdScgXlweZqk2YoFBBb56KO4EMTnmGYwhZfZy6am4x14NFRDnY7s8VyVN5+S6gRcts9quWX/j/eWfNqDOFl/RhHqvIj/x4mxgdTFroGCtQtLY8PqtgM1cxB9dIICCOKo87KlNRCHOrZMAEyvkgPpXJmge8aDpGqcII+6bjZEIRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5QVUACVm/pwpqDiqk7psZuUabPJGzvwkOt7HLs8IjjA=; b=SKTGx5vdGHDqy28Xit3DrY9cFmEaW0z5ukdYy0J1vDLP92AfbfWtkcgprayb7s5vlboMvBZofTlOUuuDU3iK+2FQ+Q4rYVKBxCnTv4q5RGBVyCvGmisYRn+aAoZgXVtlsxOwgSwMIRdqLFDwHLsZjNnfVURqfcj1m7gh4mNRduykYQjdpGY7rmi8kFuVVO45NP8fy6REvmqs7Lf4oHM/TP05mjvyTbZsG1JhRgrhqG6Utswh+JJuS3fnatVd7JadtdNA5a9SieePYlIpupnN1nsXK7Po30FThmImQaMI45A+5T4Yx9r2G7L6Kz9yBtXKeu+N/A1nwy3yBUuISw3Z9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by SJ0PR11MB6813.namprd11.prod.outlook.com (2603:10b6:a03:47f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Fri, 4 Nov 2022 02:06:24 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8c4d:83ab:3e7a:3f23]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8c4d:83ab:3e7a:3f23%5]) with mapi id 15.20.5791.020; Fri, 4 Nov 2022 02:06:23 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" , "ruijing.dong@amd.com" Thread-Topic: [FFmpeg-devel] [PATCH v3] avcodec/av1_vaapi: fixed a decoding corruption issue Thread-Index: AQHY7ys7OtBXx286+E+6GtvLWYFn264uBbsA Date: Fri, 4 Nov 2022 02:06:23 +0000 Message-ID: <5511fc5a29ec562382b8124b73a53155a65f9bb0.camel@intel.com> References: <20221101023218.667352-1-ruijing.dong@amd.com> <20221102193553.214197-1-ruijing.dong@amd.com> <3c1a1a2f5facb8497d580c02300691f7d1f83deb.camel@intel.com> In-Reply-To: <3c1a1a2f5facb8497d580c02300691f7d1f83deb.camel@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|SJ0PR11MB6813:EE_ x-ms-office365-filtering-correlation-id: c0052658-ac01-4b82-198d-08dabe092ca5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tM8edYObsCx8QjPN5DMhqUUl1rZ5BGEjyHbEvKlV/ytJbM2Up76bXig1cOcLFlCUF6tci1O9Z0aq/cB7yUgyRG77/9HoUHXgjxZAZmik3UMsj53NdNFwTJk46Lxs75EY0NKZX91iDBwse0vAwn5G9XcLw0o2AvqEnEdecKlpS80ZtyP7N8m3LpYj7vEmEXD9aTqw5XA6Bt2uSV0WhKFeIPS5wTn0GdzuMazeYBPB0P8yw1e1RSUZRp6kZ9CeHGqT1wZhE+1ar6kz5suwhyTvLQdt4rowggFg0rl8q8aLD1x9HGAH0yv+Vi1uT40SmMS+WWIRVXlsdzzAzdeICP412+Nm9QZhsSur/y+uB2ROVlGln4c8yjCiduu3FbnwHTJiWESUY+rYUw9VabLB8gnE8lN+x3++zxd4U/lNe5q0fn07xxGxnYixzwhUf9hhhYnRcqNkpWtNkAP18o7g2ye8VYLd4DlCqUO5EWkHTMRHIjNprwkEnRnIn7BU+kXCqsjCDNtTsD30F1MHW2tsRw4YbZwi9DRaiwtHyqqaeNLZB/CaUORhnl2KAhdjcjjCjNRAkrE3zfOQQeHr094noJoAi8ccPZUot2YOsiDCUbfzAJQrL+iw1IRTg53RgxD9/XH1XmPoAUaZrV7hg59oG4uCZAx6NW3x8QizADPxl/jSDMFJB/+uuFtPX+hkRmjOWJthONhhFbpHWI0ZxfUzZw1PlQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(396003)(366004)(376002)(136003)(39860400002)(451199015)(110136005)(316002)(6512007)(76116006)(91956017)(2616005)(8936002)(6506007)(64756008)(41300700001)(66556008)(26005)(66476007)(66446008)(71200400001)(66946007)(8676002)(2906002)(6486002)(966005)(186003)(5660300002)(478600001)(86362001)(36756003)(83380400001)(38070700005)(38100700002)(122000001)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dFRZb2U2ZjlMNC8wQXFsTVdWR2c2WG9OWkVQeitycmxTa29lNlNjdFh6WTQz?= =?utf-8?B?bnJCVUhyLzd0NlAwNVlJLzRPNkd6dDMxc3A2a1dDU1c1b3lQY3kzdzVHazcr?= =?utf-8?B?S1hQTjdMZHM2ek1XK2ovYVBYdlNEUlEzS1ozRlhYZjNsNm9oZGcvTldUWVpu?= =?utf-8?B?enVHRHdLNS9iY1lGUytzbzZzQkZyTXEvNnhXNnZZbzAzanFXNWp2bHdVdmY1?= =?utf-8?B?aDFnNHEzRUkyRUxNTFBJUVNldmM5VDVjWEZKL2dzc3VqTTdKajZhVTRPbSt6?= =?utf-8?B?YU9WQURIeUN1c0oyQXhBSzFzQlZITW53ZGNFUHgrdWMvWmphRnY0SmJBclJM?= =?utf-8?B?RmtSNngwcDFOdkQzcjhObGFUODRwelI0RkNqOGw0MkVoeXhZR1BGSHJNbitD?= =?utf-8?B?TXI0cllhbXh5Z0F0ZDJlcnNNRW52SDd2Q2wrazhBTm1oeGpKM25rdFFhMjFN?= =?utf-8?B?dm94RlFFWUdPLzYyS0czYVY5R1luNDVZcUR0dnNnTVdFdTlDY1F2bXhaUXcw?= =?utf-8?B?cWdySTh5a2hBWWdramJTRDlIcHA4S1JuZzRKSHljUUhlTXhSeGVBeG9pRjNx?= =?utf-8?B?cGhBWW4xVUVYZmV4WVkzQUN2RTliV1UrS3d3UjYyanhKUFlBd1RuVk9ZRmoz?= =?utf-8?B?MUFHSzVwTDZ4Nkppa1U0aE9iNWJTanZhWWxDQ1VoVFIrUlNORDlTNnFSSXkr?= =?utf-8?B?OFNZbWVtRXVQU3djeHh0K3FmcEZhNlVra0RzSUVnRnhvYWdwdGVMVk9JSUdl?= =?utf-8?B?K0loSFYzMVpRZG50Qkk1QncwRjMyU2RtYms3bHFlVGg0c1lFRFk0eC83c1Nm?= =?utf-8?B?SGpqYlBCK3Rjcm5EckdHb3BESEVLek9UdzhNQ2tXZk1sOGRvNG9NTDhxcTFu?= =?utf-8?B?VjhaM21oU3IwUm1kRWNxMXdyeW5ZMVdTRWhnRmo1QVpST0xZQTlWK0FXM1N3?= =?utf-8?B?UnhaWGZ3NTRxYXo4QmlsNWd6dGN5M1BBRjJ1U0VrcGtzQ0U2dHpiWXhFM2di?= =?utf-8?B?QXRINVZSMklOMTBIRlZUbEYzWlBnMmYyN2lkYVVKUlhZeUVWTVdvSURaOE5J?= =?utf-8?B?L1FtTENiSjNDeEQzTXVnbHM2d2VmV1JuWXhGRmhvb0RZd0JUa0Vqajl6Qm5o?= =?utf-8?B?VlBXQjRkVkVTQlZJY25VR2pMSzg5cXRUZWh5WGVYdG56UWhUR1dSa2ZFdEQ4?= =?utf-8?B?VWhDb21SNkgySVhLZ2RZME1kbkY3TVlIZDNhL1h2d2szV1dGSkE3OTEyWEFL?= =?utf-8?B?aDZNVGN4bWU1eWU5bHRBK1BpZHEybFhCbVFsM0txTmdvMGtJM2tOeXFoemFB?= =?utf-8?B?MlNsYWdUbThHbER6R3B2NUx3bVZZS1poeUduZWtGRndSYzViY05acVYrUlVU?= =?utf-8?B?b1ExbHlKOTRMbnFVMXpYbVp1UmpoTm4rYzlDVjM1Y0VId0pyY0tLTWV5Zllz?= =?utf-8?B?dktLV1h1QU56b0Y0WCtVQzBGOTdMSUpJdXBzUXlmSFRQR21nZjZOMlZtUlpO?= =?utf-8?B?MzdtWk9WMlRNM1RzZ0hOeXNnWnJ3R2p5YW1zcVlTbHdlSzEvTG1PemtrU2Jt?= =?utf-8?B?a095MGtoZVhmSjA5MUthQVpvZzNMWlNYSlJhMTFJdjNIVGhrMTR6WjZBNWVV?= =?utf-8?B?S0lQZElMQk1pTHQvaTBzQ2RIRmFMZnZWSCtyZEZsdnhpakNqQ2xISWk0Yjda?= =?utf-8?B?STk1SnNENjdRUG0vNk1YdlZBYmFacW1FQWpScVNrOEFtSkF0cU5kamNtZ0Ft?= =?utf-8?B?eHp5bkRjUXlXME92V2RpOCs1bG9zQTFYMDRCWUFxLzlhNnVjRXJkYTlha3NM?= =?utf-8?B?Z1NQanJaZG03ZVJKTTF0ZDg1UFY1V2hXS2ZzTzdUa3VjR3Z2MHpKeFlwN0NF?= =?utf-8?B?UnVyYzBCZXpkL1JUZTdxbi8wSXBjZHVIWnB6ZVRXS2tmbUlHL3BJdTRvYUxj?= =?utf-8?B?VHpXQVVpQUNFaTBwODRqV0x1M2F0aFBTekRTOXEvOFIra21FVitOaVFpeXFK?= =?utf-8?B?b1I4OTh1RVhmRmVZQXovZytrWk8ySklkUnNDNXJiUEJkS3h6ZmNTdVd4QWlS?= =?utf-8?B?UmxzMjl3STluYU83RXBRS2NxRE9GNTZidjNmZEdUcXZHVjlLWE5XWitZaFQy?= =?utf-8?B?NXlqTmpCNUx0akZaM2I0dERaeisrdnJYZ2FjdGF4QnpnZ1RPTUFhMkpKNjRO?= =?utf-8?B?WGc9PQ==?= Content-ID: <62F426CD9CB0F24A9F1F55B39036A23A@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0052658-ac01-4b82-198d-08dabe092ca5 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2022 02:06:23.9190 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WMQLqY8n18DskegzqK17AE0l4Y60tbW+M4+g+n6DDpuFwQOA3BMLodXP5MCAOCBFdJllfL/RAhS5gQ9Y/xukYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6813 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v3] avcodec/av1_vaapi: fixed a decoding corruption issue X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2022-11-03 at 02:21 +0000, Wang, Fei W wrote: > On Wed, 2022-11-02 at 15:35 -0400, Ruijing Dong wrote: > > In av1_spec.pdf page 38/669, there is a sentence below: > > > > if ( frame_type == KEY_FRAME && show_frame ) { > > for ( i = 0; i < NUM_REF_FRAMES; i++) { > > RefValid[ i ] = 0 > > ...... > > } > > ...... > > } > > > > This shows that the condition of invalidating current > > DPB frames should be the coming frame_type is KEY_FRAME plus > > show_frame is equal to 1. Otherwise, some of the frames > > in sequence after KEY_FRAME still refer to the reference frames > > before KEY_FRAME, and if these before KEY_FRAME reference > > frames were invalidated, these frames could not find their > > reference frames, and it could cause image corruption. > > > > Mesa fix is in > > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19386 > > > > Signed-off-by: Ruijing Dong > > --- > > update: re-organize commit message and title > > > > libavcodec/vaapi_av1.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/vaapi_av1.c b/libavcodec/vaapi_av1.c > > index 63374c31c9..d0339b2705 100644 > > --- a/libavcodec/vaapi_av1.c > > +++ b/libavcodec/vaapi_av1.c > > @@ -274,7 +274,7 @@ static int vaapi_av1_start_frame(AVCodecContext > > *avctx, > > }; > > > > for (int i = 0; i < AV1_NUM_REF_FRAMES; i++) { > > - if (pic_param.pic_info_fields.bits.frame_type == > > AV1_FRAME_KEY) > > + if (pic_param.pic_info_fields.bits.frame_type == > > AV1_FRAME_KEY && frame_header->show_frame) > > LGTM, Thanks. > > Fei > > > pic_param.ref_frame_map[i] = VA_INVALID_ID; > > else > > pic_param.ref_frame_map[i] = ctx->ref_tab[i].valid ? > > -- > > 2.25.1 Applied, thx -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".