From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A60DE46B55 for ; Mon, 3 Jul 2023 19:34:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EBC5868C5DC; Mon, 3 Jul 2023 22:33:09 +0300 (EEST) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8ADB168C5D3 for ; Mon, 3 Jul 2023 22:33:08 +0300 (EEST) Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-6b73b839025so3982563a34.1 for ; Mon, 03 Jul 2023 12:33:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688412786; x=1691004786; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HZbS74LWwC3W7gZBFIW7g9Bc75+ObUKNJ3nbyAmRddo=; b=suqaM9t3VjEJ7QEvmpc2VBYbZ9E+ZIeqG+fisXdXFPp4dHOhZ9UCa+6VIXX31TcX6O my4urmk7e/7JDMwOazqZPChA8O7u3WYwG8GZJvaxvH0v+eGJnKeD/UdWp9jJYNoQuPBH BH1yv5BrXyXnZgymqzwBuX88/IthfdqERyedscyrJC7Anz7AulQEwAk23vX/tUPw8MLy g/u9DSXjZuzDpgxRijKY2jkmRUTxKyEedyFHXYTiKEkTCEZGsnjYZp8dn7ouXAVwCYcB ITjZehQe5wVuOFwp+SaVRYz3fsN83vjpsgFtWGe7kNTftdj3bEXYEkTtt6GVUoGrIUJB qSWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688412786; x=1691004786; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HZbS74LWwC3W7gZBFIW7g9Bc75+ObUKNJ3nbyAmRddo=; b=JwcNXUYhgd5Q1vzT1bo3IcB6+A7N3BEo9T8jwp8lkK8WreSuUfnh1C6cLUwFKd/2JM cOiH94QQhpNiQa261jGwwtCXOp+X3p8SRhnsjp0x7C/NRnLjMNrnH2AEindr3uyJ2+GD idlhOMZkxtaecCJX9/hNOm5Ze5NeXfy0JAYA9mTQNGwhHDieFlPDIOtTyrx4h9dmTBYa yjqDjpfYJ6G8rTd/IDZuC1JqqFHQvLx6mExg2ZdcLJrJ7LW9SCSr63dr/KlmxQafWFE4 3IYaV2Z+wO/O81JLZkGk8wqh7FlLHgEetRh/Ml7dAyPuT/NQ3eTDFU3JfL5/TrXjdRSh 0PCA== X-Gm-Message-State: AC+VfDwEi1KHiEG0EDu0Antu3NLsAja3MUmZer8Gbhh6wiPVdeixD1km siDYz0XT2Yu+nE9zltAZeL6gq5JMjh0= X-Google-Smtp-Source: ACHHUZ4enQmuo+kVoPWE96o0zTJUPC7WjYdsh/GIB7eq6KY/XdDBeNef5fJ1SwNLAvliDQ0Oqutg2g== X-Received: by 2002:a9d:619a:0:b0:6b8:92ea:23cb with SMTP id g26-20020a9d619a000000b006b892ea23cbmr12520546otk.14.1688412786192; Mon, 03 Jul 2023 12:33:06 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id j11-20020a9d7f0b000000b006b1ea725c07sm520102otq.59.2023.07.03.12.33.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jul 2023 12:33:05 -0700 (PDT) Message-ID: <54fe8899-d250-8d62-1157-621deb546040@gmail.com> Date: Mon, 3 Jul 2023 16:33:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230702193010.11654-1-cus@passwd.hu> From: James Almer In-Reply-To: <20230702193010.11654-1-cus@passwd.hu> Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/2/2023 4:30 PM, Marton Balint wrote: > It should be OK to use av_get_random_seed() to generate the key instead of > using openSSL/Gcrypt functions. This removes the hard dependancy of those libs > for key generation functionality. > > Fixes ticket #10441. > > Signed-off-by: Marton Balint > --- > libavformat/hlsenc.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 1e0848ce3d..0b22c71186 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat/hlsenc.c > @@ -40,6 +40,7 @@ > #include "libavutil/intreadwrite.h" > #include "libavutil/opt.h" > #include "libavutil/log.h" > +#include "libavutil/random_seed.h" > #include "libavutil/time.h" > #include "libavutil/time_internal.h" > > @@ -710,18 +711,18 @@ fail: > return ret; > } > > -static int randomize(uint8_t *buf, int len) > +static void randomize(uint8_t *buf, int len) > { > #if CONFIG_GCRYPT > gcry_randomize(buf, len, GCRY_VERY_STRONG_RANDOM); > - return 0; > + return; > #elif CONFIG_OPENSSL > if (RAND_bytes(buf, len)) > - return 0; > -#else > - return AVERROR(ENOSYS); > + return; > #endif > - return AVERROR(EINVAL); > + av_assert0(len % 4 == 0); > + for (int i = 0; i < len; i += 4) > + AV_WB32(buf + i, av_get_random_seed()); Maybe instead use a PRNG, like the following: AVLFG c; av_lfg_init(&c, av_get_random_seed()); for (int i = 0; i < len; i += 4) AV_WB32(buf + i, av_lfg_get(&c)); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".