From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BFB494109A for ; Sun, 13 Feb 2022 17:28:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CABBE68B216; Sun, 13 Feb 2022 19:28:18 +0200 (EET) Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8089168AE25 for ; Sun, 13 Feb 2022 19:28:12 +0200 (EET) Received: by mail-oo1-f54.google.com with SMTP id v17-20020a4ac911000000b002eac41bb3f4so16705764ooq.10 for ; Sun, 13 Feb 2022 09:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:content-language:to :references:from:subject:in-reply-to:content-transfer-encoding; bh=Fxuvg3Vg3LPxUqcNQHqp7yqJPYj7o9JYa07fTWlAxW8=; b=oF6x8q3Y5kuNp1A++hNjdwx/AZnv/vqwVnSVoHJFHwnqXfmr8KZ75MVvJ1spwDWGbL JLk46pkbo5HKqp+92gKbZlnTCNJwoXHeqzgsEUEZC8lL/3xCYyDnU2IncE88uBfxcMIa OsabqKhyBSmy8IePw7RHMMdh7GEAjmFzWIgPAt5iab3VAWypDuCiXWkXN4axqsCWa9/k pa78JpTUFQ4KG8zXm8zGEQbPE/BgrYmuREDGv7H7bJOuzvzUHyozuoBIEkDOEn09q9+O Y63FesJAs85/Wd1ahgq0zB44i0J8MsLCgjlAd0i5UtUs/qXT0emNvBSlXi+X5miDXD6v 2T3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=Fxuvg3Vg3LPxUqcNQHqp7yqJPYj7o9JYa07fTWlAxW8=; b=dNoaiWIsXz5qlKz8kJd6YlFnExzCRF/lZ4v0fLWNOJZcXC2Lmto7tNzvj1q8FlcF+G NLy83T9poSmDI7clcSq1SBtr6EhZ+/QSVxsx4sRgb5FQnO+kXF/Y6OL/VQcn+L5pnGOm 98yBzdpKta2Q/N3O090r97rDlezKZoi08aTdwsmzqyAH921NIdNhH3nC6oCPCUY7ZhYl yIaNhPc7JZOLLCiPTugFEgLxbFoqR+dAKa+vpknsfyuUFKCTHyWXertvXnIGjfi5Kn29 L+OyXVL9uYgyTnJpvGV6aMzEpAbNtXX8mlkV5v+XBLYcg2cTyAc7cQsrFJuojAyjgARo iY6A== X-Gm-Message-State: AOAM530bphXQEpzStFR0+Qh9zurRXOECpQjCfuOYbnm3RMFbAPNEBPTm YiF2PYDhdjOHM1N/M+nI0ehoUEjCzRdnmA== X-Google-Smtp-Source: ABdhPJxNh0WuCHsGXxXDeC2nkwfXzd1A0X9w9AAWGqvY1xT8lMfs9meKjMrVHjeKFqxF0zRKNO7HyQ== X-Received: by 2002:a05:6871:5d5:: with SMTP id v21mr2893886oan.10.1644773290934; Sun, 13 Feb 2022 09:28:10 -0800 (PST) Received: from [192.168.0.10] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id 12sm12965426oaj.31.2022.02.13.09.28.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Feb 2022 09:28:10 -0800 (PST) Message-ID: <54f088c2-0ed9-6a62-001c-40c24e9c88b6@gmail.com> Date: Sun, 13 Feb 2022 14:28:07 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220209152858.2339-1-jamrial@gmail.com> <5ae2e409-77bd-cd38-d10b-d65f2c4e8a84@gmail.com> <7e822563-4ecc-ed9e-3518-56cf8b497f4f@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/setts_bsf: set the output packet duration to 0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/13/2022 2:22 PM, Andreas Rheinhardt wrote: > James Almer: >> On 2/13/2022 2:14 PM, Paul B Mahol wrote: >>> Too soon. >>> >>> Wait more, >> >> Ok. >> >>> does this breaks something? >> >> There are no fate tests, and 0 is used when the duration is unknown, so >> it shouldn't break anything. >> > > It breaks the simple use-case where this filter is used to just shift > the timestamps. How so? It's a documented value that means unknown. What breaks because of it? Wouldn't it be revealing a bug if so? And in non simple use cases that completely replace or rescale the timestamps, the old duration value is no longer valid, and something definitely worse to have than 0. > > - Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".