From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/setts_bsf: set the output packet duration to 0
Date: Sun, 13 Feb 2022 14:28:07 -0300
Message-ID: <54f088c2-0ed9-6a62-001c-40c24e9c88b6@gmail.com> (raw)
In-Reply-To: <AM7PR03MB6660E13416857BDBC0D686438F329@AM7PR03MB6660.eurprd03.prod.outlook.com>
On 2/13/2022 2:22 PM, Andreas Rheinhardt wrote:
> James Almer:
>> On 2/13/2022 2:14 PM, Paul B Mahol wrote:
>>> Too soon.
>>>
>>> Wait more,
>>
>> Ok.
>>
>>> does this breaks something?
>>
>> There are no fate tests, and 0 is used when the duration is unknown, so
>> it shouldn't break anything.
>>
>
> It breaks the simple use-case where this filter is used to just shift
> the timestamps.
How so? It's a documented value that means unknown. What breaks because
of it? Wouldn't it be revealing a bug if so?
And in non simple use cases that completely replace or rescale the
timestamps, the old duration value is no longer valid, and something
definitely worse to have than 0.
>
> - Andreas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-13 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 15:28 James Almer
2022-02-13 17:07 ` James Almer
2022-02-13 17:14 ` Paul B Mahol
2022-02-13 17:20 ` James Almer
2022-02-13 17:22 ` Andreas Rheinhardt
2022-02-13 17:28 ` James Almer [this message]
2022-02-13 17:32 ` Andreas Rheinhardt
2022-02-13 18:38 ` Gyan Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54f088c2-0ed9-6a62-001c-40c24e9c88b6@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git