From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D4D3940B25 for ; Fri, 5 Aug 2022 05:16:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BEA4768B8EC; Fri, 5 Aug 2022 08:16:45 +0300 (EEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3B76968B7E6 for ; Fri, 5 Aug 2022 08:16:37 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659676603; x=1691212603; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=to6SvjvCTE1Jo4SlOJfxrlWpAxu8o+XU4X/AOzp3Flo=; b=b1H0E06rVURHYuZuM9d8ln06erBSNgHj9rRsv13r01dC4vbH0oF218Av 4FDff9fd5CUAxVHFJsFO0X3HuyhttP6tLKK7gcO2TGJz4GzTArt5ekE1p 766/Bg4E4fr610ch4Ei4qCyWGi72jWIPUuvB9hu6hM5JYJVnanACQ69NE SMybMi+vZpwOhcCNvm/E62fQaXr5Fi2O5SK1Jes5Zsx4YA5s7Ycd3695c +XNveh/qSEfL+wZ4v2Q3OT5lNdEbbczCoqHbxo5ejBu+XqdK+2Jd1ORws bV2kexYRZAzO/o7BwvPVFbnOzHuTnd9yYf5/hq2R1o41JNebKMX2I50gf A==; X-IronPort-AV: E=McAfee;i="6400,9594,10429"; a="287687043" X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="287687043" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2022 22:16:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="631882461" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 04 Aug 2022 22:16:35 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 4 Aug 2022 22:16:35 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 4 Aug 2022 22:16:34 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 4 Aug 2022 22:16:34 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 4 Aug 2022 22:16:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SsBpkhLNJ033K4d2iHCzRFVrSbD2NurRU7IhozfkyVQwV6VVESMSVe7oBkCA8jLQofqP+ePbiBuJzJASGAiEkJYacEdgQK6X1RBm++uxIfj3JFRGp1T858vroXETijFTtgIlwfp7i0qyViMYur/MrMyJjHnmuQGhZNIEF+gloQPrbq6viloUhpOYEHJx31DFaEDhBxPpjex1atDTK1d/QVfzwkZT8dGawMIv7clDtY4tm90cgQPvS14au38M1BaSL1AE2OEugBNGtGExg8aVdH8eLBAF9X4wwQd1nRNbcnCmds/z/mYuwXB2zuhOXQwxbU/70B/EDNyFpDJ0124ijw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=to6SvjvCTE1Jo4SlOJfxrlWpAxu8o+XU4X/AOzp3Flo=; b=Xr8N3g/OUKO4Fga21IOzcwtj0UBQa8fnOHcI4u0131BteEOuY6mX3GHUPsjTJd3QlsxV/omC+mtRbT5V6xwtNnnwuusYNOA/AoisRWjeCYohXOtWQsWJ4sAbOdbVKHf2OHHVGZo45rFJ0PldjZpic3OIJRtxuk7/NGKvTJMnnMJxL/7FfKTzGmXkPWcyIBxUR9NLA1FkjXwuPZUfQ7aR59Pe0jJnHNXOHPSNmqYL275umH8gPBXXa01rOEMXZ/vkG8Sr21DP9MR2a7nDIHzCcCNsTW9TTWikhHSHzhvbgkfr4vglWSxC4CzcajmabxwnMLt2zyywjLSl43Btx8q1vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by BN6PR11MB1410.namprd11.prod.outlook.com (2603:10b6:404:4a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Fri, 5 Aug 2022 05:16:19 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::bd7e:47b5:e014:2c0f]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::bd7e:47b5:e014:2c0f%7]) with mapi id 15.20.5504.014; Fri, 5 Aug 2022 05:16:19 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH 1/2] lavc/vaapi_decode: add missing flag when picking best pixel format Thread-Index: AQHYqH/LkETmUd+gFU6qis58dDZgzK2fw/uA Date: Fri, 5 Aug 2022 05:16:19 +0000 Message-ID: <54762c5b6c2e678e5bc893a5447b4bef189d400e.camel@intel.com> References: <20220805035904.59799-1-philipl@overt.org> <20220805035904.59799-2-philipl@overt.org> In-Reply-To: <20220805035904.59799-2-philipl@overt.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 610a5860-8b83-487e-f950-08da76a1a11f x-ms-traffictypediagnostic: BN6PR11MB1410:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vwdXdfJUTR1cxCLJ8ZxhVLNFNwKAS8DzQi8vA/ZHJoXjs7U6AQPQP9Q5lj5yMCs8qei6snotolPDlqy9hSlJmCfWiXJyA8bN7oUM2DJV5vhp1h0h8UA2G2fQ/+Bu+DNn/tHS9LMwTC+DDSGe9AjxKk7fBnKaMathiN/A2C3q09YEKzQPkBJNiFH8pNbEJulasd530ahaq81Yseo9KU+AnP7p+tilc4+yhkU9gzTUHPLZFbhDjwQ8aMzc3zzgcIVYR8mCh+qth7KVpaS5SXfVUkRQNYBO1GU18xzbU00px3tKlo7KVSkuEyRrHm+zsvz3h8ZUbjLV5+GFs9QDDlxmZsqn4rhyR9MEmaPVkDluezwhT/A/HrMvTEzbOrJIGfB8QpepUbUn2ElJTUOq1m5U6F35KHR4gJ9L2A9sT+QMqCNSFKdOK2qRPGtUZ7q91lWLg7ZWWI5QQrnVRawdl0VpRtNng15sOYoNXfsV4DB9Hbd6eJovWUU1dXQ+JnlkVfBg1Slc3yC+g6ZHz5+B3IYqL66RKjdubnzIUP+7ucxssLw+7m0wvBFZgVNe9/amfM4aeHuO3i2+MNqlggnHam4oBrnZxYm3TEXXCL4eWu28X7BgkK6Ccpi3HhqqJ4B0kgldfYSH0YknOPepFODP28BoD4xyNi/2nngw3lkHSlQN3ggh68bBjYjjRcU+qgE+bTVeK7TTzkdRMCIYu1KnNUSKFdDgSGueO/FDoCfX5rBSZ47OkrZDtaG5jakYu9GEU6XzcBvzpTZoyqd5denMHzFxCB5ZNsrQmBo3WFccjQ63qsgiVv3HgkwweFk7OhplERVj28VzL2YCabrm8nfejqX+YA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(376002)(366004)(39860400002)(346002)(136003)(86362001)(122000001)(186003)(38100700002)(82960400001)(36756003)(6512007)(2616005)(6506007)(41300700001)(26005)(38070700005)(478600001)(316002)(71200400001)(6486002)(6916009)(966005)(5660300002)(66476007)(66946007)(8936002)(76116006)(91956017)(66556008)(8676002)(2906002)(64756008)(66446008)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eXZXM3JJbzRjWkJscWxSYmhEdWpjWFcwWDl6bWRYY2NtZzZoOWExVlgxaTlK?= =?utf-8?B?bWdkWDVQODBmU1ZNbHBlQk1uVUpoR3Y5WkVtL1JUU2VISUd3a3llYUJwdVJi?= =?utf-8?B?TTdWenRqdStsYmJ6MDVIOG5EVENwUUFvam9SUktMdk1nOTVqaDZ5OEc1bmZI?= =?utf-8?B?bmMrbVpjc0wvQm80VFVWZEdYbFJ4bWJsQTBZY2h0Z1VMbHpIWjU4d3NESkNX?= =?utf-8?B?eFBjL2ErNm1sZUtwWm4zcis2SDNMOU9sZXNWY2U4b1NvT1UxZ0tkdDNQTFFK?= =?utf-8?B?U2I2cCtoUHZJclFkM3ZUZTQ3c2phZEZtemRISEJLaW1CVllTNUthZzB6L3pq?= =?utf-8?B?b3JwOE1MS0xYK0RRd0pvQUU3UWJnVlh4UjVwRjdqTTJKU2xNSytwWE5jM3hP?= =?utf-8?B?NHMzcWZOZGYyZllqeDhrM0t4cDNlS3RxTUJDR2U3QkZnaENYcnYwNytXWWt2?= =?utf-8?B?YXRHejdaRVp6TVVibFRMdVcxMjRwQnN4NkJTcXhqWEpjNmFtVjc0TnZOa0l2?= =?utf-8?B?REwxR09zL3NKTTVLV29nOHJqWVRBVGtsTEdKNHp3bTFCc2hsMWZDRHhJVWVY?= =?utf-8?B?Si9PSHl0MkxHbFVqRUp3Z1R4MFloNFdNT1NyRitvQU1iTHMzZU5YeVZsanpE?= =?utf-8?B?azFVYnErSCtWSEx6YmxiajRkTk1IZVUxS1U3d3ErMFZDL3B0a0RaMnZyUi9J?= =?utf-8?B?b2l5TVowVGhDcURkR0tBeTZOUEp3VHhOcFVQcUJPTWttMjdhcnFYMnJPc09k?= =?utf-8?B?WVk1SHhuV283eU1VM2Z6VFlNaTZnNEZmaDRtZXpLYWt0M0VxdWZTTlowY1h4?= =?utf-8?B?Vm1yQWEwbmE0OE01YWpxc1BGNWNsN3BnYyswM2EvUEZHYzNFdlBmQ1g1bHRn?= =?utf-8?B?MGFLSWRwQWpPMzVDSVFQQ09OSUpHa054RFd0RmpXNlBBall4Vk9ibVVER21H?= =?utf-8?B?d3VFV0lWcEsvOXRsVUQzZ0ZTZHJucWJHWFVPUE1KdEx0b2w4QW9wZzJta2Jl?= =?utf-8?B?TWs1RkFmZ0x4cG9OaitNMnh1OGVaNkROSGY5c3k1RU9aSmFVL0RVRFFZT1F3?= =?utf-8?B?VW80T1JBcDRrN2tiTjBpa3VqU0FCOVJ1VHppMkI1L0UydGFSNERhbFF1VURF?= =?utf-8?B?VFpzQjhZL1lqdERkTTVKcVgvY1NIalJOVjliOE5aUjlsQnpLbFBHbjkrWnl4?= =?utf-8?B?ajNueXF6L0R4dTZzbjZBQXBFNWFwT2NLbkRaTU1HdDA4Kyt4ejVvTWwxL2Zo?= =?utf-8?B?ZlREL1VFOFgranJYR1NneWU1YzEyZWRYRVFneXY2cGNGQy9aRVF2TzhzcFZh?= =?utf-8?B?T1VXYzFrQVVhQ0Q5VGw5VDM4Z0xpQlRENnR5V2ViNkZNUWVub0NwZkNDQWZw?= =?utf-8?B?eHNIbWtSVHBmQTVUV04va25GNlhSY1BxekxGbGVmUTIvVXU2bjJCekVaQ1dS?= =?utf-8?B?Y2FqRDZHOHQya1VDbHJzVVEvd0hyZDNIMXVVWS9LcEFsNjNBOW1tKzRTZDhN?= =?utf-8?B?QmQ1cU13RHVTV1FoSFhmaXhpMDM2Q3pCMWZKMWFyZGl5cVJWc29QTTlpS1Zq?= =?utf-8?B?ZWpYd0h1NVBmVDQ1eHJMcWFDL0srWjg1anlRejlmYVJDVlkzNjN5Z1FhdXRC?= =?utf-8?B?MjAxZUd4b2hCSXdTLy9SRVBaM1FEMnJBUWtRS0xrVlRJanJRbzRNOHg3TUxN?= =?utf-8?B?VjA0MXNGc2tzeXhrN3VTK1YzdFpZZ25UcVg0Y2o0ZllZSllXTWEwSjJ1N3Ft?= =?utf-8?B?RytlQkVzVVhmcTRUMkNMK1dBaUVPNEJNekxvSmRETjFRaFRSVkVxY05PQmpT?= =?utf-8?B?dEY3Z2ZIVUh1SzgzM1JPM0p0TlBCWFB6cTFnWWxpa1VoQ3ZJdHFvdXQwbjFx?= =?utf-8?B?a2VuTDFNYXFtRXlQWkZaaDR6N3MyVVVQWUdSdy9sUmlBdmJBVHZKSGc1ZzVC?= =?utf-8?B?b2xOeWpvQk1HSWJBNjR0V3ZHQzFiZEgrcDJWMDhIL0twK1gzTFZDb3VWcnRn?= =?utf-8?B?RGJlWFlPRWw0WG05VCtNalloTWxHMmVjZjdmcXlSa3dtTGZKZDZZQjVTdWV2?= =?utf-8?B?UFpJcUl3RHcrcDlYbEg2T2pwSzd2ME1qUXpITlNsd2orMmF4d3l5b2Z2ay84?= =?utf-8?B?K2Z2TWFKZUxOV3owVjhlTEhnV3IzalJiSUVrN2JlSGZUdHBpQjFXZjJJOWRT?= =?utf-8?B?TGc9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 610a5860-8b83-487e-f950-08da76a1a11f X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2022 05:16:19.0917 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fK17HP6rCz02bLM5t09kiDYOVI3BbOupW112o6vEuDaV0u9AZnnk8M/0BIpB2UKqC8K6aisLWIv7GZlJ00bQMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1410 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavc/vaapi_decode: add missing flag when picking best pixel format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "philipl@overt.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2022-08-04 at 20:59 -0700, Philip Langdale wrote: > vaapi_decode_find_best_format currently does not set the > VA_SURFACE_ATTRIB_SETTABLE flag on the pixel format attribute that it > returns. > > Without this flag, the attribute will be ignored by vaCreateSurfaces, > meaning that the driver's default logic for picking a pixel format > will > kick in. > > So far, this hasn't produced visible problems, but when trying to > decode 4:4:4 content, at least on Intel, the driver will pick the > 444P planar format, even though the decoder can only return the AYUV > packed format. > > The hwcontext_vaapi code that sets surface attributes when picking > formats does not have this bug. > > Applications may use their own logic for finding the best format, and > so may not hit this bug. eg: mpv is unaffected. > > Signed-off-by: Philip Langdale > --- > libavcodec/vaapi_decode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c > index db48efc3ed..38813eb8e4 100644 > --- a/libavcodec/vaapi_decode.c > +++ b/libavcodec/vaapi_decode.c > @@ -358,6 +358,7 @@ static int > vaapi_decode_find_best_format(AVCodecContext *avctx, > > ctx->pixel_format_attribute = (VASurfaceAttrib) { > .type = VASurfaceAttribPixelFormat, > + .flags = VA_SURFACE_ATTRIB_SETTABLE, Better to fill .value.type with VAGenericValueTypeInteger together: https://github.com/intel/media-driver/blob/4c95e8ef1e98cac661412d02f108e4e1c94d3556/media_driver/linux/common/ddi/media_libva.cpp#L2780 Thanks Fei > .value.value.i = best_fourcc, > }; > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".