From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B2744466D3 for ; Mon, 31 Jul 2023 21:54:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7C17D68C24A; Tue, 1 Aug 2023 00:54:01 +0300 (EEST) Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 624D668BD8E for ; Tue, 1 Aug 2023 00:53:55 +0300 (EEST) Received: by mail-oo1-f43.google.com with SMTP id 006d021491bc7-56c884e1d74so1613038eaf.0 for ; Mon, 31 Jul 2023 14:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690840433; x=1691445233; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TQC+x/jiU2PVP5A2vQj7O+aueZylcKIdV+7dW9q2dZg=; b=IQUSGml9hebdhCndXcFqlxtYZq1AxvtKbbGO+F2wJbDRMOfg7/w+H2KijKNx1Wzahj NMTZc2kgPti9dQ9NMNaOXLxhveHFqKl+kbnt96ocrZqw93d2aBfkxtuXH+7g7FEEk3hw 4EDRkUAfYuJoSCR5Y5fsIqDP4e/SKBErc6A2owZV9abgh804X2sZwR+EXj1UC1ngLf3I 7nrvoXBsWHlTEbxf6DVOfoQ8TCSPZIHO4HG+aI55TnszNEvS+/tKy0XD8QcEmfQOO+O5 9w5ne7BSeexkiUPlT/efzlu2oSvU7z2rgF+lFr2x/AXo1jjkrA7Mpx/+nS1y9USl/Dcz 3elA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690840433; x=1691445233; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TQC+x/jiU2PVP5A2vQj7O+aueZylcKIdV+7dW9q2dZg=; b=FtLXdZjoLL3TiS1KnbET4u1vYMA0Uw19da/UxSjew8wgLcYESXDIPjvIZu9/MiCj/7 WV1eVU1JCiqMxOkzDc96CEH0LmszLVIYJTapAUNsF/FDlwCVCAU377HnKIW3D110UACk 8LlzOq2XaoG9O4tYpzCF9pi5PK2IWSwRE4lFQ48F7BWmUvK9bpbu6/E9u52fEuS2q/8d Ejz3kwNkobOdFXEojBTzk3x9q+uqnEB5qzdapEM6Ybp9Ea09ZKBlmMJTt7pWgM341YMx ZqUjwBVv5MoAvlb2cVl6WLaMiCCqrs7ERk4ObA1MRyav0XWgQFogSL3TXrOgZV4PNjDk LSDA== X-Gm-Message-State: ABy/qLbVOw8VtVVg3nGQfUnaG02gdhTwc7sBdvKl3tlnLmfKDUXzRdhv oE2Y77GJMci3Z2RovYDazfwXalTueyE= X-Google-Smtp-Source: APBJJlHijkXvl5ABq2Z3ulePEH7K6Ha39xQ1jgTs8uTKaVRvYtHa5klyZt4bmUlVz8LOt/8jSLZzDA== X-Received: by 2002:a54:4386:0:b0:3a7:1277:be0a with SMTP id u6-20020a544386000000b003a71277be0amr6984080oiv.36.1690840433030; Mon, 31 Jul 2023 14:53:53 -0700 (PDT) Received: from [192.168.0.16] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id e13-20020aca230d000000b003a3645e9ebbsm4521117oie.40.2023.07.31.14.53.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jul 2023 14:53:52 -0700 (PDT) Message-ID: <54545c33-5ff8-2dc3-492a-81928d56694f@gmail.com> Date: Mon, 31 Jul 2023 18:54:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230718031203.87803-1-fei.w.wang@intel.com> <20230718031203.87803-2-fei.w.wang@intel.com> From: James Almer In-Reply-To: <20230718031203.87803-2-fei.w.wang@intel.com> Subject: Re: [FFmpeg-devel] [PATCH v2 2/6] lavc/av1: Add common code and unit test for level handling X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/18/2023 12:11 AM, Fei Wang wrote: > Signed-off-by: Fei Wang > --- > libavcodec/Makefile | 4 +- > libavcodec/av1_profile_level.c | 91 ++++++++++++++++++++++++ > libavcodec/av1_profile_level.h | 58 +++++++++++++++ > libavcodec/tests/.gitignore | 1 + > libavcodec/tests/av1_levels.c | 124 +++++++++++++++++++++++++++++++++ > tests/fate/libavcodec.mak | 5 ++ > 6 files changed, 282 insertions(+), 1 deletion(-) > create mode 100644 libavcodec/av1_profile_level.c > create mode 100644 libavcodec/av1_profile_level.h > create mode 100644 libavcodec/tests/av1_levels.c > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index 1b0226c089..3cd5997e64 100644 > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -30,6 +30,7 @@ HEADERS = ac3_parser.h \ > OBJS = ac3_parser.o \ > adts_parser.o \ > allcodecs.o \ > + av1_profile_level.o \ There's no reason for this to be compiled unconditionally. If a module needs it, it can include it. > avcodec.o \ > avdct.o \ > avpacket.o \ > @@ -1308,7 +1309,8 @@ SKIPHEADERS-$(CONFIG_VULKAN) += vulkan.h vulkan_video.h vulkan_decode. > SKIPHEADERS-$(CONFIG_V4L2_M2M) += v4l2_buffers.h v4l2_context.h v4l2_m2m.h > SKIPHEADERS-$(CONFIG_ZLIB) += zlib_wrapper.h > > -TESTPROGS = avcodec \ > +TESTPROGS = av1_levels \ > + avcodec \ > avpacket \ > bitstream_be \ > bitstream_le \ > diff --git a/libavcodec/av1_profile_level.c b/libavcodec/av1_profile_level.c > new file mode 100644 > index 0000000000..5aacf6ddb0 > --- /dev/null > +++ b/libavcodec/av1_profile_level.c I'd prefer if we call this av1_levels.c, to go in line with the h264 file, and the test you are also adding here. > @@ -0,0 +1,91 @@ > +/* > + * Copyright (c) 2023 Intel Corporation > + * > + * This file is part of FFmpeg. > + * > + * FFmpeg is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * FFmpeg is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with FFmpeg; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > + */ > + > +#include "libavutil/common.h" > +#include "av1_profile_level.h" > + > +/** ignore entries which named in spec but no details. Like level 2.2 and 7.0. */ > +static const AV1LevelDescriptor av1_levels[] = { > + // Name MaxVSize MainMbps MaxTiles > + // | level_idx | MaxDisplayRate | HighMbps | MaxTileCols > + // | | MaxPicSize | | MaxDecodeRate | | MainCR | | > + // | | | MaxHSize | | | MaxHeaderRate | | | HighCR| | > + // | | | | | | | | | | | | | | > + { "2.0", 0, 147456, 2048, 1152, 4423680, 5529600, 150, 1.5, 0, 2, 0, 8, 4 }, > + { "2.1", 1, 278784, 2816, 1584, 8363520, 10454400, 150, 3.0, 0, 2, 0, 8, 4 }, > + { "3.0", 4, 665856, 4352, 2448, 19975680, 24969600, 150, 6.0, 0, 2, 0, 16, 6 }, > + { "3.1", 5, 1065024, 5504, 3096, 31950720, 39938400, 150, 10.0, 0, 2, 0, 16, 6 }, > + { "4.0", 8, 2359296, 6144, 3456, 70778880, 77856768, 300, 12.0, 30.0, 4, 4, 32, 8 }, > + { "4.1", 9, 2359296, 6144, 3456, 141557760, 155713536, 300, 20.0, 50.0, 4, 4, 32, 8 }, > + { "5.0", 12, 8912896, 8192, 4352, 267386880, 273715200, 300, 30.0, 100.0, 6, 4, 64, 8 }, > + { "5.1", 13, 8912896, 8192, 4352, 534773760, 547430400, 300, 40.0, 160.0, 8, 4, 64, 8 }, > + { "5.2", 14, 8912896, 8192, 4352, 1069547520, 1094860800, 300, 60.0, 240.0, 8, 4, 64, 8 }, > + { "5.3", 15, 8912896, 8192, 4352, 1069547520, 1176502272, 300, 60.0, 240.0, 8, 4, 64, 8 }, > + { "6.0", 16, 35651584, 16384, 8704, 1069547520, 1176502272, 300, 60.0, 240.0, 8, 4, 128, 16 }, > + { "6.1", 17, 35651584, 16384, 8704, 2139095040, 2189721600, 300, 100.0, 480.0, 8, 4, 128, 16 }, > + { "6.2", 18, 35651584, 16384, 8704, 4278190080, 4379443200, 300, 160.0, 800.0, 8, 4, 128, 16 }, > + { "6.3", 19, 35651584, 16384, 8704, 4278190080, 4706009088, 300, 160.0, 800.0, 8, 4, 128, 16 }, > +}; > + > +const AV1LevelDescriptor *ff_av1_guess_level(int64_t bitrate, > + int tier, > + int width, > + int height, > + int tiles, > + int tile_cols, > + float fps) > +{ > + int pic_size; > + uint64_t display_rate; > + float max_br; > + > + pic_size = width * height; > + display_rate = (uint64_t)pic_size * fps; > + > + for (int i = 0; i < FF_ARRAY_ELEMS(av1_levels); i++) { > + const AV1LevelDescriptor *level = &av1_levels[i]; > + // Limitation: decode rate, header rate, compress rate, etc. are not considered. > + if (pic_size > level->max_pic_size) > + continue; > + if (width > level->max_h_size) > + continue; > + if (height > level->max_v_size) > + continue; > + if (display_rate > level->max_display_rate) > + continue; > + > + if (tier) > + max_br = level->high_mbps; > + else > + max_br = level->main_mbps; > + if (!max_br) > + continue; > + if (bitrate > (int64_t)(1000000.0 * max_br)) > + continue; > + > + if (tiles > level->max_tiles) > + continue; > + if (tile_cols > level->max_tile_cols) > + continue; > + return level; > + } > + > + return NULL; > +} > diff --git a/libavcodec/av1_profile_level.h b/libavcodec/av1_profile_level.h > new file mode 100644 > index 0000000000..b08dd7383f > --- /dev/null > +++ b/libavcodec/av1_profile_level.h > @@ -0,0 +1,58 @@ > +/* > + * Copyright (c) 2023 Intel Corporation > + * > + * This file is part of FFmpeg. > + * > + * FFmpeg is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * FFmpeg is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with FFmpeg; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > + */ > + > +#ifndef AVCODEC_AV1_PROFILE_LEVEL_H > +#define AVCODEC_AV1_PROFILE_LEVEL_H > + > +#include > + > +typedef struct AV1LevelDescriptor { > + const char *name; > + uint8_t level_idx; > + > + uint32_t max_pic_size; > + uint32_t max_h_size; > + uint32_t max_v_size; > + uint64_t max_display_rate; > + uint64_t max_decode_rate; > + > + uint32_t max_header_rate; > + float main_mbps; > + float high_mbps; > + uint32_t main_cr; > + uint32_t high_cr; > + uint32_t max_tiles; > + uint32_t max_tile_cols; > +} AV1LevelDescriptor; > + > +/** > + * Guess the level of a stream from some parameters. > + * > + * Unknown parameters may be zero, in which case they will be ignored. > + */ > +const AV1LevelDescriptor *ff_av1_guess_level(int64_t bitrate, > + int tier, > + int width, > + int height, > + int tile_rows, > + int tile_cols, > + float fps); > + > +#endif /* AVCODEC_AV1_PROFILE_LEVEL_H */ > diff --git a/libavcodec/tests/.gitignore b/libavcodec/tests/.gitignore > index 2acfc4e804..5e0ccc5838 100644 > --- a/libavcodec/tests/.gitignore > +++ b/libavcodec/tests/.gitignore > @@ -1,3 +1,4 @@ > +/av1_levels > /avcodec > /avfft > /avpacket > diff --git a/libavcodec/tests/av1_levels.c b/libavcodec/tests/av1_levels.c > new file mode 100644 > index 0000000000..d91e1cc073 > --- /dev/null > +++ b/libavcodec/tests/av1_levels.c > @@ -0,0 +1,124 @@ > +/* > + * Copyright (c) 2023 Intel Corporation > + * > + * This file is part of FFmpeg. > + * > + * FFmpeg is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * FFmpeg is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with FFmpeg; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > + */ > + > +#include "libavutil/common.h" > +#include "libavcodec/av1_profile_level.h" > + > +static const struct { > + int width; > + int height; > + float framerate; > + int level_idx; > +} test_sizes[] = { > + { 426, 240, 30.0, 0 }, > + { 640, 360, 30.0, 1 }, > + { 854, 480, 30.0, 4 }, > + { 1280, 720, 30.0, 5 }, > + { 1920, 1080, 30.0, 8 }, > + { 1920, 1080, 60.0, 9 }, > + { 3840, 2160, 30.0, 12 }, > + { 3840, 2160, 60.0, 13 }, > + { 3840, 2160, 120.0, 14 }, > + { 7680, 4320, 30.0, 16 }, > + { 7680, 4320, 60.0, 17 }, > + { 7680, 4320, 120.0, 18 }, > +}; > + > +static const struct { > + int64_t bitrate; > + int tier; > + int level_idx; > +} test_bitrate[] = { > + { 1500000, 0, 0 }, > + { 3000000, 0, 1 }, > + { 6000000, 0, 4 }, > + { 10000000, 0, 5 }, > + { 12000000, 0, 8 }, > + { 30000000, 1, 8 }, > + { 20000000, 0, 9 }, > + { 50000000, 1, 9 }, > + { 30000000, 0, 12 }, > + { 100000000, 1, 12 }, > + { 40000000, 0, 13 }, > + { 160000000, 1, 13 }, > + { 60000000, 0, 14 }, > + { 240000000, 1, 14 }, > + { 100000000, 0, 17 }, > + { 480000000, 1, 17 }, > + { 160000000, 0, 18 }, > + { 800000000, 1, 18 }, > +}; > + > +static const struct { > + int tiles; > + int tile_cols; > + int level_idx; > +} test_tiles[] = { > + { 8, 4, 0 }, > + { 16, 6, 4 }, > + { 32, 8, 8 }, > + { 64, 8, 12 }, > + { 128, 16, 16 }, > +}; > + > +int main(void) > +{ > + const AV1LevelDescriptor *level; > + int i; > + > +#define CHECK(expected, format, ...) do { \ > + if (level ? (level->level_idx != expected) \ > + : !level) { \ > + av_log(NULL, AV_LOG_ERROR, "Incorrect level for " \ > + format ": expected %d, got %d.\n", __VA_ARGS__, \ > + expected, level ? level->level_idx : -1); \ > + return 1; \ > + } \ > + } while (0) > + > + for (i = 0; i < FF_ARRAY_ELEMS(test_sizes); i++) { > + level = ff_av1_guess_level(0, 0, > + test_sizes[i].width, > + test_sizes[i].height, > + 0, 0, test_sizes[i].framerate); > + CHECK(test_sizes[i].level_idx, "size %dx%d, framerate %f", > + test_sizes[i].width, test_sizes[i].height, test_sizes[i].framerate); > + } > + > + for (i = 0; i < FF_ARRAY_ELEMS(test_bitrate); i++) { > + level = ff_av1_guess_level(test_bitrate[i].bitrate, > + test_bitrate[i].tier, > + 0, 0, 0, 0, 0); > + CHECK(test_bitrate[i].level_idx, "bitrate %"PRId64" tier %d", > + test_bitrate[i].bitrate, test_bitrate[i].tier); > + } > + > + for (i = 0; i < FF_ARRAY_ELEMS(test_tiles); i++) { > + level = ff_av1_guess_level(0, 0, 0, 0, > + test_tiles[i].tiles, > + test_tiles[i].tile_cols, > + 0); > + CHECK(test_tiles[i].level_idx, "tiles %d, tile cols %d", > + test_tiles[i].tiles, > + test_tiles[i].tile_cols); > + } > + > + return 0; > +} > diff --git a/tests/fate/libavcodec.mak b/tests/fate/libavcodec.mak > index 8f56fae3a8..9c4d1b6840 100644 > --- a/tests/fate/libavcodec.mak > +++ b/tests/fate/libavcodec.mak > @@ -1,3 +1,8 @@ > +FATE_LIBAVCODEC-yes += fate-av1-levels > +fate-av1-levels: libavcodec/tests/av1_levels$(EXESUF) > +fate-av1-levels: CMD = run libavcodec/tests/av1_levels$(EXESUF) > +fate-av1-levels: REF = /dev/null > + > FATE_LIBAVCODEC-yes += fate-avpacket > fate-avpacket: libavcodec/tests/avpacket$(EXESUF) > fate-avpacket: CMD = run libavcodec/tests/avpacket$(EXESUF) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".