Re: [FFmpeg-devel] FFmpeg 5.1

[James Almer <jamrial@gmail.com>]

On 7/8/2022 7:23 AM, Timo Rothenpieler wrote:
> On 08/07/2022 12:17, Timo Rothenpieler wrote:
>>> The lavfi changes, more specifically wrapped_avframe, still rely on 
>>> sizeof(AVFrame) being used outside lavu. We really need to stop 
>>> spreading its use and find a way to change this behavior.
>>> I have tried like two different solutions and both were rejected, so 
>>> it's not going to be me.
>>
>> wrapped_avframe is used all over the place in lavd already.
>> Is that really a problem, as long as it's within another libav* library?
>> Given we don't support mix-matching library versions in the first place.
> 
> Also, thinking about it, wrapped_avframe does not actually rely on the 
> size of AVFrame at all.
> It's only set on the buffer as a purely informational thing.

No, it's used by the "decoder"

https://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/wrapped_avframe.c;h=06c274eed0b99e9ba5a703df963ef4c8f67dbe1c;hb=HEAD#l90

> The only actual data in the buffer is a pointer to the frame.
> So more accurately, the size of the wrapped package could be sizeof(void*).
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".