Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Brad Smith <brad-at-comstyle.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] lavu/thread: add support for setting thread name on *bsd and solaris
Date: Tue, 16 Jan 2024 01:25:14 -0500
Message-ID: <54479357-fbd4-4226-8c27-3bfceacc516c@comstyle.com> (raw)
In-Reply-To: <ZZo8511zgYcXMWha@humpty.home.comstyle.com>

On 2024-01-07 12:55 a.m., Brad Smith wrote:
> lavu/thread: add support for setting thread name on *bsd and solaris
>
> FreeBSD/DragonFly/Solaris use pthread_setname_np(). OpenBSD uses pthread_set_name_np().
>
> Signed-off-by: Brad Smith<brad@comstyle.com>
> ---
>   configure          | 10 ++++++++++
>   libavutil/thread.h | 14 ++++++++++++--
>   2 files changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 0b5e83bd20..67660b6292 100755
> --- a/configure
> +++ b/configure
> @@ -2239,6 +2239,7 @@ HEADERS_LIST="
>       opencv2_core_core_c_h
>       OpenGL_gl3_h
>       poll_h
> +    pthread_np_h
>       sys_param_h
>       sys_resource_h
>       sys_select_h
> @@ -2341,6 +2342,8 @@ SYSTEM_FUNCS="
>       posix_memalign
>       prctl
>       pthread_cancel
> +    pthread_set_name_np
> +    pthread_setname_np
>       sched_getaffinity
>       SecItemImport
>       SetConsoleTextAttribute
> @@ -6523,6 +6526,7 @@ check_headers malloc.h
>   check_headers mftransform.h
>   check_headers net/udplite.h
>   check_headers poll.h
> +check_headers pthread_np.h
>   check_headers sys/param.h
>   check_headers sys/resource.h
>   check_headers sys/select.h
> @@ -6691,6 +6695,12 @@ if ! disabled pthreads && ! enabled w32threads && ! enabled os2threads; then
>       if enabled pthreads; then
>           check_builtin sem_timedwait semaphore.h "sem_t *s; sem_init(s,0,0); sem_timedwait(s,0); sem_destroy(s)" $pthreads_extralibs
>           check_func pthread_cancel $pthreads_extralibs
> +        hdrs=pthread.h
> +        if enabled pthread_np_h; then
> +            hdrs="$hdrs pthread_np.h"
> +        fi
> +        check_lib pthread_set_name_np "$hdrs" pthread_set_name_np -lpthread
> +        check_lib pthread_setname_np "$hdrs" pthread_setname_np -lpthread
>       fi
>   fi
>   
> diff --git a/libavutil/thread.h b/libavutil/thread.h
> index 2ded498c89..fa74dd2ea7 100644
> --- a/libavutil/thread.h
> +++ b/libavutil/thread.h
> @@ -26,6 +26,8 @@
>   
>   #if HAVE_PRCTL
>   #include <sys/prctl.h>
> +#elif (HAVE_PTHREAD_SETNAME_NP || HAVE_PTHREAD_SET_NAME_NP) && HAVE_PTHREAD_NP_H
> +#include <pthread_np.h>
>   #endif
>   
>   #include "error.h"
> @@ -213,11 +215,19 @@ static inline int ff_thread_once(char *control, void (*routine)(void))
>   
>   static inline int ff_thread_setname(const char *name)
>   {
> +    int ret = 0;
> +
>   #if HAVE_PRCTL
> -    return AVERROR(prctl(PR_SET_NAME, name));
> +    ret = AVERROR(prctl(PR_SET_NAME, name));
> +#elif HAVE_PTHREAD_SETNAME_NP
> +    ret = AVERROR(pthread_setname_np(pthread_self(), name));
> +#elif HAVE_PTHREAD_SET_NAME_NP
> +    pthread_set_name_np(pthread_self(), name);
> +#else
> +    ret = AVERROR(ENOSYS);
>   #endif
>   
> -    return AVERROR(ENOSYS);
> +    return ret;
>   }
>   
>   #endif /* AVUTIL_THREAD_H */


ping.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-01-16  6:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-07  5:55 Brad Smith
2024-01-16  6:25 ` Brad Smith [this message]
2024-01-23 19:44   ` Brad Smith
2024-01-31  6:54     ` Brad Smith
2024-02-04 19:41       ` Marton Balint

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54479357-fbd4-4226-8c27-3bfceacc516c@comstyle.com \
    --to=brad-at-comstyle.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git