* [FFmpeg-devel] [PATCH] movenc: Use LIBAVFORMAT_IDENT instead of LIBAVCODEC_IDENT
@ 2022-03-11 14:23 Martin Storsjö
2022-03-12 21:46 ` James Almer
0 siblings, 1 reply; 3+ messages in thread
From: Martin Storsjö @ 2022-03-11 14:23 UTC (permalink / raw)
To: ffmpeg-devel
The muxer seems to have had one seemingly accidental use of
LIBAVCODEC_IDENT, while LIBAVFORMAT_IDENT probably is the
relevant one (which is used multiple times in the same file).
Signed-off-by: Martin Storsjö <martin@martin.st>
---
libavformat/movenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 4c868919ae..a2c2145354 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -4108,7 +4108,7 @@ static int mov_write_uuidusmt_tag(AVIOContext *pb, AVFormatContext *s)
avio_wb16(pb, 0x021C); /* data */
if (!(s->flags & AVFMT_FLAG_BITEXACT))
- mov_write_psp_udta_tag(pb, LIBAVCODEC_IDENT, "eng", 0x04);
+ mov_write_psp_udta_tag(pb, LIBAVFORMAT_IDENT, "eng", 0x04);
mov_write_psp_udta_tag(pb, title->value, "eng", 0x01);
mov_write_psp_udta_tag(pb, "2006/04/01 11:11:11", "und", 0x03);
--
2.32.0 (Apple Git-132)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] movenc: Use LIBAVFORMAT_IDENT instead of LIBAVCODEC_IDENT
2022-03-11 14:23 [FFmpeg-devel] [PATCH] movenc: Use LIBAVFORMAT_IDENT instead of LIBAVCODEC_IDENT Martin Storsjö
@ 2022-03-12 21:46 ` James Almer
2022-03-12 22:28 ` Martin Storsjö
0 siblings, 1 reply; 3+ messages in thread
From: James Almer @ 2022-03-12 21:46 UTC (permalink / raw)
To: ffmpeg-devel
On 3/11/2022 11:23 AM, Martin Storsjö wrote:
> The muxer seems to have had one seemingly accidental use of
> LIBAVCODEC_IDENT, while LIBAVFORMAT_IDENT probably is the
> relevant one (which is used multiple times in the same file).
>
> Signed-off-by: Martin Storsjö <martin@martin.st>
> ---
> libavformat/movenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 4c868919ae..a2c2145354 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -4108,7 +4108,7 @@ static int mov_write_uuidusmt_tag(AVIOContext *pb, AVFormatContext *s)
> avio_wb16(pb, 0x021C); /* data */
>
> if (!(s->flags & AVFMT_FLAG_BITEXACT))
> - mov_write_psp_udta_tag(pb, LIBAVCODEC_IDENT, "eng", 0x04);
> + mov_write_psp_udta_tag(pb, LIBAVFORMAT_IDENT, "eng", 0x04);
> mov_write_psp_udta_tag(pb, title->value, "eng", 0x01);
> mov_write_psp_udta_tag(pb, "2006/04/01 11:11:11", "und", 0x03);
>
LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] movenc: Use LIBAVFORMAT_IDENT instead of LIBAVCODEC_IDENT
2022-03-12 21:46 ` James Almer
@ 2022-03-12 22:28 ` Martin Storsjö
0 siblings, 0 replies; 3+ messages in thread
From: Martin Storsjö @ 2022-03-12 22:28 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Sat, 12 Mar 2022, James Almer wrote:
>
>
> On 3/11/2022 11:23 AM, Martin Storsjö wrote:
>> The muxer seems to have had one seemingly accidental use of
>> LIBAVCODEC_IDENT, while LIBAVFORMAT_IDENT probably is the
>> relevant one (which is used multiple times in the same file).
>>
>> Signed-off-by: Martin Storsjö <martin@martin.st>
>> ---
>> libavformat/movenc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
>> index 4c868919ae..a2c2145354 100644
>> --- a/libavformat/movenc.c
>> +++ b/libavformat/movenc.c
>> @@ -4108,7 +4108,7 @@ static int mov_write_uuidusmt_tag(AVIOContext *pb,
> AVFormatContext *s)
>> avio_wb16(pb, 0x021C); /* data */
>>
>> if (!(s->flags & AVFMT_FLAG_BITEXACT))
>> - mov_write_psp_udta_tag(pb, LIBAVCODEC_IDENT, "eng",
> 0x04);
>> + mov_write_psp_udta_tag(pb, LIBAVFORMAT_IDENT, "eng",
> 0x04);
>> mov_write_psp_udta_tag(pb, title->value, "eng", 0x01);
>> mov_write_psp_udta_tag(pb, "2006/04/01 11:11:11", "und", 0x03);
>>
>
> LGTM
Thanks, pushed.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-12 22:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-11 14:23 [FFmpeg-devel] [PATCH] movenc: Use LIBAVFORMAT_IDENT instead of LIBAVCODEC_IDENT Martin Storsjö
2022-03-12 21:46 ` James Almer
2022-03-12 22:28 ` Martin Storsjö
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git